Refactor htmx and fetch-action related code by wxiaoguang · Pull Request #37186 · go-gitea/gitea

wxiaoguang · 2026-04-12T08:26:50Z

This is the first step (the hardest part). I have tested:

repo file list last commit message lazy load
admin server status monitor
watch/unwatch (normal page, watchers page)
star/unstar (normal page, watchers page)
project view, delete column
workflow dispatch, switch the branch
commit page: load branches and tags referencing this commit

The legacy "data-redirect" attribute is removed, it only makes the page reload (sometimes using an incorrect link).

Also did cleanup for some devtest pages.

Next PR will completely remove htmx without introducing so many JS code changes.

wxiaoguang · 2026-04-12T08:26:58Z

Repo file list lazy load

Workflow dispatch

Commit page

Copilot

Pull request overview

This PR is an initial refactor step to replace several htmx-driven interactions with the existing fetch-action mechanism plus a lightweight “fetch sync” DOM update path (including optional Idiomorph morphing), preparing for later removal of htmx.

Changes:

Reworked common-fetch-action to support sync HTML responses (data-fetch-sync) and periodic/auto triggers (data-fetch-trigger).
Updated templates to use data-fetch-* attributes for watch/unwatch, star/unstar, repo file list last-commit lazy loading, and admin system status refresh.
Removed the htmx morph extension wiring and added direct Idiomorph usage/type declarations.

Reviewed changes

Copilot reviewed 16 out of 17 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
web_src/js/globals.ts	Stops loading the htmx Idiomorph extension globally.
web_src/js/features/common-fetch-action.ts	Core refactor: adds sync DOM update path, triggers, and Idiomorph integration.
web_src/css/repo/home-file-list.css	Tweaks loading indicator styling for file list cells.
types.d.ts	Adds a local module declaration for `idiomorph`.
templates/repo/watch_unwatch.tmpl	Switches watch/unwatch to `link-action` + fetch sync update.
templates/repo/star_unstar.tmpl	Switches star/unstar to `link-action` + fetch sync update.
templates/repo/view_list.tmpl	Replaces htmx last-commit lazy loading with fetch-trigger + Idiomorph sync.
templates/repo/user_cards.tmpl	Replaces htmx refresh trigger with `fetch-reload` marker for post-sync refresh.
templates/projects/view.tmpl	Renames method attribute to `data-fetch-action-method`.
templates/base/head.tmpl	Removes `hx-ext="morph"` from `<body>`.
templates/admin/system_status.tmpl	Converts system status refresh to periodic fetch trigger + Idiomorph sync.
templates/admin/dashboard.tmpl	Removes wrapper htmx refresh container; uses system_status template directly.
routers/web/web.go	Changes `/lastcommit/*` route from POST to GET.
routers/web/repo/watch.go	Removes `HX-Trigger` response header usage.
routers/web/repo/star.go	Removes `HX-Trigger` response header usage.
routers/web/repo/view.go	Adjusts debug helper for clearing commit info (now only clears half).
eslint.config.ts	Removes restricted-import entry for `idiomorph/htmx` since it’s no longer globally loaded.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

bircni

Had a look at it 👍

silverwind · 2026-04-13T16:46:28Z

Should probably add some E2E tests for the high-value mechanisms affected here. If you like I can have a look at that.

wxiaoguang · 2026-04-13T16:48:44Z

Should probably add some E2E tests for the high-value mechanisms affected here. If you like I can have a look at that.

There will be more changes. E2E is too early. It can be added after the htmx removal.

silverwind

Big change surface. I hope it was all tested. Next PR should include some E2E tests to solidify no chances for regressions.

silverwind · 2026-04-13T21:52:20Z

 		resp.WriteHeader(http.StatusBadRequest)
 		return
 	}
 	resp.Header().Add("Location", redirect)


codeql flagged here with https://github.com/go-gitea/gitea/security/code-scanning/192, false positive?

False positive.

Actually we have a real security problem to fix in "external render helper".

-> Add test for "fetch redirect", add CSS value validation for external render #37207

* main: Add comment for the design of "user activity time" (go-gitea#37195) fix(api): handle missing base branch in PR commits API (go-gitea#37193) Refactor htmx and fetch-action related code (go-gitea#37186) Fix encoding for Matrix Webhooks (go-gitea#37190) Always show owner/repo name in compare page dropdowns (go-gitea#37172) fix(api): handle fork-only commits in compare API (go-gitea#37185) Improve Contributing docs and set a release schedule (go-gitea#37109) Update Nix flake (go-gitea#37183) Remove outdated RunUser logic (go-gitea#37180) Refactor flash message and remove SanitizeHTML template func (go-gitea#37179) Indicate form field readonly via background (go-gitea#37175) Remove dead CSS rules (go-gitea#37173) Fix flaky `TestCatFileBatch/QueryTerminated` test (go-gitea#37159) Implement logout redirection for reverse proxy auth setups (go-gitea#36085) Add missing `//nolint:depguard` (go-gitea#37162)

GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 12, 2026

github-actions Bot added topic/code-linting modifies/go labels Apr 12, 2026

wxiaoguang force-pushed the refactor-htmx branch from a82b0cf to ea41d60 Compare April 12, 2026 08:28

wxiaoguang mentioned this pull request Apr 12, 2026

Remove htmx #37079

Closed

wxiaoguang force-pushed the refactor-htmx branch 3 times, most recently from b7bf493 to 4001304 Compare April 12, 2026 09:20

wxiaoguang requested a review from Copilot April 12, 2026 09:36

Copilot started reviewing on behalf of wxiaoguang April 12, 2026 09:37 View session

Copilot AI reviewed Apr 12, 2026

View reviewed changes

wxiaoguang force-pushed the refactor-htmx branch from 4001304 to 3b4bcba Compare April 12, 2026 09:52

wxiaoguang requested a review from Copilot April 12, 2026 09:52

Copilot started reviewing on behalf of wxiaoguang April 12, 2026 09:53 View session

This comment was marked as outdated.

Sign in to view

wxiaoguang force-pushed the refactor-htmx branch from 3b4bcba to 3957550 Compare April 12, 2026 12:07

wxiaoguang requested a review from Copilot April 12, 2026 12:08

Copilot started reviewing on behalf of wxiaoguang April 12, 2026 12:11 View session

This comment was marked as outdated.

Sign in to view

wxiaoguang force-pushed the refactor-htmx branch from 3957550 to d20e2d3 Compare April 12, 2026 12:43

wxiaoguang requested a review from Copilot April 12, 2026 12:51

Copilot started reviewing on behalf of wxiaoguang April 12, 2026 12:52 View session

wxiaoguang force-pushed the refactor-htmx branch from d20e2d3 to 6e62cf8 Compare April 12, 2026 12:56

This comment was marked as outdated.

Sign in to view

wxiaoguang force-pushed the refactor-htmx branch from 6e62cf8 to 1adeebb Compare April 12, 2026 13:00

wxiaoguang added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Apr 12, 2026

wxiaoguang force-pushed the refactor-htmx branch from 1adeebb to b85bc2d Compare April 12, 2026 13:32

wxiaoguang force-pushed the refactor-htmx branch 5 times, most recently from 1c3a37a to 070c065 Compare April 13, 2026 07:06

fix

563d17f

wxiaoguang force-pushed the refactor-htmx branch from 070c065 to 563d17f Compare April 13, 2026 07:15

bircni approved these changes Apr 13, 2026

View reviewed changes

GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 13, 2026

silverwind reviewed Apr 13, 2026

View reviewed changes

Comment thread types.d.ts

silverwind reviewed Apr 13, 2026

View reviewed changes

Comment thread web_src/css/repo/home-file-list.css

silverwind reviewed Apr 13, 2026

View reviewed changes

Comment thread web_src/js/features/common-fetch-action.ts Outdated

silverwind reviewed Apr 13, 2026

View reviewed changes

Comment thread web_src/js/features/common-fetch-action.ts Outdated

use $morph, fix string quote

1ef3e27

silverwind approved these changes Apr 13, 2026

View reviewed changes

GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 13, 2026

bircni added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 13, 2026

Merge branch 'main' into refactor-htmx

09a07e7

wxiaoguang enabled auto-merge (squash) April 13, 2026 18:07

Merge branch 'main' into refactor-htmx

cdee90f

wxiaoguang merged commit 6bcb666 into go-gitea:main Apr 13, 2026
26 checks passed

GiteaBot added this to the 1.27.0 milestone Apr 13, 2026

GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 13, 2026

silverwind reviewed Apr 13, 2026

View reviewed changes

wxiaoguang deleted the refactor-htmx branch April 14, 2026 03:00

Uh oh!

Conversation

wxiaoguang commented Apr 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wxiaoguang commented Apr 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Repo file list lazy load

Workflow dispatch

Commit page

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

bircni left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

silverwind commented Apr 13, 2026

Uh oh!

Uh oh!

wxiaoguang commented Apr 13, 2026

Uh oh!

Uh oh!

silverwind left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

silverwind Apr 13, 2026

Choose a reason for hiding this comment

Uh oh!

wxiaoguang Apr 14, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

wxiaoguang commented Apr 12, 2026 •

edited

Loading

wxiaoguang commented Apr 12, 2026 •

edited

Loading