Remove outdated RunUser logic#37180
Merged
wxiaoguang merged 2 commits intogo-gitea:mainfrom Apr 12, 2026
Merged
Conversation
GiteaBot
added
the
lgtm/need 2
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the installation flow to reflect current RUN_USER semantics (defaulting to the current OS user via user.CurrentUsername()), removing outdated Windows-specific logic and an install-time validation that no longer aligns with how RUN_USER is determined.
Changes:
- Simplifies install page defaults by always using
setting.RunUserfor theRunUserform field. - Removes the install-time “run user must match current user” validation and deletes the now-unused
install.run_user_not_matchen-US locale entry. - Improves the startup fatal log message when the configured
RUN_USERdoesn’t match the current user.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| routers/install/install.go | Removes outdated Windows RunUser override and drops install-time run-user mismatch validation. |
| options/locale/locale_en-US.json | Removes the no-longer-referenced install.run_user_not_match translation key. |
| modules/setting/setting.go | Clarifies the fatal log message emitted when RUN_USER mismatches the running OS user after install lock. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
wxiaoguang
force-pushed
the
fix-run-user
branch
from
96dfad1 to
c447fa4
Compare
github-actions
Bot
added
the
docs-update-needed
wxiaoguang
force-pushed
the
fix-run-user
branch
from
0cb3bf7 to
c447fa4
Compare
lunny
approved these changes
Apr 11, 2026
GiteaBot
added
lgtm/need 1
Zettat123
approved these changes
Apr 11, 2026
GiteaBot
added
lgtm/done
bircni
approved these changes
Apr 11, 2026
wxiaoguang
added a commit
to GiteaBot/gitea
that referenced
this pull request
Apr 12, 2026
lunny
pushed a commit
that referenced
this pull request
Apr 13, 2026
…, #37180) (#37184) Backport #37175 by @silverwind The `Run As Username` field on the install page was a `readonly` input that looked editable but wasn't, confusing users. Style `readonly` inputs with a subtle background, matching other frameworks. <img width="735" height="131" alt="image" src="https://github.com/user-attachments/assets/cb76ce71-faab-4300-811e-e4c503b59f9a" /> Backport #37180 The comment "so just use current one if config says default" is not right anymore: "git" isn't the "default" value of RunUser (Comment out app.example.ini #15807). The RunUser's value is from current session's username. Fixes #37174 --------- Signed-off-by: wxiaoguang <wxiaoguang@gmail.com> Signed-off-by: silverwind <me@silverwind.io> Co-authored-by: silverwind <me@silverwind.io> Co-authored-by: Claude (Opus 4.6) <noreply@anthropic.com> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Apr 14, 2026
* main: Add comment for the design of "user activity time" (go-gitea#37195) fix(api): handle missing base branch in PR commits API (go-gitea#37193) Refactor htmx and fetch-action related code (go-gitea#37186) Fix encoding for Matrix Webhooks (go-gitea#37190) Always show owner/repo name in compare page dropdowns (go-gitea#37172) fix(api): handle fork-only commits in compare API (go-gitea#37185) Improve Contributing docs and set a release schedule (go-gitea#37109) Update Nix flake (go-gitea#37183) Remove outdated RunUser logic (go-gitea#37180) Refactor flash message and remove SanitizeHTML template func (go-gitea#37179) Indicate form field readonly via background (go-gitea#37175) Remove dead CSS rules (go-gitea#37173) Fix flaky `TestCatFileBatch/QueryTerminated` test (go-gitea#37159) Implement logout redirection for reverse proxy auth setups (go-gitea#36085) Add missing `//nolint:depguard` (go-gitea#37162)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
That logic is from 2014~2015 gogs/gogs#660, it unclear why it is necessary or whether it is still needed (whether Windows is still special)
The comment "so just use current one if config says default" is not right anymore: "git" isn't the "default" value of RunUser (Comment out app.example.ini #15807). The RunUser's value is from current session's username.