Add test for "fetch redirect", add CSS value validation for external render#37207
Merged
wxiaoguang merged 5 commits intogo-gitea:mainfrom Apr 14, 2026
Merged
Add test for "fetch redirect", add CSS value validation for external render#37207wxiaoguang merged 5 commits intogo-gitea:mainfrom
wxiaoguang merged 5 commits intogo-gitea:mainfrom
Conversation
GiteaBot
added
the
lgtm/need 2
wxiaoguang
changed the title
wxiaoguang
force-pushed
the
fix-security
branch
from
5dda12e to
26fb2a8
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Adds coverage for the fetch-based redirect delegate and introduces validation for the gitea-iframe-bgcolor query parameter used by the external render iframe helper to reduce CSS injection risk.
Changes:
- Add
isValidCssColorand gate iframe background style injection on validation. - Add a unit test for CSS color validation.
- Add Go unit tests for
FetchRedirectDelegateand adjust bad-request handling to usehttp.Error.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| web_src/js/external-render-helper.ts | Adds CSS color validation and uses it before injecting background styles |
| web_src/js/external-render-helper.test.ts | Adds unit tests for the new CSS color validator |
| routers/common/redirect.go | Uses http.Error on invalid requests; annotates redirect header logic |
| routers/common/redirect_test.go | Adds tests for allowed/blocked redirect behaviors |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
wxiaoguang
force-pushed
the
fix-security
branch
from
26fb2a8 to
9c6e733
Compare
wxiaoguang
force-pushed
the
fix-security
branch
from
9c6e733 to
13e9054
Compare
wxiaoguang
force-pushed
the
fix-security
branch
from
13e9054 to
1fcdef5
Compare
wxiaoguang
commented
Apr 14, 2026
wxiaoguang
force-pushed
the
fix-security
branch
2 times, most recently
from
40c2d96 to
c87ad35
Compare
wxiaoguang
force-pushed
the
fix-security
branch
from
c87ad35 to
a47dd5c
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 6 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
lunny
approved these changes
Apr 14, 2026
GiteaBot
added
lgtm/need 1
silverwind
reviewed
Apr 14, 2026
Member
|
Why this color validation? What is the attack vector? |
Contributor
Author
Just in case, the rendered content can be changed by a malicious URL. |
silverwind
reviewed
Apr 14, 2026
bircni
approved these changes
Apr 14, 2026
GiteaBot
added
lgtm/done
bircni
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
Collaborator
|
I was unable to create a backport for 1.26. @wxiaoguang, please send one manually. 🍵 |
GiteaBot
added
the
backport/manual
wxiaoguang
added a commit
to wxiaoguang/gitea
that referenced
this pull request
Apr 14, 2026
Contributor
Author
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Apr 17, 2026
* main: Replace `dropzone` with `@deltablot/dropzone` (go-gitea#37237) Add `ExternalIDClaim` option for OAuth2 OIDC auth source (go-gitea#37229) Remove error returns from crypto random helpers and callers (go-gitea#37240) Use Content-Security-Policy: script nonce (go-gitea#37232) Remove htmx (go-gitea#37224) Refactor "htmx" to "fetch action" (go-gitea#37208) Fix UI regression (go-gitea#37218) Fix corrupted JSON caused by goccy library (go-gitea#37214) Add test for "fetch redirect", add CSS value validation for external render (go-gitea#37207) Fix incorrect concurrency check (go-gitea#37205) refactor: simplify ParseCatFileTreeLine and catBatchParseTreeEntries (go-gitea#37210) Update go js py dependencies (go-gitea#37204)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See the new tests and comments
By the way, fix the checkAppUrl message for #37212 (also need to be backported together)