Add missing //nolint:depguard#37162
Merged
silverwind merged 2 commits intogo-gitea:mainfrom Apr 10, 2026
Merged
Conversation
The other files in modules/json already have //nolint:depguard comments, but jsonlegacy.go was missing it. This causes a lint error when running golangci-lint without GOEXPERIMENT=jsonv2 (which the Makefile sets). Co-Authored-By: Claude (Opus 4.6) <noreply@anthropic.com>
GiteaBot
added
the
lgtm/need 2
Contributor
There was a problem hiding this comment.
Pull request overview
Adds the missing //nolint:depguard annotation in the legacy JSON implementation so golangci-lint passes when GOEXPERIMENT=jsonv2 is not enabled (matching the pattern used by the other modules/json implementations).
Changes:
- Annotate the
encoding/jsonimport inmodules/json/jsonlegacy.gowith//nolint:depguardto satisfy depguard lint rules in non-jsonv2builds.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
lunny
approved these changes
Apr 9, 2026
GiteaBot
added
lgtm/need 1
silverwind
changed the title
nolint:depguard to jsonlegacy.go//nolint:depguard
bircni
approved these changes
Apr 10, 2026
GiteaBot
added
lgtm/done
silverwind
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
Apr 10, 2026
When running `golangci-lint` without `GOEXPERIMENT=jsonv2`, a lint error `import 'encoding/json' is not allowed` is seen. All other files in the module that import `encodings/json` have `//nolint` already, so add it. --- This PR was written with the help of Claude Opus 4.6 Co-authored-by: Claude (Opus 4.6) <noreply@anthropic.com>
silverwind
added a commit
that referenced
this pull request
Apr 10, 2026
Backport #37162 by @silverwind When running `golangci-lint` without `GOEXPERIMENT=jsonv2`, a lint error `import 'encoding/json' is not allowed` is seen. All other files in the module that import `encodings/json` have `//nolint` already, so add it. --- This PR was written with the help of Claude Opus 4.6 Co-authored-by: silverwind <me@silverwind.io> Co-authored-by: Claude (Opus 4.6) <noreply@anthropic.com>
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Apr 14, 2026
* main: Add comment for the design of "user activity time" (go-gitea#37195) fix(api): handle missing base branch in PR commits API (go-gitea#37193) Refactor htmx and fetch-action related code (go-gitea#37186) Fix encoding for Matrix Webhooks (go-gitea#37190) Always show owner/repo name in compare page dropdowns (go-gitea#37172) fix(api): handle fork-only commits in compare API (go-gitea#37185) Improve Contributing docs and set a release schedule (go-gitea#37109) Update Nix flake (go-gitea#37183) Remove outdated RunUser logic (go-gitea#37180) Refactor flash message and remove SanitizeHTML template func (go-gitea#37179) Indicate form field readonly via background (go-gitea#37175) Remove dead CSS rules (go-gitea#37173) Fix flaky `TestCatFileBatch/QueryTerminated` test (go-gitea#37159) Implement logout redirection for reverse proxy auth setups (go-gitea#36085) Add missing `//nolint:depguard` (go-gitea#37162)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running
golangci-lintwithoutGOEXPERIMENT=jsonv2, a lint errorimport 'encoding/json' is not allowedis seen.All other files in the module that import
encodings/jsonhave//nolintalready, so add it.This PR was written with the help of Claude Opus 4.6