Indicate form field readonly via background, fix RunUser config (#37175, #37180)#37184
Merged
lunny merged 2 commits intogo-gitea:release/v1.26from Apr 13, 2026
Merged
Conversation
The `Run As Username` field on the install page was a `readonly` input that looked editable but wasn't, confusing users. Style `readonly` inputs with a subtle background, matching other frameworks. Fixes: go-gitea#37174 Signed-off-by: wxiaoguang <wxiaoguang@gmail.com> Signed-off-by: silverwind <me@silverwind.io> Co-authored-by: Claude (Opus 4.6) <noreply@anthropic.com> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
GiteaBot
added
modifies/templates
lgtm/need 2
wxiaoguang
changed the title
github-actions
Bot
added
modifies/go
docs-update-needed
Contributor
|
Also backport Remove outdated RunUser logic #37180 together. |
wxiaoguang
approved these changes
Apr 12, 2026
GiteaBot
added
lgtm/need 1
lunny
approved these changes
Apr 12, 2026
GiteaBot
added
lgtm/done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #37175 by @silverwind
The
Run As Usernamefield on the install page was areadonlyinput that looked editable but wasn't, confusing users. Stylereadonlyinputs with a subtle background, matching other frameworks.Backport #37180
The comment "so just use current one if config says default" is not right anymore: "git" isn't the "default" value of RunUser (Comment out app.example.ini #15807). The RunUser's value is from current session's username.
Fixes #37174