Add missing //nolint:depguard (#37162)#37170
Merged
silverwind merged 1 commit intogo-gitea:release/v1.26from Apr 10, 2026
Merged
Add missing //nolint:depguard (#37162)#37170silverwind merged 1 commit intogo-gitea:release/v1.26from
//nolint:depguard (#37162)#37170silverwind merged 1 commit intogo-gitea:release/v1.26from
Conversation
When running `golangci-lint` without `GOEXPERIMENT=jsonv2`, a lint error `import 'encoding/json' is not allowed` is seen. All other files in the module that import `encodings/json` have `//nolint` already, so add it. --- This PR was written with the help of Claude Opus 4.6 Co-authored-by: Claude (Opus 4.6) <noreply@anthropic.com>
GiteaBot
added
the
lgtm/need 2
silverwind
approved these changes
Apr 10, 2026
GiteaBot
added
lgtm/need 1
bircni
approved these changes
Apr 10, 2026
GiteaBot
added
lgtm/done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #37162 by @silverwind
When running
golangci-lintwithoutGOEXPERIMENT=jsonv2, a lint errorimport 'encoding/json' is not allowedis seen.All other files in the module that import
encodings/jsonhave//nolintalready, so add it.This PR was written with the help of Claude Opus 4.6