Conversation
* Add Chart CR * Add changelog
* Generate YAML files * Add property descriptions * Update infrastructure.giantswarm.io_g8scontrolplane.yaml * Fix comment
| AWS-specific configuration details. | ||
| type: object | ||
| properties: | ||
| cni: |
There was a problem hiding this comment.
Just as a heads-up. With Cluster API this value gets defined in the provider independent ClusterSpec. Since we aren't able to handle this structure in the aws-operator at the moment we decided to keep it here for now.
There was a problem hiding this comment.
Why we don't use the same structure then?
There was a problem hiding this comment.
I changed the field to match upstream, but not as an array, I think that would cause more confusion...
| } | ||
| } | ||
|
|
||
| func Test_GenerateChartYAML(t *testing.T) { |
There was a problem hiding this comment.
@tfussell doesn't that collide with your work on generating CRDs?
paurosello
requested review from
a team
and removed request for
anvddriesch and
xh3b4sd
|
Closing in favor of #413 |
| ## [Unreleased] | ||
|
|
||
| ## [0.2.3] - 2020-04-08 | ||
| - Add pod networking parameters |
There was a problem hiding this comment.
I'd like those changelogs to be more meaningful. The biggest value for me (as a dev) is to see the migration path from one version to another. What those changes are doing can be figured from the docs.
| - Add pod networking parameters | |
| ### Added | |
| - Add add `.spec.pods` field to `awsconfigs.infrastructure.giantswarm.io` CR. |
5 participants
Checklist