This repository was archived by the owner on Oct 30, 2024. It is now read-only.
Conversation
xh3b4sd
approved these changes
Apr 10, 2020
Contributor
xh3b4sd
left a comment
xh3b4sd
left a comment
There was a problem hiding this comment.
Thanks for sorting that out. You do you.
| infrastructureRef: | ||
| description: | | ||
| Reference to an [AWSControlPlane](https://docs.giantswarm.io/reference/cp-k8s-api/awscontrolplanes.infrastructure.giantswarm.io/) | ||
| resource defining provider specific details for the c |
Contributor
There was a problem hiding this comment.
For the what? There got probably something lost.
anvddriesch
approved these changes
Apr 14, 2020
Contributor
anvddriesch
left a comment
anvddriesch
left a comment
There was a problem hiding this comment.
Looks good to me other than what Tim already commented on :)
marians
commented
Apr 15, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards https://github.com/giantswarm/giantswarm/issues/8804