This repository was archived by the owner on Oct 30, 2024. It is now read-only.
Add pods fields to AWSCluster#413
Merged
teemow merged 7 commits intoimprove-generationfrom Apr 16, 2020
Merged
Conversation
marians
reviewed
Apr 16, 2020
|
|
||
| ### Changed | ||
|
|
||
| - Add pod field to AWSCluster. |
Member
There was a problem hiding this comment.
Suggested change
| - Add pod field to AWSCluster. | |
| - Add `.spec.cluster.pods` field to AWSCluster. |
marians
reviewed
Apr 16, 2020
Comment on lines
+114
to
+115
| description: Subnet size, expresses as the count of leading | ||
| 1 bits in the subnet mask of this subnet. |
Member
There was a problem hiding this comment.
If the property is expected to carry a string like "1.2.3.4/8" then I think this description does not explain it well. I would expect something like
"IPv4 address block used for pods, in CIDR notation."
Also we might want to provide a validation regex.
Member
|
@teemow That's a way to make me feel "heard" ;-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist