Skip to content
This repository was archived by the owner on Oct 30, 2024. It is now read-only.

Add Chart CR#406

Merged
pipo02mix merged 2 commits intomasterfrom
chart
Apr 14, 2020
Merged

Add Chart CR#406
pipo02mix merged 2 commits intomasterfrom
chart

Conversation

@pipo02mix
Copy link
Contributor

@pipo02mix pipo02mix commented Apr 9, 2020

Towards giantswarm/giantswarm#8804

  • Adds Chart CRD and CR files generated by unit tests
  • Adds Chart property descriptions to the schema

Checklist

  • Consider SIG UX feedback.
  • Update changelog in CHANGELOG.md.

@pipo02mix pipo02mix self-assigned this Apr 9, 2020
@pipo02mix pipo02mix requested review from a team April 9, 2020 21:48
marians
marians approved these changes Apr 14, 2020
View reviewed changes
Copy link
Member

@marians marians left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glanced over it and it seems as if everything is there. 👍

@pipo02mix pipo02mix merged commit 51e276a into master Apr 14, 2020
@pipo02mix pipo02mix deleted the chart branch April 14, 2020 20:32
teemow added a commit that referenced this pull request Apr 16, 2020
@teemow
Merge branch 'master' into improve-generation
33fbb74 
* master:
  use architect-orb v0.8.8 (#408)
  Replace DeepCopyTime with metav1.Time (#407)
  Add missing releases to changelog (#411)
  Document G8sControlPlane CRD (#405)
  Add Chart CR (#406)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@marians marians marians approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@pipo02mix pipo02mix

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pipo02mix @marians