This repository was archived by the owner on Oct 30, 2024. It is now read-only.
Conversation
kopiczko
approved these changes
Apr 13, 2020
|
|
||
| var scheme = runtime.NewScheme() | ||
| var codecs = serializer.NewCodecFactory(scheme) | ||
| -var parameterCodec = runtime.NewParameterCodec(scheme) |
Contributor
There was a problem hiding this comment.
I'd rather replace that with var parameterCodec = runtime.NewParameterCodec(scheme) // nolint just in case.
Comment on lines
+138
to
+140
| StateActive ReleaseState = "active" | ||
| StateDeprecated ReleaseState = "deprecated" | ||
| StateWIP ReleaseState = "wip" |
Contributor
There was a problem hiding this comment.
Is exporting this a legit part of this change?
Contributor
Author
There was a problem hiding this comment.
The linter didn't like the unexported variables. I guess I could add a // nolint comment here, but it also seems reasonable to export them. Not sure.
Contributor
There was a problem hiding this comment.
Linter didn't like unexported?! I'd prefer // nolint but I'm not big on that here.
Contributor
Author
There was a problem hiding this comment.
I made these unexported again based on your suggestion.
Contributor
Author
|
Comments addressed. Going with this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist