Skip to content
This repository was archived by the owner on Oct 30, 2024. It is now read-only.

Replace DeepCopyTime with metav1.Time#407

Merged
tfussell merged 10 commits intomasterfrom
replace-deepcopytime
Apr 16, 2020
Merged

Replace DeepCopyTime with metav1.Time#407
tfussell merged 10 commits intomasterfrom
replace-deepcopytime

Conversation

@tfussell
Copy link
Contributor

@tfussell tfussell commented Apr 13, 2020 •
edited
Loading

Checklist

  • Consider SIG UX feedback.
  • Update changelog in CHANGELOG.md.

@tfussell tfussell self-assigned this Apr 13, 2020
@tfussell tfussell marked this pull request as ready for review April 13, 2020 15:03
kopiczko
kopiczko approved these changes Apr 13, 2020
View reviewed changes
Copy link
Contributor

@kopiczko kopiczko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I hope this doesn't break compatibility too much.

@tfussell
Copy link
Contributor Author

tfussell commented Apr 13, 2020

LGTM, I hope this doesn't break compatibility too much.

Same here. I have trouble telling what the effect will be. I will see if I can test it somehow.

tfussell
tfussell commented Apr 13, 2020
View reviewed changes
pkg/apis/infrastructure/v1alpha2/common_cluster_status_funcs.go
if len(p) == 0 {
p = append(p, g...)
conditionGroups = conditionGroups[1:len(conditionGroups)]
conditionGroups = conditionGroups[1:]
Copy link
Contributor Author

@tfussell tfussell Apr 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some extra cleanup--semantics are identical as far as I know.

@kopiczko
Copy link
Contributor

kopiczko commented Apr 13, 2020

LGTM, I hope this doesn't break compatibility too much.

Same here. I have trouble telling what the effect will be. I will see if I can test it somehow.

Maybe try vendoring in aws-operator.

@tfussell
Copy link
Contributor Author

tfussell commented Apr 16, 2020

I tried this in aws-operator@master and didn't have any issues. In aws-operator@legacy, I discovered that statusresource had to be updated, but there isn't much to it. I'll do that tomorrow. Going with this for now.

@tfussell tfussell merged commit 80dad41 into master Apr 16, 2020
teemow added a commit that referenced this pull request Apr 16, 2020
@teemow
Merge branch 'master' into improve-generation
33fbb74 
* master:
  use architect-orb v0.8.8 (#408)
  Replace DeepCopyTime with metav1.Time (#407)
  Add missing releases to changelog (#411)
  Document G8sControlPlane CRD (#405)
  Add Chart CR (#406)
@xh3b4sd xh3b4sd deleted the replace-deepcopytime branch April 17, 2020 14:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@kopiczko kopiczko kopiczko approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@tfussell tfussell

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tfussell @kopiczko