Remove unnecessary files from SentryCocoaFramework before packing #4602
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: James Crosswell <[email protected]>
Fix WASM0001 warnings when building Blazor WebAssembly projects that came out from our native bindings. The fix was to change the way we represent `sentry_value_t` in C# side, instead of using `FieldOffset`, we use a backing field along with getters and setters for the variable as a `double`, or `ulong`. Fixes #3369
Co-authored-by: GitHub <[email protected]>
Co-authored-by: GitHub <[email protected]> Co-authored-by: James Crosswell <[email protected]>
Co-authored-by: GitHub <[email protected]> Co-authored-by: James Crosswell <[email protected]>
* chore: update scripts/update-java.ps1 to 8.22.0
* Metadata.xml: remove UpdateStatus to avoid CS0108 for conflicting _members fields in nested subclasses
Sentry.Bindings.Android net8.0-android34.0 failed with 3 error(s) (6.9s)
/home/jpnurmi/Projects/sentry/sentry-dotnet/src/Sentry.Bindings.Android/obj/Release/net8.0-android34.0/generated/src/Sentry.JavaSdk.UpdateStatus.cs(24,35): error CS0108: 'UpdateStatus.NewRelease._members' hides inherited member 'UpdateStatus._members'. Use the new keyword if hiding was intended.
/home/jpnurmi/Projects/sentry/sentry-dotnet/src/Sentry.Bindings.Android/obj/Release/net8.0-android34.0/generated/src/Sentry.JavaSdk.UpdateStatus.cs(90,35): error CS0108: 'UpdateStatus.UpdateError._members' hides inherited member 'UpdateStatus._members'. Use the new keyword if hiding was intended.
/home/jpnurmi/Projects/sentry/sentry-dotnet/src/Sentry.Bindings.Android/obj/Release/net8.0-android34.0/generated/src/Sentry.JavaSdk.UpdateStatus.cs(157,35): error CS0108: 'UpdateStatus.UpToDate._members' hides inherited member 'UpdateStatus._members'. Use the new keyword if hiding was intended.
Sentry.Bindings.Android net9.0-android35.0 failed with 3 error(s) (7.8s)
/home/jpnurmi/Projects/sentry/sentry-dotnet/src/Sentry.Bindings.Android/obj/Release/net9.0-android35.0/generated/src/Sentry.JavaSdk.UpdateStatus.cs(24,35): error CS0108: 'UpdateStatus.NewRelease._members' hides inherited member 'UpdateStatus._members'. Use the new keyword if hiding was intended.
/home/jpnurmi/Projects/sentry/sentry-dotnet/src/Sentry.Bindings.Android/obj/Release/net9.0-android35.0/generated/src/Sentry.JavaSdk.UpdateStatus.cs(90,35): error CS0108: 'UpdateStatus.UpdateError._members' hides inherited member 'UpdateStatus._members'. Use the new keyword if hiding was intended.
/home/jpnurmi/Projects/sentry/sentry-dotnet/src/Sentry.Bindings.Android/obj/Release/net9.0-android35.0/generated/src/Sentry.JavaSdk.UpdateStatus.cs(157,35): error CS0108: 'UpdateStatus.UpToDate._members' hides inherited member 'UpdateStatus._members'. Use the new keyword if hiding was intended
---------
Co-authored-by: GitHub <[email protected]>
Co-authored-by: J-P Nurmi <[email protected]>
Co-authored-by: Sentry Github Bot <[email protected]> Co-authored-by: James Crosswell <[email protected]>
Co-authored-by: GitHub <[email protected]>
Co-authored-by: Stefan Pölz <[email protected]>
…4544) Co-authored-by: Sentry Github Bot <[email protected]> Co-authored-by: Stefan Pölz <[email protected]>
Co-authored-by: GitHub <[email protected]>
* build(deps): bump github/codeql-action from 3.30.3 to 3.30.5 Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.30.3 to 3.30.5. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@192325c...3599b3b) --- updated-dependencies: - dependency-name: github/codeql-action dependency-version: 3.30.5 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> * Update .github/workflows/codeql-analysis.yml Co-authored-by: Stefan Pölz <[email protected]> * Update .github/workflows/codeql-analysis.yml Co-authored-by: Stefan Pölz <[email protected]> --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: James Crosswell <[email protected]> Co-authored-by: Stefan Pölz <[email protected]>
Co-authored-by: GitHub <[email protected]>
Co-authored-by: GitHub <[email protected]>
Workaround for #4292: - #4292 (comment) Replaces #4533 (targets version6 branch instead of main so that we can get adequate feedback from users before releasing this).
jamescrosswell
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## version6 #4602 +/- ##
===========================================
Coverage ? 73.09%
===========================================
Files ? 479
Lines ? 17385
Branches ? 3432
===========================================
Hits ? 12707
Misses ? 3819
Partials ? 859 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jpnurmi
approved these changes
Oct 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workaround for #4292:
Replaces #4533. Unlike that PR however, this PR targets the
version6branch instead ofmain, so that we can get adequate feedback from users before releasing this.