-
-
Notifications
You must be signed in to change notification settings - Fork 226
test(ci): .NET 5.0 with MSBuild 16 #4569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4569 +/- ##
==========================================
+ Coverage 73.46% 73.47% +0.01%
==========================================
Files 482 482
Lines 17679 17679
Branches 3495 3495
==========================================
+ Hits 12988 12990 +2
+ Misses 3800 3798 -2
Partials 891 891 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
567869c to
2beb045
Compare
|
@Flash0ver Turns out we didn't need On the contrary, injecting MSBuild 16 into Fortunately, the same warning can be produced with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is Amazing.MaxValue! It will give us more coverage and confidence when making changes to non-/lib/ Assets, like /build/(*.props|.targets) and /analyzers/* (Compiler Extensions like Source Generators) 🥔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: Stefan Pölz <[email protected]>
Co-authored-by: Stefan Pölz <[email protected]>

This PR adds an integration test that builds and runs a minimal Sentry .NET app with different .NET SDK and MSBuild versions:
.NET 5.0 installation and tests are excluded on macOS because .NET 5.0 does not support ARM64 on macOS. However, the test reproduces the warning reported in #4554 both on Windows and Linux:
Once #4554 has been fixed, we could consider
TreatWarningsAsErrors=trueto prevent new warnings from surfacing in the future.Close: #4299
#skip-changelog
Note
Adds MSBuild integration tests for .NET 5/8/9 and updates CI to install .NET 5 SDK and libssl1 on Linux, plus packs during MSBuild.
libssl1.1on Linux viascripts/install-libssl1.shin./github/actions/environment..NET 5.0SDK (excluded on macOS ARM64) alongside existing SDK setup.Restore,Build,Packand executes integration tests viaintegration-test/msbuild.Tests.ps1.integration-test/msbuild.Tests.ps1builds/runs a console app via MSBuild acrossnet5.0(when supported),net8.0, andnet9.0, validating Sentry capture.integration-test/nuget5.configfor NuGet 5 (no packageSourceMapping) used with .NET 5.integration-test/common.ps1to usedotnet restore /p:CheckEolTargetFramework=false.scripts/install-libssl1.shto installopenssl1.1-compat(Alpine) orlibssl1.1(Ubuntu).Written by Cursor Bugbot for commit dc2ddfd. This will update automatically on new commits. Configure here.