-
-
Notifications
You must be signed in to change notification settings - Fork 226
ref(logs): remove ExperimentalAttribute and Experimental type from SentrySdk #4567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4567 +/- ##
==========================================
+ Coverage 73.45% 73.47% +0.02%
==========================================
Files 480 482 +2
Lines 17589 17679 +90
Branches 3469 3495 +26
==========================================
+ Hits 12920 12990 +70
- Misses 3785 3798 +13
- Partials 884 891 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@sentry review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a quick question...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Remove
[ExperimentalAttribute]from all Logs-APIsExperimentaltype fromSentrySdkKeep
Experimentaltype onSentryOptionsExample
We think we are fine with the API shape, but still keep one
Experimental(onSentryOptions) before we go officially stable.Note
Removes experimental markers from Structured Logs APIs and replaces SentrySdk.Experimental.Logger with SentrySdk.Logger, updating adapters, samples, API approvals, and changelog while keeping SentryOptions.Experimental.
ExperimentalAttributefromSentryLog,SentryLogLevel, andSentryStructuredLoggermethods, and fromIHub.Logger/DisabledHub.Logger.SentrySdk.Experimental.Loggerwith newSentrySdk.Logger; removeSentrySdk.Experimentaltype; updateHubAdapter.Loggerto useSentrySdk.Logger.SentryOptions.Experimental(e.g.,EnableLogs,SetBeforeSendLog).SentrySdk.Logger.*and adjust comments.SentrySdk.Logger.SentrySdk.Loggerswitch.Written by Cursor Bugbot for commit cc6733e. This will update automatically on new commits. Configure here.