-
-
Notifications
You must be signed in to change notification settings - Fork 372
fix(feedback): user feedback widget in SwiftUI #5223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(feedback): user feedback widget in SwiftUI #5223
Conversation
d0b5902 to
560cf15
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5223 +/- ##
=============================================
+ Coverage 86.194% 86.228% +0.034%
=============================================
Files 407 407
Lines 35043 35065 +22
Branches 15025 15204 +179
=============================================
+ Hits 30205 30236 +31
+ Misses 4795 4788 -7
+ Partials 43 41 -2
... and 16 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
30f13a2 to
ebc84de
Compare
Sources/Swift/Integrations/UserFeedback/SentryUserFeedbackIntegrationDriver.swift
Show resolved
Hide resolved
560cf15 to
14e5aa6
Compare
|
rebased on top of #5544 to get code coverage working |
…ser-feedback-widget-in-swiftui
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| b13e93a | 1236.24 ms | 1247.33 ms | 11.08 ms |
| 8047b99 | 1226.37 ms | 1246.63 ms | 20.26 ms |
| db9572a | 1223.13 ms | 1241.60 ms | 18.47 ms |
| ac4739e | 1236.55 ms | 1258.89 ms | 22.34 ms |
| 9be5373 | 1215.92 ms | 1239.44 ms | 23.52 ms |
| e18d392 | 1228.69 ms | 1244.43 ms | 15.73 ms |
| 2481950 | 1221.04 ms | 1248.98 ms | 27.94 ms |
| db9572a | 1200.27 ms | 1234.80 ms | 34.53 ms |
| d38165b | 1211.41 ms | 1242.49 ms | 31.08 ms |
| 018037b | 1209.31 ms | 1228.33 ms | 19.03 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| b13e93a | 23.75 KiB | 855.37 KiB | 831.62 KiB |
| 8047b99 | 23.75 KiB | 855.37 KiB | 831.62 KiB |
| db9572a | 23.75 KiB | 858.64 KiB | 834.89 KiB |
| ac4739e | 23.75 KiB | 872.67 KiB | 848.92 KiB |
| 9be5373 | 23.75 KiB | 866.50 KiB | 842.75 KiB |
| e18d392 | 23.75 KiB | 866.68 KiB | 842.93 KiB |
| 2481950 | 23.74 KiB | 872.74 KiB | 849.00 KiB |
| db9572a | 23.75 KiB | 858.69 KiB | 834.93 KiB |
| d38165b | 23.75 KiB | 855.37 KiB | 831.62 KiB |
| 018037b | 23.75 KiB | 867.16 KiB | 843.41 KiB |
This reverts commit d170e0d.
This reverts commit 409a607.
This reverts commit d170e0d.
This reverts commit 409a607.
In an attempt to fix #5113, use the correct API to display a floating UIWindow in the SwiftUI app.
Requires consumers to start the sentry api from a configured scene delegate, as demonstrated in the sample swiftui apps in #5222. This would need to be added to the docs for auto injection, and may warrant a separate API to display the feedback widget (this was originally planned, but i removed it as i'd only implemented auto injection. seems we just identified a need for it) if we want to give consumers the option of starting the SDK as early as possible (in a swiftui app's init method) and be able to display the feedback widget as well.Update: The API to manually display a widget was done in #5236. This PR will fix that functionality in SwiftUI apps. A subsequent PR may attempt to fix the auto-injection situation for SwiftUI apps.
Current status:
a build issue detailed in the linked issuethis is resolved as of #5524