Skip to content

Conversation

@armcknight
Copy link
Member

In order to solve the SDK init and widget display ordering problem for SwiftUI access to connected scenes in #5223, we provide an API to manually show the widget (as well as the analogous hide method).

@github-actions
Copy link
Contributor

github-actions bot commented May 15, 2025

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against c70e8ce

@github-actions
Copy link
Contributor

github-actions bot commented May 15, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1223.08 ms 1240.65 ms 17.57 ms
Size 23.76 KiB 819.49 KiB 795.73 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
596ccc1 1233.51 ms 1244.24 ms 10.73 ms
4d3df92 1235.18 ms 1252.29 ms 17.10 ms
90d17d3 1261.18 ms 1278.18 ms 17.00 ms
7c5d161 1224.38 ms 1249.66 ms 25.28 ms
4f31f66 1213.96 ms 1236.76 ms 22.80 ms
2cf1b84 6265.25 ms 6277.98 ms 12.73 ms
a6f8b18 1236.96 ms 1240.14 ms 3.18 ms
2911760 1217.84 ms 1232.48 ms 14.64 ms
500abd8 1234.98 ms 1259.20 ms 24.22 ms
8d16504 1235.50 ms 1258.76 ms 23.26 ms

App size

Revision Plain With Sentry Diff
596ccc1 22.84 KiB 401.44 KiB 378.60 KiB
4d3df92 22.85 KiB 413.44 KiB 390.59 KiB
90d17d3 20.76 KiB 432.17 KiB 411.41 KiB
7c5d161 20.76 KiB 414.44 KiB 393.68 KiB
4f31f66 21.58 KiB 682.39 KiB 660.81 KiB
2cf1b84 20.76 KiB 431.91 KiB 411.15 KiB
a6f8b18 20.76 KiB 431.87 KiB 411.11 KiB
2911760 21.58 KiB 697.69 KiB 676.11 KiB
500abd8 22.30 KiB 851.57 KiB 829.26 KiB
8d16504 20.76 KiB 434.92 KiB 414.16 KiB

Previous results on branch: armcknight/feedback/feat/5113-manual-widget-display

Startup times

Revision Plain With Sentry Diff
d4689a4 1241.94 ms 1256.94 ms 15.00 ms
b672bef 1224.59 ms 1240.83 ms 16.24 ms
c267cc7 1229.73 ms 1254.80 ms 25.06 ms

App size

Revision Plain With Sentry Diff
d4689a4 23.76 KiB 819.40 KiB 795.64 KiB
b672bef 23.76 KiB 870.58 KiB 846.81 KiB
c267cc7 23.76 KiB 870.65 KiB 846.89 KiB

@armcknight armcknight enabled auto-merge (squash) May 15, 2025 08:46
@codecov
Copy link

codecov bot commented May 16, 2025

Codecov Report

Attention: Patch coverage is 0% with 43 lines in your changes missing coverage. Please review.

Project coverage is 92.894%. Comparing base (83ea317) to head (c70e8ce).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
...wift/Integrations/UserFeedback/SentryFeedbackAPI.m 0.000% 18 Missing ⚠️
...Feedback/SentryUserFeedbackIntegrationDriver.swift 0.000% 13 Missing ⚠️
Sources/Sentry/SentrySDK.m 0.000% 6 Missing ⚠️
Sources/Sentry/SentryUserFeedbackIntegration.m 0.000% 6 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #5236       +/-   ##
=============================================
- Coverage   92.942%   92.894%   -0.049%     
=============================================
  Files          682       683        +1     
  Lines        85786     85876       +90     
  Branches     31100     31131       +31     
=============================================
+ Hits         79732     79774       +42     
- Misses        5953      5999       +46     
- Partials       101       103        +2     
Files with missing lines Coverage Δ
...ations/UserFeedback/SentryUserFeedbackWidget.swift 0.000% <ø> (ø)
Sources/Sentry/SentrySDK.m 88.739% <0.000%> (-1.451%) ⬇️
Sources/Sentry/SentryUserFeedbackIntegration.m 26.315% <0.000%> (-12.146%) ⬇️
...Feedback/SentryUserFeedbackIntegrationDriver.swift 0.000% <0.000%> (ø)
...wift/Integrations/UserFeedback/SentryFeedbackAPI.m 0.000% <0.000%> (ø)

... and 29 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83ea317...c70e8ce. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@philprime philprime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please remember to add public add this to the public documentation so that SDK users can find manual display/hide of the feedback there too.

@armcknight armcknight merged commit 1e92222 into main May 16, 2025
50 of 76 checks passed
@armcknight armcknight deleted the armcknight/feedback/feat/5113-manual-widget-display branch May 16, 2025 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants