test: more override config #5201
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ght/ci/ios-swift-xcodegen
…s-swift6-xcodegen
…os13-swift-xcodegen
…ios-swift-cleanup
…orrect-version-setting
…t/ci/ios-swftui-xcodegen
…os15-swiftui-xcodegen
…i/visionos-swift-xcodegen
…ci/macos-swiftui-xcodegen
…i/macos-swift-xcodegen
…ios-objectivec-xcodegen
…ght/ci/ios-swift-xcodegen
…s-swift6-xcodegen
…os13-swift-xcodegen
…ios-swift-cleanup
…orrect-version-setting
…t/ci/ios-swftui-xcodegen
…os15-swiftui-xcodegen
…i/visionos-swift-xcodegen
…ci/macos-swiftui-xcodegen
…i/macos-swift-xcodegen
…ios-objectivec-xcodegen
Base automatically changed from
armcknight/test/dns-view-in-debug-menu
to
armcknight/test/restart-sdk-on-reconfig
May 16, 2025 18:48
…t/test/more-override-config
…t/test/more-override-config
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
philprime
reviewed
May 26, 2025
Sources/Swift/Integrations/SessionReplay/SentryReplayOptions.swift
Outdated
Show resolved
Hide resolved
|
@philprime It's getting long enough that I can't quite remember why these calls are already in this branch, but I'm pretty sure the reason it's not showing up for SwiftUI is due to this change not having been merged yet: #5223 |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
…t/test/more-override-config
philprime
approved these changes
Jun 16, 2025
Samples/SentrySampleShared/SentrySampleShared/SentrySDKWrapper.swift
Outdated
Show resolved
Hide resolved
…wiftui apps; move sdk init back to app delegate in swift6 app
…t/test/more-override-config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding more config option overrides and reorganizing in the yml spec. This originally started when I was moving the Camera sample app to use the sdk wrapper and shared overrides.
TODO
- [ ] Do it again, but for iOS-ObjectiveC, since we need to make sure usage of options from objc compiles, but we don't yet have other objc sample apps, so don't need an objc wrapper just yet#skip-changelog