Skip to content

Conversation

@armcknight
Copy link
Member

I assume this is the default since it wasn't even present in the main SDK's test plan, but for some reason some of these had it set to false. Change those to true and add the explicit directive to all plans.

#skip-changelog

@codecov
Copy link

codecov bot commented Jul 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.217%. Comparing base (f094996) to head (b67d7cb).
Report is 5 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #5544       +/-   ##
=============================================
+ Coverage   86.193%   86.217%   +0.023%     
=============================================
  Files          406       407        +1     
  Lines        34912     35038      +126     
  Branches     15125     15018      -107     
=============================================
+ Hits         30092     30209      +117     
- Misses        4778      4787        +9     
  Partials        42        42               

see 31 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f094996...b67d7cb. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@armcknight armcknight merged commit ac5e886 into main Jul 1, 2025
32 of 33 checks passed
@armcknight armcknight deleted the armcknight/test/code-coverage branch July 1, 2025 22:08
"target" : {
"containerPath" : "container:tvOS-Swift.xcodeproj",
"identifier" : "7B64388526A6C71A000D0F65",
"identifier" : "1A9FD4374E53BEB8AC621B3D",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did this identifier change?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My guess is that when I created the separate test plan for tvOS-SBSwift in fb7eac9, I simply copied it and only changed the name of the project, but not the identifier there, and since it's supposed to be unique, Xcode changed this one.

philipsawyerdd added a commit to justin-doordash/sentry-cocoa that referenced this pull request Sep 25, 2025
philipsawyerdd added a commit to justin-doordash/sentry-cocoa that referenced this pull request Sep 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants