[Forwardport] Removed duplicate line and added comment on variable#1
Merged
gelanivishal merged 127 commits into2.3-developfrom May 23, 2018
Merged
[Forwardport] Removed duplicate line and added comment on variable#1gelanivishal merged 127 commits into2.3-developfrom
gelanivishal merged 127 commits into2.3-developfrom
Conversation
- Merge Pull Request magento#14395 from Igloczek/magento2:extends-fix - Merged commits: 1. f5e429d
DTO setter methods are no more required, parameters can be handled through constructor for immutable state approach A setter fallback is supported
_createFromArray will not be fixed due to its eventual deprecation, since a new immutable approach is provided
…m:phoenix128/magento2 into webapi-support-immutable-construct-params
…negative price is displayed as +- 5.00 for instance. By changing the template to check of the value is actually positive a negative value will be displayed as - 5.00 and a positive value will be displayed as + 5.00
Add missing commits for \app\code\Magento\Sales\Model\Order\Email\Sender\OrderSender.php
… altered in email_invoice_set_template_vars_before Event magento#15039 - Merge Pull Request magento#15039 from gwharton/magento2:2.3-develop-10210 - Merged commits: 1. 6dff3a5
- Merge Pull Request magento#11368 from slackerzz/magento2:fix_issue_2956 - Merged commits: 1. 32e2e4d 2. b11c7e7 3. 474e43c
…oduct from /checkout/cart page after already been removed from mini-shopping cart
- Fixed setting propagation - Added regression unit tests
- Fixed static error
- Updated test names
…agento#14975 - Merge Pull Request magento#14975 from dverkade/magento2:2.3-Fix-negative-value-for-custom-option - Merged commits: 1. 3a12905
…oduct from /checkout/cart page after already been removed from mini-shopping cart - added test for the failed workflow
…oduct from /checkout/cart page after already been removed from mini-shopping cart - updated annotation
- merged latest code from mainline branch
[Team 3] Sprint 8 Delivery - bugfixes
- merged latest code from mainline branch
Accepted Public Pull Requests: - magento#15370: Fixed typo in MagentoUi abstract.js (by @VitaliyBoyko) - magento#15257: Fixes in InstantPurchase (by @mhauri)
gelanivishal
pushed a commit
that referenced
this pull request
May 25, 2018
[Backport] Added language translation for message string
gelanivishal
pushed a commit
that referenced
this pull request
Jun 19, 2018
[Backport] [Resolved : Styling <select> by changing less variables in Luma theme…
gelanivishal
pushed a commit
that referenced
this pull request
Jun 22, 2018
…nto#15726 - Merge Pull Request magento#15726 from sanjay-wagento/magento2:2.3-develop-PR-port-13026 - Merged commits: 1. ce176d2
gelanivishal
pushed a commit
that referenced
this pull request
Jun 22, 2018
gelanivishal
pushed a commit
that referenced
this pull request
Jun 22, 2018
Accepted Public Pull Requests: - magento#16275: Simplified TypeProcessor (by @joni-jones) - magento#15842: [Forwardport] Add missing table aliases to fields mapping for Customer Group filter� (by @hitesh-wagento) - magento#15744: [Forwardport] [BUGFIX] magento#15564 Generated admin API token expires immediately (by @vijay-wagento) - magento#15726: Forwardport] Feature space between category page #1 (by @sanjay-wagento) - magento#15698: [Forwardport] Variant product image in sidebar wishlist block (by @dmytro-ch) - magento#15672: [FORWARDPORT magento#15097] Add field to filter to collection (by @dverkade) - magento#16256: magento#15255 unlock customer after password reset (by @vgelani) - magento#16246: [Forwardport] array_push(...) calls behaving as '$array[] = ...', $array[] = works faster than invoking functions in PHP (by @lfluvisotto) - magento#16224: [Forwardport] Correct return type of methods and typo correction. (by @saurabh-aureate) - magento#16225: Navigation dropdown caret icon. (by @tejash-wagento) - magento#15980: Use correct error message for duplicate error key in product import (by @denteblu) Fixed GitHub Issues: - magento#15822: SQL Error: ambiguous column 'customer_group_id' in 'All customers' page in admin when extension attribute table is joined (reported by @radio) has been fixed in magento#15842 by @hitesh-wagento in 2.3-develop branch Related commits: 1. 0f23ed7 - magento#15564: 2.2.4 Created admin token has no access (reported by @krukas) has been fixed in magento#15744 by @vijay-wagento in 2.3-develop branch Related commits: 1. 7f34b22 2. 349d178 - magento#12601: A space between the category page and the main footer when applying specific settings (reported by @wd7080) has been fixed in magento#15726 by @sanjay-wagento in 2.3-develop branch Related commits: 1. ce176d2 - magento#15255: Customer who exceeded max login failures not able to login even after reset password (reported by @tizzyguy87) has been fixed in magento#16256 by @vgelani in 2.3-develop branch Related commits: 1. a108233
gelanivishal
pushed a commit
that referenced
this pull request
Jun 25, 2018
Merged with last commits
gelanivishal
pushed a commit
that referenced
this pull request
Jun 30, 2018
[Forwardport] Fixed typo mistake in function comment
gelanivishal
pushed a commit
that referenced
this pull request
Jul 4, 2018
[Forwardport] When searching for the title if search for all the segments that has …
gelanivishal
pushed a commit
that referenced
this pull request
Aug 10, 2018
Fixed a grammatical error on the vault tooltip
gelanivishal
pushed a commit
that referenced
this pull request
Oct 27, 2018
[Backport] Use route ID when creating secret keys in backend menus instead of route name
gelanivishal
pushed a commit
that referenced
this pull request
Oct 27, 2018
Fixed issues-18534: 2 wysiwyg on catalog category edit page
gelanivishal
pushed a commit
that referenced
this pull request
Nov 17, 2018
Remove unnecesary "header" block redeclaration
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original Pull Request
magento#15362
Description
Removed duplicate code and added comment on variable.
Fixed Issues (if relevant)
Manual testing scenarios
Contribution checklist