Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dropdown, Input, Loader] Elastic Animation Style had wrong color #324

Closed
wants to merge 56 commits into from
Closed

[Dropdown, Input, Loader] Elastic Animation Style had wrong color #324

wants to merge 56 commits into from

Conversation

lubber-de
Copy link
Member

@lubber-de lubber-de commented Dec 23, 2018 •
edited
Loading

Description

  • Elastic Loader in dropdown/input misses correct color setting in :before tag.
  • Also changed the static @grey or @white variables to the loader specific variables @loaderLineColorand @invertedLoaderLineColor instead. Infact the color is the same on the default theme, but using the loader specific variables is now more safe regarding the new central color mixing usage from [Colors] Central dynamic color map for every component #261

Testcase

https://fomantic-ui.com/modules/dropdown.html#loading
https://fomantic-ui.com/elements/input.html#loading

Fix

Comment out the css part to see the issue again
http://jsfiddle.net/015dbk4t/1/

Screenshot

Before

elastic_dropdown_loading

After

elastic_dropdown_loading_fix

Version

2.7.0

lubber-de and others added 30 commits November 15, 2018 08:50
@lubber-de
fix(placeholder): Respect a possible 'image icon' not occupying the s…
43de5c6 
…ame space as a real image should
@lubber-de
fix(dropdown): stop event on enterkey and multiple allowadditions to …
3393191 
…prevent form submission
@lubber-de
fix(table): thead and tbody missed alignment inheritance
86e88af
@lubber-de
fix(table): restore default vertical alignment
4dcf070
style(readme): improve consistency
e09dae7 
Removed HTML to keep consistency across GitHub and package websites like npm and yarn.
Also adds new jsDelivr badge.
fix(placeholder): respect a possible 'image icon' not occupying the s…
06ba456 
…ame space
fix(dropdown): suppress events on enter key with multiple allowAdditions
52d7502
fix(table): table wide vertical text alignment
28c557a
style(readme): improve consistency
8464d20
@ColinFrick
build: update to gulp4
a83a7d4 
Closes fomantic#112
@lubber-de
fix(table): images in tables did not display properly
9516519 
This one needs a bit of explanation:
The main cause of this bug was introduced in 2014 by Semantic-Org/Semantic-UI@400949c
It was related to issue Semantic-Org/Semantic-UI#1510, where it seemed to be fixed but the main cause was the `collapsing` class set to the cell column, which causes the width to be reduced to 1px to force the browser to reduce its width until the main occupied content got the minimum width.
So, this PR actually reverts the fix for Semantic-Org/Semantic-UI#1510 and fixes the main cause correctly now.

Closes fomantic#227
@lubber-de
feat(toast): changed title class to header
ab2dfab
@lubber-de
feat(toast): use the same color on every inverted toast
58ac7e7
@ColinFrick
fix(placeholder): append .loadUIOverrides() to the bottom
3af89df 
Closes fomantic#255
@lubber-de
feat(label): add inverted variant, basic grouping and basic tag
3df1d57 
Add inverted variant, basic grouping and basic tag as
well as some bug fixes and code clean up.

Closes fomantic#116
@lubber-de
feat(search): wrap result into object when original result is an array
f25f32e 
Closes fomantic#263
fix(security): changed event-stream version
79f24a9 
Change `event-stream` version to fix security exploit.
Refs:
  dominictarr/event-stream#116
  dominictarr/event-stream#115

Closes fomantic#268
@prudho
feat(input): add red border around error labeled input
4f34d88 
Closes fomantic#257
@lubber-de
fix(dropdown): fix select always showing remove icon
652c99d 
Closes fomantic#271
@lubber-de
fix(popup): fix correct usage for addTouchEvents=false
10bd528
@lubber-de
fix(list): make sure list settings are not applied to any "list icon"
2b2fd30
@lubber-de
fix(modal): touch scrolling (dropdown, content, focussed input) fixed
f7c0229
@lubber-de
feat(input,textarea): support corner label and icon for textarea
41c4d3d
@lubber-de
fix(message): fixed compact icon message width
536a5c1
@lubber-de
fix(dropdown): filter already selected items when using remote api
f979cfb
@lubber-de
fix(form, dropdown): formvalidation broke when id had colon in it
9c0900c
@lubber-de
fix(dropdown): fixes submenu positioning
a6e303f 
Closes 194
@lubber-de
fix(dropdown): preselected values are ignored when data has individua…
501b61c 
…l value-name
@lubber-de
fix(modal): dimmer click closed modal when allowMultiple=true even if…
d84fb23 
… onHide()=false

Closes fomantic#284
@lubber-de
refactor: remove deprecated jquery functions
ee4b02c
@lubber-de lubber-de added lang/css Anything involving CSS 🐛 bugfix labels Dec 23, 2018
@lubber-de lubber-de added this to the 2.7.x milestone Dec 23, 2018
@lubber-de lubber-de added the state/awaiting-reviews Pull requests which are waiting for reviews label Dec 23, 2018
@lubber-de lubber-de changed the title [Dropdown, Loader] Elastic Animation Style had wrong color [Dropdown, Input, Loader] Elastic Animation Style had wrong color Dec 23, 2018
@lubber-de lubber-de closed this Dec 23, 2018
@lubber-de lubber-de deleted the fix/elastic_dropdown branch December 23, 2018 21:18
@lubber-de lubber-de removed this from the 2.7.x milestone Dec 23, 2018
@lubber-de lubber-de added type/duplicate Anything which is a duplicate and removed 🐛 bugfix state/awaiting-reviews Pull requests which are waiting for reviews lang/css Anything involving CSS labels Dec 23, 2018
@lubber-de
Copy link
Member Author

messed up base branch... new PR is #325

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
type/duplicate Anything which is a duplicate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lubber-de @ColinFrick @prudho