Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dropdown, Input, Loader] Elastic Animation Style had wrong color #325

Merged
merged 1 commit into from
Dec 24, 2018
Merged

[Dropdown, Input, Loader] Elastic Animation Style had wrong color #325

merged 1 commit into from
Dec 24, 2018

Conversation

lubber-de
Copy link
Member

@lubber-de lubber-de commented Dec 23, 2018 •
edited
Loading

Description

  • Elastic Loader in dropdown/input misses correct color setting in :before tag.
  • Also changed the static @grey or @white variables to the loader specific variables @loaderLineColorand @invertedLoaderLineColor instead. Infact the color is the same on the default theme, but using the loader specific variables is now more safe regarding the new central color mixin usage from [Colors] Central dynamic color map for every component #261

Testcase

https://fomantic-ui.com/modules/dropdown.html#loading
https://fomantic-ui.com/elements/input.html#loading

Fix

Comment out the css part to see the issue again
http://jsfiddle.net/015dbk4t/1/

Screenshot

Before

elastic_dropdown_loading

After

elastic_dropdown_loading_fix

Version

2.7.0

@lubber-de lubber-de added lang/css Anything involving CSS state/awaiting-reviews Pull requests which are waiting for reviews 🐛 bugfix labels Dec 23, 2018
@lubber-de lubber-de added this to the 2.7.x milestone Dec 23, 2018
@lubber-de lubber-de mentioned this pull request Dec 23, 2018
Closed
prudho
prudho approved these changes Dec 24, 2018
View reviewed changes
Copy link
Contributor

@prudho prudho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

y0hami
y0hami approved these changes Dec 24, 2018
View reviewed changes
Copy link
Member

@y0hami y0hami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@y0hami y0hami merged commit df5701c into fomantic:develop Dec 24, 2018
@y0hami y0hami mentioned this pull request Dec 24, 2018
Merged
@lubber-de lubber-de removed the state/awaiting-reviews Pull requests which are waiting for reviews label Dec 25, 2018
@lubber-de lubber-de deleted the fix/elastic_dropdown branch December 25, 2018 18:58
@lubber-de lubber-de modified the milestones: 2.7.x, 2.7.1 Dec 30, 2018
@exoego exoego added type/bug Any issue which is a bug or PR which fixes a bug and removed 🐛 bugfix labels May 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prudho prudho prudho approved these changes

@y0hami y0hami y0hami approved these changes

@ColinFrick ColinFrick Awaiting requested review from ColinFrick

Assignees
No one assigned
Labels
lang/css Anything involving CSS type/bug Any issue which is a bug or PR which fixes a bug
Projects
None yet
Milestone
2.7.1
Development

Successfully merging this pull request may close these issues.
4 participants
@lubber-de @prudho @y0hami @exoego