Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Table][Image] Avatar in table doesn't fit #1510

Closed
crackcomm opened this issue Dec 24, 2014 · 3 comments
Closed

[Table][Image] Avatar in table doesn't fit #1510

crackcomm opened this issue Dec 24, 2014 · 3 comments
Labels
Confirmed Bug
Milestone
1.5.0

Comments

@crackcomm
Copy link

Screenshot

Issue Screenshot

Code
@jlukic jlukic added this to the 1.5.0 milestone Dec 24, 2014
@jlukic
Copy link
Member

jlukic commented Dec 24, 2014

I'll most likely add a solve similar to this after the holidays. max-width can be a bit funny within table elements

.ui.table th .image,
.ui.table th .image img,
.ui.table td .image,
.ui.table td .image img {
  max-width: none;
}

http://jsbin.com/loqovikifu/1/

@crackcomm
Copy link
Author

Thank You for this.

jlukic added a commit that referenced this issue Dec 29, 2014
@jlukic
Fix #1510 image display inside ui table
400949c
@jlukic jlukic closed this as completed Dec 29, 2014
y0hami pushed a commit to fomantic/Fomantic-UI that referenced this issue Nov 19, 2018
@lubber-de
fix(table): images in tables did not display properly
9516519 
This one needs a bit of explanation:
The main cause of this bug was introduced in 2014 by Semantic-Org/Semantic-UI@400949c
It was related to issue Semantic-Org/Semantic-UI#1510, where it seemed to be fixed but the main cause was the `collapsing` class set to the cell column, which causes the width to be reduced to 1px to force the browser to reduce its width until the main occupied content got the minimum width.
So, this PR actually reverts the fix for Semantic-Org/Semantic-UI#1510 and fixes the main cause correctly now.

Closes #227
y0hami pushed a commit to fomantic/Fomantic-UI that referenced this issue Dec 18, 2018
@lubber-de
fix(table): images in tables did not display properly
b949981 
This one needs a bit of explanation:
The main cause of this bug was introduced in 2014 by Semantic-Org/Semantic-UI@400949c
It was related to issue Semantic-Org/Semantic-UI#1510, where it seemed to be fixed but the main cause was the `collapsing` class set to the cell column, which causes the width to be reduced to 1px to force the browser to reduce its width until the main occupied content got the minimum width.
So, this PR actually reverts the fix for Semantic-Org/Semantic-UI#1510 and fixes the main cause correctly now.

Closes #227
y0hami pushed a commit to fomantic/Fomantic-UI that referenced this issue Dec 21, 2018
@lubber-de
fix(table): images in tables did not display properly
981da30 
This one needs a bit of explanation:
The main cause of this bug was introduced in 2014 by Semantic-Org/Semantic-UI@400949c
It was related to issue Semantic-Org/Semantic-UI#1510, where it seemed to be fixed but the main cause was the `collapsing` class set to the cell column, which causes the width to be reduced to 1px to force the browser to reduce its width until the main occupied content got the minimum width.
So, this PR actually reverts the fix for Semantic-Org/Semantic-UI#1510 and fixes the main cause correctly now.

Closes #227
@lubber-de

This comment was marked as spam.

Sign in to view
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Confirmed Bug
Projects
None yet
Milestone
1.5.0
Development

No branches or pull requests
3 participants
@jlukic @crackcomm @lubber-de