Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Table][Image] Image in Table Cell not working #227

Closed
lubber-de opened this issue Oct 29, 2018 · 0 comments
Closed

[Table][Image] Image in Table Cell not working #227

lubber-de opened this issue Oct 29, 2018 · 0 comments
Assignees
@lubber-de
Labels
lang/css Anything involving CSS tag/sui-issue Taken from an existing Issue/PR of SUI type/bug Any issue which is a bug or PR which fixes a bug
Milestone
2.7.0

Comments

@lubber-de
Copy link
Member

lubber-de commented Oct 29, 2018 •
edited
Loading

Bug Report

Original SUI Issue

Semantic-Org/Semantic-UI#5781

image tag not working in table tag.
the bug is here

.ui.table td .image img {
    max-width: none;
}

Testcase

https://jsfiddle.net/vnmgt6y9/6/
@lubber-de lubber-de added type/bug Any issue which is a bug or PR which fixes a bug lang/css Anything involving CSS tag/sui-issue Taken from an existing Issue/PR of SUI labels Oct 29, 2018
@lubber-de lubber-de self-assigned this Nov 16, 2018
@lubber-de lubber-de mentioned this issue Nov 16, 2018
Merged
y0hami pushed a commit that referenced this issue Nov 19, 2018
@lubber-de
fix(table): images in tables did not display properly
9516519 
This one needs a bit of explanation:
The main cause of this bug was introduced in 2014 by Semantic-Org/Semantic-UI@400949c
It was related to issue Semantic-Org/Semantic-UI#1510, where it seemed to be fixed but the main cause was the `collapsing` class set to the cell column, which causes the width to be reduced to 1px to force the browser to reduce its width until the main occupied content got the minimum width.
So, this PR actually reverts the fix for Semantic-Org/Semantic-UI#1510 and fixes the main cause correctly now.

Closes #227
@y0hami y0hami added the tag/next-release/nightly Any issue which has a corresponding PR which has been merged and is available in the nightly build label Nov 28, 2018
@lubber-de lubber-de added this to the 2.7.0 milestone Nov 29, 2018
y0hami pushed a commit that referenced this issue Dec 18, 2018
@lubber-de
fix(table): images in tables did not display properly
b949981 
This one needs a bit of explanation:
The main cause of this bug was introduced in 2014 by Semantic-Org/Semantic-UI@400949c
It was related to issue Semantic-Org/Semantic-UI#1510, where it seemed to be fixed but the main cause was the `collapsing` class set to the cell column, which causes the width to be reduced to 1px to force the browser to reduce its width until the main occupied content got the minimum width.
So, this PR actually reverts the fix for Semantic-Org/Semantic-UI#1510 and fixes the main cause correctly now.

Closes #227
This was referenced Dec 21, 2018
Merged
Merged
@y0hami y0hami closed this as completed in 981da30 Dec 21, 2018
@lubber-de lubber-de removed the tag/next-release/nightly Any issue which has a corresponding PR which has been merged and is available in the nightly build label Dec 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lubber-de lubber-de

Labels
lang/css Anything involving CSS tag/sui-issue Taken from an existing Issue/PR of SUI type/bug Any issue which is a bug or PR which fixes a bug
Projects
None yet
Milestone
2.7.0
Development

No branches or pull requests
2 participants
@y0hami @lubber-de