Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: enabled field doesn't seem to take effect. #2

Closed
4 tasks done
amedoeyes opened this issue Nov 6, 2024 · 4 comments · Fixed by #4
Closed
4 tasks done

bug: enabled field doesn't seem to take effect. #2

amedoeyes opened this issue Nov 6, 2024 · 4 comments · Fixed by #4
Labels
bug Something isn't working

Comments

@amedoeyes
Copy link

Did you check docs and existing issues?

  • I have read all the snacks.nvim docs
  • I have updated the plugin to the latest version before submitting this issue
  • I have searched the existing issues of snacks.nvim
  • I have searched the existing issues of plugins related to this issue

Neovim version (nvim -v)

v0.10.2

Operating system/version

Linux 6.11.6.arch1-1

Describe the bug

Setting the enabled field to false doesn't seem to do anything. Here I'm trying to disable notifier and statuscolumn but they still function.

image

When I print Snacks.config:

image

Steps To Reproduce

  1. Set the enabled field of notifier to false
  2. Display a notification with vim.notify
  3. notifier will display the notification

Expected Behavior

Disabled features should be disabled.

Repro

vim.env.LAZY_STDPATH = ".repro"
load(vim.fn.system("curl -s https://raw.githubusercontent.com/folke/lazy.nvim/main/bootstrap.lua"))()

require("lazy.minit").repro({
	spec = {
		{
			"folke/snacks.nvim",
			opts = {
				statuscolumn = { enabled = false },
				notifier = { enabled = false },
			},
		},
	},
})

for i = 1, 10 do
	vim.defer_fn(function()
		vim.notify("Hello " .. i, "info", { id = "test" })
	end, i * 500)
end
@iguanacucumber
Copy link

this should be reopened as i'm still having this issue

folke pushed a commit that referenced this issue Nov 8, 2024
🤖 I have created a release *beep* *boop*
---


## [1.1.0](v1.0.0...v1.1.0)
(2024-11-08)


### Features

* **bufdelete:** optional filter and shortcuts to delete `all` and
`other` buffers. Closes
[#11](#11)
([71a2346](71a2346))
* **debug:** simple log function to quickly log something to a debug.log
file
([fc2a8e7](fc2a8e7))
* **docs:** docs for highlight groups
([#13](#13))
([964cd6a](964cd6a))
* **gitbrowse:** choose to open repo, branch or file. Closes
[#10](#10). Closes
[#17](#17)
([92da87c](92da87c))
* **notifier:** added history to notifier. Closes
[#14](#14)
([65d8c8f](65d8c8f))
* **notifier:** added option to show notifs top-down or bottom-up.
Closes [#9](#9)
([080e0d4](080e0d4))
* **notifier:** allow overriding hl groups per notification
([8bcb2bc](8bcb2bc))
* **notifier:** allow setting dynamic options
([36e9f45](36e9f45))
* **win:** added default hl groups for windows
([8c0f10b](8c0f10b))
* **win:** allow setting `ft` just for highlighting without actually
changing the `filetype`
([cad236f](cad236f))
* **win:** disable winblend when colorscheme is transparent. Fixes
[#26](#26)
([12077bc](12077bc))
* **win:** equalize splits
([e982aab](e982aab))
* **win:** util methods to handle buffer text
([d3efb92](d3efb92))
* **win:** win:focus()
([476fb56](476fb56))
* **words:** `jump` optionally shows notification with reference count
([#23](#23))
([6a3f865](6a3f865))
* **words:** configurable mode to show references. Defaults to n, i, c.
Closes [#18](#18)
([d079fbf](d079fbf))


### Bug Fixes

* **config:** deepcopy config where needed
([6c76f91](6c76f91))
* **config:** fix reading config during setup. Fixes
[#2](#2)
([0d91a4e](0d91a4e))
* **notifier:** re-apply winhl since level might have changed with a
replace
([b8cc93e](b8cc93e))
* **notifier:** set default conceallevel=2
([662795c](662795c))
* **notifier:** try to keep layout when replacing notifs
([9bdb24e](9bdb24e))
* **terminal:** dont overwrite user opts
([0b08d28](0b08d28))
* **terminal:** user options
([334895c](334895c))
* **win:** better winfixheight and winfixwidth for splits
([8be14c6](8be14c6))
* **win:** disable sidescroloff in minimal style
([107d10b](107d10b))
* **win:** dont center float when `relative="cursor"`
([4991e34](4991e34))
* **win:** properly resolve user styles as last
([cc5ee19](cc5ee19))
* **win:** set border to none for backdrop windows
([#19](#19))
([f5602e6](f5602e6))
* **win:** simpler way to add buffer padding
([f59237f](f59237f))
* **win:** update win/buf opts when needed
([5fd9c42](5fd9c42))
* **words:** disable notify_jump by default
([9576081](9576081))


### Performance Improvements

* **notifier:** index queue by id
([5df4394](5df4394))
* **notifier:** optimize layout code
([8512896](8512896))
* **notifier:** skip processing queue when free space is smaller than
min height
([08190a5](08190a5))
* **win:** skip events when setting buf/win options. Trigger FileType on
BufEnter only if needed
([61496a3](61496a3))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@roguesherlock
Copy link

yeah I am also facing similar issue even with the latest release

@folke
Copy link
Owner

folke commented Nov 9, 2024

You probably wanted to disable notifier?
The problem was that noice would still use snacks, even when disabled.
Just fixed that in both snacks (and lazyvim if you use that)

@roguesherlock
Copy link

yes. Thank you so much @folke! Love all your plugins!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants