Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: bigfile snack is dependent on notifier snack? #5

Closed
4 tasks done
andrewferrier opened this issue Nov 6, 2024 · 3 comments
Closed
4 tasks done

bug: bigfile snack is dependent on notifier snack? #5

andrewferrier opened this issue Nov 6, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@andrewferrier
Copy link

Did you check docs and existing issues?

  • I have read all the snacks.nvim docs
  • I have updated the plugin to the latest version before submitting this issue
  • I have searched the existing issues of snacks.nvim
  • I have searched the existing issues of plugins related to this issue

Neovim version (nvim -v)

NVIM v0.11.0-dev-1103+g04274a4173

Operating system/version

Arch Linux

Describe the bug

Thanks for snacks, looks like a great selection of tools, just getting used to it!

I assumed (perhaps incorrectly) that you intended for the snacks to be independent, but it looks like the bigfile snack is dependent on the notifier snack. If I load a bigfile, I get a notification that's come from the notifier snack, even if I don't want to use notifier. Perhaps bigfile should be using vim.notify() instead and allow notifier to handle it only if enabled?

Steps To Reproduce

  1. Enable bigfile, disable notifier snack in config
  2. Load a big file
  3. Observe notifier notification

Expected Behavior

Conventional notification in cmdline

Repro

return {
    "folke/snacks.nvim",
    lazy = false,
    opts = {
        bigfile = { enabled = true }
        notifier = { enabled = false },
    }
}
@andrewferrier andrewferrier added the bug Something isn't working label Nov 6, 2024
@andrewferrier
Copy link
Author

Huh, just updated and this has gone away. I think this might have been fixed by your fix for #2...

@folke
Copy link
Owner

folke commented Nov 6, 2024

Yep, indeed. disabling actually didnt work :)

@folke folke closed this as completed Nov 6, 2024
@andrewferrier
Copy link
Author

Thanks. Sorry for the false alarm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants