feat(gitbrowse): open file in gitbrowse in corresponding remote
#17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcinjahn
reviewed
Nov 8, 2024
Comment on lines
+74
to
+77
| elseif branch == "main" then | ||
| url = ("%s/tree/main/"):format(url) | ||
| elseif branch == "master" then | ||
| url = ("%s/tree/master/"):format(url) |
There was a problem hiding this comment.
Why do main and master need a special treatment?
There was a problem hiding this comment.
The url is different? We're manually constructing it to append the filename at the end.
There was a problem hiding this comment.
He means that this:
if url:find("github") and branch and branch ~= "master" and branch ~= "main" then
url = ("%s/tree/%s/"):format(url, branch)
elseif branch == "main" then
url = ("%s/tree/main/"):format(url)
elseif branch == "master" then
url = ("%s/tree/master/"):format(url)Can be replaced by this:
if url:find("github") and branch then
url = ("%s/tree/%s/"):format(url, branch)Either way, this stuff currently only works for Github. I'll se if I can make it a bit more general to work with others as well.
There was a problem hiding this comment.
Oh I see. Thanks for clarifying the logic. Much appreciate it.
There was a problem hiding this comment.
@folke Should I close this maybe, since you're going to come up with a better implementation? Or just close it yourself. I really don't mind.
|
Just pushed an update:
|
folke
pushed a commit
that referenced
this pull request
Nov 8, 2024
🤖 I have created a release *beep* *boop* --- ## [1.1.0](v1.0.0...v1.1.0) (2024-11-08) ### Features * **bufdelete:** optional filter and shortcuts to delete `all` and `other` buffers. Closes [#11](#11) ([71a2346](71a2346)) * **debug:** simple log function to quickly log something to a debug.log file ([fc2a8e7](fc2a8e7)) * **docs:** docs for highlight groups ([#13](#13)) ([964cd6a](964cd6a)) * **gitbrowse:** choose to open repo, branch or file. Closes [#10](#10). Closes [#17](#17) ([92da87c](92da87c)) * **notifier:** added history to notifier. Closes [#14](#14) ([65d8c8f](65d8c8f)) * **notifier:** added option to show notifs top-down or bottom-up. Closes [#9](#9) ([080e0d4](080e0d4)) * **notifier:** allow overriding hl groups per notification ([8bcb2bc](8bcb2bc)) * **notifier:** allow setting dynamic options ([36e9f45](36e9f45)) * **win:** added default hl groups for windows ([8c0f10b](8c0f10b)) * **win:** allow setting `ft` just for highlighting without actually changing the `filetype` ([cad236f](cad236f)) * **win:** disable winblend when colorscheme is transparent. Fixes [#26](#26) ([12077bc](12077bc)) * **win:** equalize splits ([e982aab](e982aab)) * **win:** util methods to handle buffer text ([d3efb92](d3efb92)) * **win:** win:focus() ([476fb56](476fb56)) * **words:** `jump` optionally shows notification with reference count ([#23](#23)) ([6a3f865](6a3f865)) * **words:** configurable mode to show references. Defaults to n, i, c. Closes [#18](#18) ([d079fbf](d079fbf)) ### Bug Fixes * **config:** deepcopy config where needed ([6c76f91](6c76f91)) * **config:** fix reading config during setup. Fixes [#2](#2) ([0d91a4e](0d91a4e)) * **notifier:** re-apply winhl since level might have changed with a replace ([b8cc93e](b8cc93e)) * **notifier:** set default conceallevel=2 ([662795c](662795c)) * **notifier:** try to keep layout when replacing notifs ([9bdb24e](9bdb24e)) * **terminal:** dont overwrite user opts ([0b08d28](0b08d28)) * **terminal:** user options ([334895c](334895c)) * **win:** better winfixheight and winfixwidth for splits ([8be14c6](8be14c6)) * **win:** disable sidescroloff in minimal style ([107d10b](107d10b)) * **win:** dont center float when `relative="cursor"` ([4991e34](4991e34)) * **win:** properly resolve user styles as last ([cc5ee19](cc5ee19)) * **win:** set border to none for backdrop windows ([#19](#19)) ([f5602e6](f5602e6)) * **win:** simpler way to add buffer padding ([f59237f](f59237f)) * **win:** update win/buf opts when needed ([5fd9c42](5fd9c42)) * **words:** disable notify_jump by default ([9576081](9576081)) ### Performance Improvements * **notifier:** index queue by id ([5df4394](5df4394)) * **notifier:** optimize layout code ([8512896](8512896)) * **notifier:** skip processing queue when free space is smaller than min height ([08190a5](08190a5)) * **win:** skip events when setting buf/win options. Trigger FileType on BufEnter only if needed ([61496a3](61496a3)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
gitbrowseopens the file in Github instead of just the repo. I closed #15 because when you were in a nested directory inside the local git repo it didn't open the file correctly. This rectifies that behavior. I hope I didn't miss anything else.Related Issue(s)
Closes #10.
Screenshots