Use fmt::formatter specialization for std::reference_wrapper to avoid undefined behavior #4164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitaut
reviewed
Sep 19, 2024
include/fmt/std.h
Outdated
| enable_if_t<is_formattable<remove_cvref_t<T>, Char>::value>> | ||
| : formatter<remove_cvref_t<T>, Char> { | ||
| template <typename FormatContext> | ||
| auto format(const std::reference_wrapper<T>& ref, FormatContext& ctx) const |
There was a problem hiding this comment.
Let's pass std::reference_wrapper by value since it should be cheap to copy.
… undefined behavior Signed-off-by: Vladislav Shchapov <[email protected]>
phprus
force-pushed
the
std-reference_wrapper-ub-1
branch
from
0d8da58 to
5f37d3b
Compare
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix UB: #4163 (comment)