Docs for chrono type S decimal point locale does not match code

[tearfur]

The decimal point character for the chrono type 'S' seems to be locale-independent, contrary to what the docs says. Reproduced at https://godbolt.org/z/TKxcq5hf6.

From the docs:

The character for the decimal point is localized according to the locale. The modified command %OS produces the locale's alternative representation.

Relevant code (I think):

fmt/include/fmt/chrono.h

Line 1148 in 3135421

*out++ = '.';

fmt/include/fmt/chrono.h

Line 1153 in 3135421

*out++ = '.';

fmt/include/fmt/chrono.h

Line 1195 in 3135421

fmt::format_to(std::back_inserter(buf), FMT_STRING("{:.{}f}"),

[tearfur]

I wonder if I missed something, std::format behaves the same way too... https://godbolt.org/z/Ynd7P4ETM

[smarthyen]

I just ran into the same Issue:
https://godbolt.org/z/ansPYErn8
And came to the same conclusion, looking at the source.

Although I'm not sure whether "{:%S}" and "{:L%S}" should behave the same.

[vitaut]

%S is locale-independent by default. We should update the docs.

[tearfur]

Relevant material: https://wg21.link/P2372R3

[vitaut]

Fixed in 589898e. Thanks for reporting.