Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to gcc-13 for C++23 tests #4155

Merged
merged 4 commits into from
Sep 5, 2024
Merged

Switch to gcc-13 for C++23 tests #4155

merged 4 commits into from
Sep 5, 2024

Conversation

phprus
Copy link
Contributor

@phprus phprus commented Sep 4, 2024

But there are some build errors (potential null pointer dereference [-Werror=null-dereference]):

https://github.com/phprus/fmt/actions/runs/10708260895/job/29690153702

@vitaut

@vitaut
Copy link
Contributor

vitaut commented Sep 4, 2024

Do you have an idea what pointer this warning refers to? __location?

/usr/include/c++/13/bits/stl_construct.h:97:14: error: potential null pointer dereference [-Werror=null-dereference]
   97 |     { return ::new((void*)__location) _Tp(std::forward<_Args>(__args)...); }
      |              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

@phprus
Copy link
Contributor Author

phprus commented Sep 5, 2024

This is gcc bug: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108860

@phprus phprus marked this pull request as draft September 5, 2024 10:19
@phprus
Copy link
Contributor Author

phprus commented Sep 5, 2024

@phprus phprus marked this pull request as ready for review September 5, 2024 11:52
@phprus
Copy link
Contributor Author

phprus commented Sep 5, 2024

@vitaut
All errors is fixed.

@vitaut vitaut merged commit 5bf577c into fmtlib:master Sep 5, 2024
45 checks passed
@vitaut
Copy link
Contributor

vitaut commented Sep 5, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants