chore: migrate to tsdown by lishaduck · Pull Request #1129 · flint-fyi/flint

lishaduck · 2025-12-26T01:26:05Z

PR Checklist

Addresses an existing open issue: fixes 🛠 Tooling: move to tsdown #1123
That issue was marked as status: accepting prs
Steps in CONTRIBUTING.md were taken

Overview

Should still probably get split up...

changeset-bot · 2025-12-26T01:26:09Z

🦋 Changeset detected

Latest commit: 58e07df

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 24 packages

Name	Type
@flint.fyi/plugin-performance	Patch
@flint.fyi/plugin-spelling	Patch
@flint.fyi/plugin-browser	Patch
@flint.fyi/plugin-astro	Patch
@flint.fyi/plugin-flint	Patch
@flint.fyi/plugin-react	Patch
@flint.fyi/plugin-solid	Patch
@flint.fyi/comparisons	Patch
@flint.fyi/plugin-next	Patch
@flint.fyi/plugin-node	Patch
@flint.fyi/plugin-nuxt	Patch
@flint.fyi/rule-tester	Patch
@flint.fyi/plugin-jsx	Patch
@flint.fyi/ts-patch	Patch
flint	Patch
@flint.fyi/utils	Patch
@flint.fyi/core	Patch
@flint.fyi/json	Patch
@flint.fyi/site	Patch
@flint.fyi/text	Patch
@flint.fyi/yaml	Patch
@flint.fyi/cli	Patch
@flint.fyi/md	Patch
@flint.fyi/ts	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel · 2025-12-26T01:26:10Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Review	Updated (UTC)
flint	Ready	Preview, Comment	Jan 3, 2026 7:20pm

github-actions · 2025-12-26T01:26:17Z

👋 Hi @lishaduck, thanks for the pull request! A scan flagged a concern with it. Could you please take a look?

[pr-task-completion] This PR's body is missing [x] checks on the following tasks from the PR template.

That issue was marked as status: accepting prs

Repositories often provide a set of tasks that pull request authors are expected to complete. Those tasks should be marked as completed with a [x] in the pull request description. Please complete those tasks and mark the checks as [x] completed.

🗺️ This message was posted automatically by OctoGuide: a bot for GitHub repository best practices.

lishaduck · 2025-12-26T01:57:13Z

If there is a backing issue, add a 'fixes #...' link to the pull request body

~~I have?~~ It seems GH is buggy as usual, and has taken to ignoring 'fixes' sometimes.

Well, it's fixed now (hehe), but #1151 is really really broken instead 😬

packages/flint/bin/index.js

## PR Checklist - [x] Addresses an existing open issue: fixes #1139 - [x] That issue was marked as [`status: accepting prs`](https://github.com/JoshuaKGoldberg/flint/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22) - [x] Steps in [CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/flint/blob/main/.github/CONTRIBUTING.md) were taken ## Overview  Extracted from #1129 🔥

packages/comparisons/tsdown.config.ts

auvred · 2025-12-31T08:13:54Z

I looked into tools to automate references generation because this is pretty unwieldy, but it looks like the only tool that does it the way we needed it is nx, and that seems a bit overkill.

Internal lint rule could help with that! Especially with an autofixer

lishaduck · 2025-12-31T16:04:32Z

Should I make a changeset? This isn't forward-facing, but we should probably ensure we republish all of the packages.

JoshuaKGoldberg · 2025-12-31T22:00:44Z

Yeah, just to be safe let's do that.

JoshuaKGoldberg · 2025-12-31T22:02:15Z

packages/cli/tsconfig.json

 	"compilerOptions": {
-		"outDir": "lib",
-		"rootDir": "src"
+		"tsBuildInfoFile": "node_modules/.cache/tsbuild/info.json",


[Question] Are these necessary? Why not go with the default?

Yes, we require setting them to disambiguate between , .test, & .src. Putting them in node_modules/.cache/tsbuild was a matter of preference (to prevent #1129 (comment) and to collocate with the tsbuild output). We could totally put them in as tsconfig.tsbuildinfo, tsconfig.src.tsbuildinfo, tsconfig.test.tsbuildinfo, tsconfig.bin.tsbuildinfo, but that gets noisy quickly.

Hmm. I was a little uneasy with the @flint.fyi/source in package.json, and now this is a second unusual (to me?) configuration point I haven't seen used elsewhere. What is it about our setups that's forcing these unusual config options uses?

I was a little uneasy with the @flint.fyi/source in package.json

That's fair, but I'd like to note that offical TS team recommends it as the way to use type-stripping. It's not so much unusual, it's that most projects of our scale haven't migrated to erasableSyntaxOnly, so it's only smaller projects like tinyglobby that use it (irrc tinyglobby uses it, don't quote me, I didn't double-check).

(to me?) configuration point I haven't seen used elsewhere

Really? tbh I'd never seen a project (before Flint) that didn't customize tsbuildinfo when using incremental.

What is it about our setups that's forcing these unusual config options uses?

Being relatively non-trivial

Being a monorepo

Adopting newer features most non-trivial monorepos haven't migrated to yet.

Again, I don't think it's so much that options are unusual, it's that the projects you use and the projects I use are generally of different scales.

I was curious, so I ran a quick sourcegraph search of tsBuildInfoFile, which returns >10k results for tsconfig.json, so, again, I don't think it's very unusual to set it, just that it might be unusual in your circles.

EDIT: typescript-eslint uses it :) (not much, surprisingly. I'm curious how they do it now...) https://github.com/search?q=repo%3Atypescript-eslint%2Ftypescript-eslint%20tsBuildInfoFile&type=code

EDIT: typescript-eslint uses it :) (not much, surprisingly. I'm curious how they do it now...) https://github.com/search?q=repo%3Atypescript-eslint%2Ftypescript-eslint%20tsBuildInfoFile&type=code

I took a closer look to see how typescript-eslint was using it, given I assume you'd be more comfortable with that approach. It looks like in typescript-eslint, y'all are doing the same thing I'm doing, but you just do it in the more centralized (and thus implicit) manner.
I don't totally love the approach y'all took to centralize it (I don't love how crowded it makes the root, for one), but now that I see how y'all did it, I think I could adapt it pretty nicely here as well.

I assume you'd like that, I'd like that too, I don't know if we want to make it block getting this in. On one hand, auvred said he'd prefer this to land before #1179, but at the same time, a followup would be equally conflicty (though less so than #1201).
I say that because I'm going to try to resist working on Flint tomorrow (gotta finish polishing my WashU app & get back to the MIT app), but we'll see. I don't see myself resisting the lure of code for more than a day though, so 🫡

G'night! Happy new years! (3 more minutes for me 🎉)

I assume you'd like that

Heh, I wasn't on point for setting up tseslint's tooling. That was JamesHenry. I just ramp up to review the PRs once in a while and maybe try to tweak things when they break.

This whole area isn't something I'm very ramped up on. And IMO none of this is blocking - we can always change it later!

Proposal: how about we...

Wait today since you're working on your future (whoo! 🎓)

See if @auvred has preferences

Go with whatever you two prefer tomorrow?

I'm personally happy as long as it all works. From my perspective, it's a win-win:

If we do it a way I'm accustomed to: I'm comfortable

If we do it some new way: I learn a new thing and get to try it out for reference later

I'm personally happy as long as it all works.

+1! This is a tooling setup, we can always change it at any moment if we find something we don't like. Let's merge it?

!

@lishaduck whenever you feel comfortable, all you!

Sounds good to me!

(I am aware that there are conflicts. Feel free to fix them yourself if it's blocking something, or else I'll get it to tomorrow)

Resolved conflicts. 👍🏻

No need for this anymore 🧹

lishaduck · 2026-01-02T23:03:20Z

I tried the tsdown 0.19 beta, but the exports generation still isn't quite where we want it. Put up rolldown/tsdown#685 to fix that.

I think we leave it for a followup like #1129 (comment).

EDIT: Filed #1251

JoshuaKGoldberg

🚢

lishaduck · 2026-01-03T19:20:23Z

Self merging once CI passed given everyone approves and this is particularly conflict-prone.

## PR Checklist - [x] Addresses an existing open issue: fixes #1152 - [x] That issue was marked as [`status: accepting prs`](https://github.com/JoshuaKGoldberg/flint/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22) - [x] Steps in [CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/flint/blob/main/.github/CONTRIBUTING.md) were taken ## Overview  Relands #1174. Marking as draft, despite being ready for review, to prevent accidental remerges before #1129. 🔥 --------- Co-authored-by: Josh Goldberg <git@joshuakgoldberg.com>

## PR Checklist - [x] Addresses an existing open issue: fixes #1248 - [x] That issue was marked as [`status: accepting prs`](https://github.com/flint-fyi/flint/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22) - [x] Steps in [CONTRIBUTING.md](https://github.com/flint-fyi/flint/blob/main/.github/CONTRIBUTING.md) were taken ## Overview  Fixes broken merge of #1129 & #1201

lishaduck force-pushed the transition branch from aec299e to 839cb01 Compare December 26, 2025 01:34

lishaduck force-pushed the tsdown branch from 02d38bf to ead5ba1 Compare December 26, 2025 01:36

vercel bot deployed to Preview December 26, 2025 01:37 View deployment

lishaduck force-pushed the tsdown branch from ead5ba1 to f07c8ff Compare December 26, 2025 01:39

lishaduck force-pushed the transition branch from 839cb01 to 47557ae Compare December 26, 2025 01:39

vercel bot deployed to Preview December 26, 2025 01:39 View deployment

vercel bot deployed to Preview December 26, 2025 01:52 View deployment

lishaduck force-pushed the tsdown branch from cbb3353 to 9854388 Compare December 26, 2025 01:52

vercel bot deployed to Preview December 26, 2025 01:53 View deployment

vercel bot deployed to Preview December 26, 2025 02:17 View deployment

lishaduck commented Dec 26, 2025

View reviewed changes

packages/flint/bin/index.js Outdated Show resolved Hide resolved

lishaduck commented Dec 26, 2025

View reviewed changes

packages/flint/bin/index.js Show resolved Hide resolved

lishaduck linked an issue Dec 27, 2025 that may be closed by this pull request

🛠 Tooling: move to tsdown #1123

Closed

2 tasks

lishaduck mentioned this pull request Dec 27, 2025

chore: correct package.json repository urls to Git locators #1140

Merged

3 tasks

Base automatically changed from transition to main December 27, 2025 19:27

lishaduck force-pushed the tsdown branch from f992cfa to 8dfa9c8 Compare December 27, 2025 20:45

vercel bot had a problem deploying to Preview December 27, 2025 20:45 Failure

lishaduck force-pushed the tsdown branch from 8dfa9c8 to a80aa77 Compare December 27, 2025 20:55

vercel bot deployed to Preview December 27, 2025 20:56 View deployment

lishaduck added 2 commits December 27, 2025 15:03

refactor: tsdown

67639f1

chore: attw

bbabb56

lishaduck force-pushed the tsdown branch from a80aa77 to bbabb56 Compare December 27, 2025 21:03

vercel bot deployed to Preview December 27, 2025 21:04 View deployment

lishaduck mentioned this pull request Dec 28, 2025

🛠 Tooling: switch to verbatimModuleSyntax & allowImportingTsExtensions & erasableSyntaxOnly #1152

Closed

2 tasks

feat: extract out ts patching package

a024277

auvred reviewed Dec 31, 2025

View reviewed changes

packages/comparisons/tsdown.config.ts Show resolved Hide resolved

chore: attw only in ci

e453268

vercel bot deployed to Preview December 31, 2025 16:05 View deployment

JoshuaKGoldberg reviewed Dec 31, 2025

View reviewed changes

chore: add changeset

940face

vercel bot deployed to Preview January 1, 2026 05:16 View deployment

chore: remove root lib from prettier

6d71229

No need for this anymore 🧹

vercel bot deployed to Preview January 1, 2026 15:54 View deployment

Merge branch 'main' into tsdown

bf64e6d

vercel bot deployed to Preview January 2, 2026 03:56 View deployment

Merge branch 'main' into tsdown

a80eda5

vercel bot deployed to Preview January 2, 2026 17:53 View deployment

JoshuaKGoldberg approved these changes Jan 3, 2026

View reviewed changes

Merge branch 'main' into tsdown

58e07df

vercel bot deployed to Preview January 3, 2026 19:20 View deployment

lishaduck enabled auto-merge (squash) January 3, 2026 19:20

lishaduck merged commit 602c75c into main Jan 3, 2026
7 checks passed

lishaduck deleted the tsdown branch January 3, 2026 19:22

lishaduck mentioned this pull request Jan 3, 2026

fix: files globs #1249

Merged

3 tasks

This was referenced Jan 3, 2026

chore: autogenerate exports #1250

Merged

🛠 Tooling: autogenerate exports #1251

Closed

🛠 Tooling: autogenerate references #1252

Open

ci: use Vitest's --changed on non-main branches #1409

Merged

Conversation

lishaduck commented Dec 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Checklist

Overview

Uh oh!

changeset-bot bot commented Dec 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

vercel bot commented Dec 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Dec 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lishaduck commented Dec 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

auvred commented Dec 31, 2025

Uh oh!

lishaduck commented Dec 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JoshuaKGoldberg commented Dec 31, 2025

Uh oh!

JoshuaKGoldberg Dec 31, 2025

Choose a reason for hiding this comment

Uh oh!

lishaduck Dec 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JoshuaKGoldberg Dec 31, 2025

Choose a reason for hiding this comment

Uh oh!

lishaduck Dec 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lishaduck Jan 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JoshuaKGoldberg Jan 1, 2026

Choose a reason for hiding this comment

Uh oh!

auvred Jan 1, 2026

Choose a reason for hiding this comment

Uh oh!

JoshuaKGoldberg Jan 1, 2026

Choose a reason for hiding this comment

Uh oh!

lishaduck Jan 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lishaduck Jan 2, 2026

Choose a reason for hiding this comment

Uh oh!

lishaduck commented Jan 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

Uh oh!

lishaduck commented Jan 3, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

lishaduck commented Dec 26, 2025 •

edited

Loading

changeset-bot bot commented Dec 26, 2025 •

edited

Loading

vercel bot commented Dec 26, 2025 •

edited

Loading

github-actions bot commented Dec 26, 2025 •

edited

Loading

lishaduck commented Dec 26, 2025 •

edited

Loading

lishaduck commented Dec 31, 2025 •

edited

Loading

lishaduck Dec 31, 2025 •

edited

Loading

lishaduck Dec 31, 2025 •

edited

Loading

lishaduck Jan 1, 2026 •

edited

Loading

lishaduck Jan 1, 2026 •

edited

Loading

lishaduck commented Jan 2, 2026 •

edited

Loading