ci: use Vitest's --changed on non-main branches by JoshuaKGoldberg · Pull Request #1409 · flint-fyi/flint

JoshuaKGoldberg · 2026-01-09T14:24:47Z

PR Checklist

Addresses an existing open issue: fixes 🛠 Tooling: Only run "impacted by" tests for PRs in CI (--changed) #1332
That issue was marked as status: accepting prs
Steps in CONTRIBUTING.md were taken

Overview

Uses the implementation proposed by @barrymichaeldoyle in #1332 (comment).

Note that all tests are re-run in this PR because it changes configs from main. But future PRs should ™️ nicely re-run only impacted ones.

Co-authored-by: @barrymichaeldoyle

❤️‍🔥

changeset-bot · 2026-01-09T14:24:52Z

⚠️ No Changeset found

Latest commit: f69be29

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel · 2026-01-09T14:24:52Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Review	Updated (UTC)
flint	Canceled		Jan 12, 2026 11:44pm

JoshuaKGoldberg · 2026-01-09T15:01:47Z

By the way, in order to request review from @flint-fyi/maintenance, I added the team under https://github.com/flint-fyi/flint/settings/access. And then started removing individuals. @barrymichaeldoyle informed me that gives people a kind of scary-looking "you were removed" email. So, I'll wait to keep doing that until people see this message. 😂 sorry if I alarmed you!

auvred · 2026-01-09T17:06:42Z

.github/workflows/ci.yaml

+          path: |
+            .pnpm-store
+            node_modules/.vitest
+      - run: pnpm run build # ensures TS build output for correct test imports


I wonder if it's worth running only pnpm tsc -b here? As far as I understand, for Vitest tests we don't really need .js outputs, only .d.ts, right? Also, skipping tsdown build here would skip the expensive ATTW check.

cc @lishaduck

Yup, that's correct 👍🏻

OH! This just clicked for me. @barrymichaeldoyle I think you might have tried to tell me this when we paired 😂 - sorry if I steamrolled past you.

I had brain lapsed / forgotten that the current Vitest setup goes straight to .ts source. Without that knowledge, it would make sense that pnpm build is needed to get .js outputs. But with it, yeah, tsc -b for .d.ts files makes sense.

Ok, right I forgot about vitest-dev/vitest#9353.
I couldn't get ts-patch to work in #1129 without using NODE_OPTIONS. I'll just use it I guess 🤷🏻‍♂️

JoshuaKGoldberg · 2026-01-09T20:40:55Z

Run pnpm tsc -b
Error: packages/flint/src/index.ts(4,29): error TS2307: Cannot find module '@flint.fyi/package-json' or its corresponding type declarations.
Error: Process completed with exit code 2.

☹️ I don't know why this is happening...

lishaduck · 2026-01-11T02:39:25Z

Ok, so I did fix references. The failure now is that Vitest's setupFiles doesn't respect the resolve.conditions we've set, so it's looking for the .js file which isn't built. Filed vitest-dev/vitest#9429.

That's why we used pnpm build originally: while the tests don't require the sources to be built, they do require ts-patch to be built (so it is still helpful for iterating locally, but you still need an initial build for a clean clone like in CI)

JoshuaKGoldberg · 2026-01-12T23:36:23Z

Lovely. Well, if that gets slow over time, we can always look into optimizing later. Thanks! This is very helpful. And it's cool to see issues filed upstream too. 🚀

.github/workflows/ci.yaml

JoshuaKGoldberg · 2026-01-13T00:10:54Z

@all-contributors please add @barrymichaeldoyle for infra.

🤖 Beep boop! This comment was added automatically by all-contributors-auto-action.
Not all contributions can be detected from Git & GitHub alone. Please comment any missing contribution types this bot missed.
...and of course, thank you for contributing! 💙

allcontributors · 2026-01-13T00:11:04Z

@JoshuaKGoldberg

I've put up a pull request to add @barrymichaeldoyle! 🎉

@barrymichaeldoyle

Adds @barrymichaeldoyle as a contributor for infra. This was requested by JoshuaKGoldberg [in this comment](#1409 (comment)) --------- Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>

JoshuaKGoldberg added 3 commits January 9, 2026 09:22

ci: use Vitest's --changed on non-main branches

b8ba335

cache v5

03458ca

sort

76109b2

JoshuaKGoldberg added 2 commits January 9, 2026 09:26

no --reporter dot

fa57a80

test commit

ba02e88

vercel bot deployed to Preview January 9, 2026 14:28 View deployment

add per-package test scripts

5144877

vercel bot deployed to Preview January 9, 2026 14:31 View deployment

JoshuaKGoldberg marked this pull request as draft January 9, 2026 14:32

update vitest.config.ts path relativity

5b91a03

vercel bot deployed to Preview January 9, 2026 14:34 View deployment

--project specifiers

d0985f8

barrymichaeldoyle approved these changes Jan 9, 2026

View reviewed changes

vercel bot deployed to Preview January 9, 2026 14:55 View deployment

Move test change to ts util

a65d07c

vercel bot deployed to Preview January 9, 2026 14:58 View deployment

JoshuaKGoldberg marked this pull request as ready for review January 9, 2026 14:58

JoshuaKGoldberg requested a review from a team January 9, 2026 15:01

auvred reviewed Jan 9, 2026

View reviewed changes

JoshuaKGoldberg added 2 commits January 9, 2026 15:11

tsc -b, not pnpm build

43c38fd

Merge branch 'main' into ci-vitest-changed

964d2f1

vercel bot deployed to Preview January 9, 2026 20:13 View deployment

Add missing tsconfig.json reference

14ddefd

vercel bot deployed to Preview January 9, 2026 20:15 View deployment

Remove extra tsconfig.json reference

a647a01

vercel bot deployed to Preview January 9, 2026 20:18 View deployment

vercel bot deployed to Preview January 10, 2026 15:38 View deployment

fix: refs

00d7ac1

lishaduck force-pushed the ci-vitest-changed branch from 60ba72d to 00d7ac1 Compare January 10, 2026 17:15

vercel bot deployed to Preview January 10, 2026 17:17 View deployment

ci: build -W ts-patch

71e4365

vercel bot deployed to Preview January 11, 2026 02:45 View deployment

ci: don't build astro in flint job

a4f2f28

vercel bot deployed to Preview January 11, 2026 02:54 View deployment

ci: canonicalize build setup between eslint/flint

f1bf582

vercel bot deployed to Preview January 11, 2026 02:56 View deployment

JoshuaKGoldberg added 2 commits January 12, 2026 18:37

Merge branch 'main' into ci-vitest-changed

58e86df

Remove // test

a895c1e

lishaduck requested changes Jan 12, 2026

View reviewed changes

.github/workflows/ci.yaml Outdated Show resolved Hide resolved

vercel bot deployed to Preview January 12, 2026 23:40 View deployment

JoshuaKGoldberg added 2 commits January 12, 2026 18:41

.vite, not .vitest

9169f2a

in command name too

f69be29

JoshuaKGoldberg requested a review from lishaduck January 12, 2026 23:41

vercel bot deployed to Preview January 12, 2026 23:44 View deployment

lishaduck approved these changes Jan 13, 2026

View reviewed changes

JoshuaKGoldberg merged commit e5d28b4 into main Jan 13, 2026
9 checks passed

JoshuaKGoldberg deleted the ci-vitest-changed branch January 13, 2026 00:10

allcontributors bot mentioned this pull request Jan 13, 2026

docs: add barrymichaeldoyle as a contributor for infra #1518

Merged

This was referenced Jan 14, 2026

🛠 Tooling: Only run "impacted by" tests for PRs in CI (--changed) #1332

Closed

📌 Meta: Implementing existing rules #354

Open

🛠 Tooling: Investigate build caches, at least for site? #1781

Open

Conversation

JoshuaKGoldberg commented Jan 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Checklist

Overview

Uh oh!

changeset-bot bot commented Jan 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

vercel bot commented Jan 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JoshuaKGoldberg commented Jan 9, 2026

Uh oh!

auvred Jan 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lishaduck Jan 9, 2026

Choose a reason for hiding this comment

Uh oh!

JoshuaKGoldberg Jan 9, 2026

Choose a reason for hiding this comment

Uh oh!

lishaduck Jan 10, 2026

Choose a reason for hiding this comment

Uh oh!

JoshuaKGoldberg commented Jan 9, 2026

Uh oh!

lishaduck commented Jan 11, 2026

Uh oh!

JoshuaKGoldberg commented Jan 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JoshuaKGoldberg commented Jan 13, 2026

Uh oh!

allcontributors bot commented Jan 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

JoshuaKGoldberg commented Jan 9, 2026 •

edited

Loading

changeset-bot bot commented Jan 9, 2026 •

edited

Loading

vercel bot commented Jan 9, 2026 •

edited

Loading

auvred Jan 9, 2026 •

edited

Loading

JoshuaKGoldberg commented Jan 12, 2026 •

edited

Loading