WIP: linter host, VFS, and other related experiments#1179
WIP: linter host, VFS, and other related experiments#1179auvred wants to merge 13 commits intoflint-fyi:mainfrom
Conversation
|
@auvred is attempting to deploy a commit to the SquiggleTools Team on Vercel. A member of the Team first needs to authorize it. |
|
👋 Hi @auvred, thanks for the pull request! A scan flagged some concerns with it. Could you please take a look? [pr-title-conventional] The PR title has an unknown type: 'WIP'. Known types are: 'build', 'chore', 'ci', 'docs', 'feat', 'fix', 'perf', 'refactor', 'revert', 'style', 'test' This repository asks that pull request titles start with a type in the Conventional Commits format. Doing so helps make the purpose of each pull request clear for humans and machines. To resolve this report, replace the current type with one of those known types, like "feat: linter host, VFS, and other related experiments". [pr-task-completion] This PR's body is missing
Repositories often provide a set of tasks that pull request authors are expected to complete. Those tasks should be marked as completed with a
|
| { | ||
| "name": "@flint.fyi/svelte-language", | ||
| "version": "0.0.1", | ||
| "description": "[Experimental] TypeScript language plugin for Flint.", |
There was a problem hiding this comment.
This probably isn't an issue with this PR, but when I think "TypeScript language plugin" I think compilerOptions.plugins. "Volar plugin for Svelte"?
I guess long term, we'll want to extract style blocks & HTML out as well?
There was a problem hiding this comment.
Oh, wait I think it's just a copy-paste error.
| "description": "[Experimental] TypeScript language plugin for Flint.", | |
| "description": "[Experimental] Svelte language plugin for Flint.", |
There was a problem hiding this comment.
Oh, yeah! Thanks for pointing that out. I'm planning to reconcile the package.json/tsconfig.json/etc. setups once I'm closer to finishing my experiments, so the new package setup aligns with your ongoing effort to overhaul our tooling.
|
Closing in favor of #2315 |
PR Checklist
status: accepting prsOverview
This PR fixes the following issues:
ScriptKind.TSfor non-TS languages #1142All these issues depend each on other and it's easier to experiment on a new architecture while testing that it moves all these issues in the right direction.
(Edited by @lishaduck to link the fixes so GH'll pick them up)