Skip to content

fix(ts): [chainedAssignments] allow non-assignment right-side operators#1025

Merged
JoshuaKGoldberg merged 2 commits intomainfrom
ts-chainedAssignments-allow-non-assignment-right-sides
Nov 27, 2025
Merged

fix(ts): [chainedAssignments] allow non-assignment right-side operators#1025
JoshuaKGoldberg merged 2 commits intomainfrom
ts-chainedAssignments-allow-non-assignment-right-sides

Conversation

@JoshuaKGoldberg
Copy link
Copy Markdown
Collaborator

@JoshuaKGoldberg JoshuaKGoldberg commented Nov 27, 2025

PR Checklist

Overview

Previously, only the left-side operator was being checked for whether it's an assignment operator. Now the right-side one is as well.

❤️‍🔥

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Nov 27, 2025

🦋 Changeset detected

Latest commit: b5c0573

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@flint.fyi/ts Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link
Copy Markdown

vercel bot commented Nov 27, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
flint Ready Ready Preview Comment Nov 27, 2025 8:59pm

@github-actions

This comment was marked as resolved.

@JoshuaKGoldberg JoshuaKGoldberg merged commit 7e21021 into main Nov 27, 2025
9 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the ts-chainedAssignments-allow-non-assignment-right-sides branch November 27, 2025 21:03
JoshuaKGoldberg added a commit that referenced this pull request Dec 11, 2025
## PR Checklist

- [x] Addresses an existing open issue: fixes #1021
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/flint/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/flint/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

Enables the full list of internally-relevant rules, as originally
attempted in #998. This is now doable because of fixes that landed
later:

* #1025
* #1028

❤️‍🔥
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐛 Bug: [ts.chainedAssignments] Shouldn't report string += ... + concatenation

1 participant