fix(ts): [forDirections] allow multi-part conditions#1028
Merged
JoshuaKGoldberg merged 2 commits intomainfrom Nov 27, 2025
Merged
fix(ts): [forDirections] allow multi-part conditions#1028JoshuaKGoldberg merged 2 commits intomainfrom
JoshuaKGoldberg merged 2 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: 2c1a752 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
3 tasks
3 tasks
JoshuaKGoldberg
added a commit
that referenced
this pull request
Dec 11, 2025
## PR Checklist - [x] Addresses an existing open issue: fixes #1021 - [x] That issue was marked as [`status: accepting prs`](https://github.com/JoshuaKGoldberg/flint/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22) - [x] Steps in [CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/flint/blob/main/.github/CONTRIBUTING.md) were taken ## Overview Enables the full list of internally-relevant rules, as originally attempted in #998. This is now doable because of fixes that landed later: * #1025 * #1028 ❤️🔥
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
status: accepting prsOverview
Augments the rule's logic to recurse down into multi-part conditions, and then bail if they don't find a name.
Also aligns the name of the utility method from "updater" to the TS-AST-used "incrementor".
❤️🔥