Conversation
Summary of ChangesHello @flashinfer-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request ensures that the project's code ownership is accurately reflected in the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
📝 WalkthroughWalkthroughRewrites Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Code Review
This pull request contains an automated update to the .github/CODEOWNERS file. The change reorders two owners for the include/flashinfer/trtllm/ path, which aligns with the PR's goal of reflecting recent contribution history. The change is syntactically correct and appears to be functioning as intended by the automation script. I have reviewed the change and found no issues.
f033c93 to
b5064ab
Compare
b5064ab to
06e594a
Compare
06e594a to
3f6422a
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In @.github/CODEOWNERS:
- Line 49: The CODEOWNERS entry for the "scripts/" path contains a duplicate
owner (`@yongwww`); edit the "scripts/ `@yzh119` `@yongwww` `@nvmbreughe` `@kahyunnam`
`@yongwww`" line to remove the repeated `@yongwww` so each owner appears only once
(e.g., "scripts/ `@yzh119` `@yongwww` `@nvmbreughe` `@kahyunnam`").
3f6422a to
57806ff
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In @.github/CODEOWNERS:
- Line 47: Update the CODEOWNERS entry for the path "include/flashinfer/mamba/"
to list the actual contributors instead of only `@yzh119`: modify the line
"include/flashinfer/mamba/ `@yzh119`" to include Igor Shovkun and Zihao Ye (their
GitHub handles) alongside any existing owner(s) so the entry reflects the commit
history and current maintainers; ensure the format remains a single
space-separated list of owners after the path.
95362dd to
a36aad2
Compare
Auto-generated CODEOWNERS update based on commit activity over the last 180 days.
a36aad2 to
c7435ae
Compare
The same GitHub username could appear multiple times if a contributor uses different email addresses (e.g., corporate email and GitHub noreply email). These were treated as separate contributors but resolved to the same username, causing duplicates like "@yongwww @yongwww" in the output. Added case-insensitive deduplication when extracting GitHub usernames from computed owners in generate_codeowners_file(). Fixes the issue flagged in PR flashinfer-ai#2286. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
The same GitHub username could appear multiple times if a contributor uses different email addresses (e.g., corporate email and GitHub noreply email). These were treated as separate contributors but resolved to the same username, causing duplicates like "@yongwww @yongwww" in the output. Added case-insensitive deduplication when extracting GitHub usernames from computed owners in generate_codeowners_file(). Fixes the issue flagged in PR flashinfer-ai#2286. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Ensures workflow file changes require review from repo admins and maintainers for better CI/CD governance.
<!-- .github/pull_request_template.md --> ## 📌 Description The same GitHub username could appear multiple times if a contributor uses different email addresses (e.g., corporate email and GitHub noreply email). These were treated as separate contributors but resolved to the same username, causing duplicates like "@sricketts @sricketts" in the output. Added case-insensitive deduplication when extracting GitHub usernames from computed owners in generate_codeowners_file(). Fixes the issue flagged in PR #2286. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> ## 🔍 Related Issues <!-- Link any related issues here --> ## 🚀 Pull Request Checklist Thank you for contributing to FlashInfer! Before we review your pull request, please make sure the following items are complete. ### ✅ Pre-commit Checks - [x] I have installed `pre-commit` by running `pip install pre-commit` (or used your preferred method). - [x] I have installed the hooks with `pre-commit install`. - [x] I have run the hooks manually with `pre-commit run --all-files` and fixed any reported issues. > If you are unsure about how to set up `pre-commit`, see [the pre-commit documentation](https://pre-commit.com/). ## 🧪 Tests I tested locally. We don't generally add tests for this script. ## Reviewer Notes <!-- Optional: anything you'd like reviewers to focus on, concerns, etc. --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## Release Notes * **Bug Fixes** * Enhanced the codeowner analysis tool with improved deduplication using case-insensitive matching. This prevents duplicate owner entries in analysis results and ensures accurate consolidation of codeowners regardless of username case variations. The system now properly handles both GitHub username and email-based owner identification to provide cleaner results. <!-- end of auto-generated comment: release notes by coderabbit.ai --> Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
<!-- .github/pull_request_template.md --> ## 📌 Description The same GitHub username could appear multiple times if a contributor uses different email addresses (e.g., corporate email and GitHub noreply email). These were treated as separate contributors but resolved to the same username, causing duplicates like "@sricketts @sricketts" in the output. Added case-insensitive deduplication when extracting GitHub usernames from computed owners in generate_codeowners_file(). Fixes the issue flagged in PR flashinfer-ai/flashinfer#2286. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> ## 🔍 Related Issues <!-- Link any related issues here --> ## 🚀 Pull Request Checklist Thank you for contributing to FlashInfer! Before we review your pull request, please make sure the following items are complete. ### ✅ Pre-commit Checks - [x] I have installed `pre-commit` by running `pip install pre-commit` (or used your preferred method). - [x] I have installed the hooks with `pre-commit install`. - [x] I have run the hooks manually with `pre-commit run --all-files` and fixed any reported issues. > If you are unsure about how to set up `pre-commit`, see [the pre-commit documentation](https://pre-commit.com/). ## 🧪 Tests I tested locally. We don't generally add tests for this script. ## Reviewer Notes <!-- Optional: anything you'd like reviewers to focus on, concerns, etc. --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## Release Notes * **Bug Fixes** * Enhanced the codeowner analysis tool with improved deduplication using case-insensitive matching. This prevents duplicate owner entries in analysis results and ensures accurate consolidation of codeowners regardless of username case variations. The system now properly handles both GitHub username and email-based owner identification to provide cleaner results. <!-- end of auto-generated comment: release notes by coderabbit.ai --> Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
…2637) <!-- .github/pull_request_template.md --> ## 📌 Description The same GitHub username could appear multiple times if a contributor uses different email addresses (e.g., corporate email and GitHub noreply email). These were treated as separate contributors but resolved to the same username, causing duplicates like "@sricketts @sricketts" in the output. Added case-insensitive deduplication when extracting GitHub usernames from computed owners in generate_codeowners_file(). Fixes the issue flagged in PR flashinfer-ai#2286. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> ## 🔍 Related Issues <!-- Link any related issues here --> ## 🚀 Pull Request Checklist Thank you for contributing to FlashInfer! Before we review your pull request, please make sure the following items are complete. ### ✅ Pre-commit Checks - [x] I have installed `pre-commit` by running `pip install pre-commit` (or used your preferred method). - [x] I have installed the hooks with `pre-commit install`. - [x] I have run the hooks manually with `pre-commit run --all-files` and fixed any reported issues. > If you are unsure about how to set up `pre-commit`, see [the pre-commit documentation](https://pre-commit.com/). ## 🧪 Tests I tested locally. We don't generally add tests for this script. ## Reviewer Notes <!-- Optional: anything you'd like reviewers to focus on, concerns, etc. --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## Release Notes * **Bug Fixes** * Enhanced the codeowner analysis tool with improved deduplication using case-insensitive matching. This prevents duplicate owner entries in analysis results and ensures accurate consolidation of codeowners regardless of username case variations. The system now properly handles both GitHub username and email-based owner identification to provide cleaner results. <!-- end of auto-generated comment: release notes by coderabbit.ai --> Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com> Signed-off-by: Amey Naik <212485788+ameynaik-hub@users.noreply.github.com>
## Summary This PR updates the CODEOWNERS file based on git commit history analysis from the last 180 days. ## Changes - Updated `.github/CODEOWNERS` with current code ownership based on: - Commit frequency - File coverage - Commit recency - Manual overrides from `scripts/codeowner_overrides.json` ## How to Review 1. Review the changes to `.github/CODEOWNERS` 2. Verify that the assigned owners are appropriate for each module 3. Make manual adjustments if needed before merging ## Notes - This is an automated PR generated weekly - Minimum commits threshold: 1 - Analysis period: 180 days - Directory depth: 3 levels - Top N owners per module: 5 --- 🤖 This PR was automatically generated by the [update-codeowners workflow](.github/workflows/update-codeowners.yml) --------- Co-authored-by: flashinfer-bot <flashinfer-bot@users.noreply.github.com> Co-authored-by: Scott Ricketts <sricketts@nvidia.com> Co-authored-by: Larry Wu <larwu@nvidia.com> Signed-off-by: Amey Naik <212485788+ameynaik-hub@users.noreply.github.com>
Summary
This PR updates the CODEOWNERS file based on git commit history analysis from the last 180 days.
Changes
.github/CODEOWNERSwith current code ownership based on:scripts/codeowner_overrides.jsonHow to Review
.github/CODEOWNERSNotes
🤖 This PR was automatically generated by the update-codeowners workflow