Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request automates the weekly update of the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
📝 WalkthroughWalkthroughReplaced Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request automatically updates the .github/CODEOWNERS file based on recent contribution history. The changes appear to be in line with the stated goal of reflecting current ownership. I have found one minor redundancy where a subdirectory is assigned the same owner as its parent directory, which could be simplified. I've added a specific comment with a suggestion to address this for better maintainability.
.github/CODEOWNERS
Outdated
| flashinfer/norm/ @yzh119 | ||
| flashinfer/norm/kernels/ @yzh119 |
There was a problem hiding this comment.
This seems to be a redundant entry generated by the automation script. The flashinfer/norm/kernels/ path is already covered by the flashinfer/norm/ entry, as they share the same owner. According to CODEOWNERS syntax, ownership is inherited by subdirectories.
To keep the CODEOWNERS file concise, this redundant line can be removed. It might be worth updating the generation script to handle such cases.
flashinfer/norm/ @yzh119
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (3)
.github/CODEOWNERS (3)
36-37: Consider using team aliases for JIT attention/GEMM ownership to reduce churn.Line 36 and Line 37 list only individuals for
flashinfer/jit/attention/andflashinfer/jit/gemm/, while nearby attention/GEMM paths already use@flashinfer-ai/attention-owners/@flashinfer-ai/gemm-owners. Aligning these would make ownership updates more stable.Suggested CODEOWNERS adjustment
-flashinfer/jit/attention/ `@jimmyzho` `@yzh119` `@cyx-6` -flashinfer/jit/gemm/ `@yzh119` `@jimmyzho` `@aleozlx` `@nv-yunzheq` `@jiahanc` +flashinfer/jit/attention/ `@flashinfer-ai/attention-owners` `@jimmyzho` `@yzh119` +flashinfer/jit/gemm/ `@flashinfer-ai/gemm-owners` `@yzh119` `@jimmyzho`🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/CODEOWNERS around lines 36 - 37, Replace the individual GitHub usernames on the CODEOWNERS entries for the paths "flashinfer/jit/attention/" and "flashinfer/jit/gemm/" with the existing team aliases used elsewhere: use "@flashinfer-ai/attention-owners" for flashinfer/jit/attention/ and "@flashinfer-ai/gemm-owners" for flashinfer/jit/gemm/; update the two lines (currently listing `@jimmyzho` `@yzh119` `@cyx-6` and `@yzh119` `@jimmyzho` `@aleozlx` `@nv-yunzheq` `@jiahanc`) to those team handles, preserving the path format and spacing to match adjacent CODEOWNERS entries.
54-54: Single-owner path may become a review bottleneck.Line 54 assigns
tests/autotuner/to only@bkryu. Consider adding one backup owner/team for continuity during PTO/oncall load.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/CODEOWNERS at line 54, The CODEOWNERS entry for the path `tests/autotuner/` currently lists only `@bkryu` which creates a single-owner bottleneck; update that entry to include a backup owner or team (for example add an org team like `@your-org/autotuner` or an alternate user such as `@another-dev`) so the line containing `tests/autotuner/ `@bkryu`` becomes `tests/autotuner/ `@bkryu` `@your-org/autotuner`` (or similar) to ensure continuity during PTO/oncall load.
39-40: Norm directory ownership is narrower than related norm surfaces.Line 39 and Line 40 assign only
@yzh119, butflashinfer/norm.py(Line 73) is explicitly owned by@flashinfer-ai/misc-op-owners@kahyunnam``. This split may miss expected reviewers for kernel-side norm changes.Suggested CODEOWNERS adjustment
-flashinfer/norm/ `@yzh119` -flashinfer/norm/kernels/ `@yzh119` +flashinfer/norm/ `@flashinfer-ai/misc-op-owners` `@kahyunnam` `@yzh119` +flashinfer/norm/kernels/ `@flashinfer-ai/misc-op-owners` `@kahyunnam` `@yzh119`🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/CODEOWNERS around lines 39 - 40, The CODEOWNERS entries for "flashinfer/norm/" and "flashinfer/norm/kernels/" only list `@yzh119` while flashinfer/norm.py is owned by `@flashinfer-ai/misc-op-owners` and `@kahyunnam`; update the CODEOWNERS so kernel-side changes also notify the file owners by adding `@flashinfer-ai/misc-op-owners` and `@kahyunnam` to the directory rules (or add a new overlapping rule for flashinfer/norm/*) so that `@yzh119`, `@flashinfer-ai/misc-op-owners`, and `@kahyunnam` are included for relevant norm changes.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In @.github/CODEOWNERS:
- Around line 36-37: Replace the individual GitHub usernames on the CODEOWNERS
entries for the paths "flashinfer/jit/attention/" and "flashinfer/jit/gemm/"
with the existing team aliases used elsewhere: use
"@flashinfer-ai/attention-owners" for flashinfer/jit/attention/ and
"@flashinfer-ai/gemm-owners" for flashinfer/jit/gemm/; update the two lines
(currently listing `@jimmyzho` `@yzh119` `@cyx-6` and `@yzh119` `@jimmyzho` `@aleozlx`
`@nv-yunzheq` `@jiahanc`) to those team handles, preserving the path format and
spacing to match adjacent CODEOWNERS entries.
- Line 54: The CODEOWNERS entry for the path `tests/autotuner/` currently lists
only `@bkryu` which creates a single-owner bottleneck; update that entry to
include a backup owner or team (for example add an org team like
`@your-org/autotuner` or an alternate user such as `@another-dev`) so the line
containing `tests/autotuner/ `@bkryu`` becomes `tests/autotuner/ `@bkryu`
`@your-org/autotuner`` (or similar) to ensure continuity during PTO/oncall load.
- Around line 39-40: The CODEOWNERS entries for "flashinfer/norm/" and
"flashinfer/norm/kernels/" only list `@yzh119` while flashinfer/norm.py is owned
by `@flashinfer-ai/misc-op-owners` and `@kahyunnam`; update the CODEOWNERS so
kernel-side changes also notify the file owners by adding
`@flashinfer-ai/misc-op-owners` and `@kahyunnam` to the directory rules (or add a
new overlapping rule for flashinfer/norm/*) so that `@yzh119`,
`@flashinfer-ai/misc-op-owners`, and `@kahyunnam` are included for relevant norm
changes.
flashinfer-bot
force-pushed
the
auto-update-codeowners
branch
from
67422d7 to
4df9935
Compare
flashinfer-bot
requested review from
aleozlx,
bkryu,
cyx-6,
jimmyzho,
kahyunnam,
nv-yunzheq,
saltyminty,
sricketts,
yongwww,
yyihuang and
yzh119
as code owners
Auto-generated CODEOWNERS update based on commit activity over the last 180 days.
flashinfer-bot
force-pushed
the
auto-update-codeowners
branch
from
4df9935 to
bcc7c8b
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/CODEOWNERS:
- Line 77: Replace the incorrect team reference `@ci-users` in the CODEOWNERS
entry that points to `scripts/codeowner_overrides.json` with the
organization-qualified team `@flashinfer-ai/ci-users`; locate the line
containing `scripts/codeowner_overrides.json `@ci-users`` and update it to use
`@flashinfer-ai/ci-users` so it matches the `@org/team-name` format used
elsewhere (e.g., `@flashinfer-ai/attention-owners`,
`@flashinfer-ai/moe-owners`).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
| flashinfer/gdn_prefill.py @flashinfer-ai/misc-op-owners @kahyunnam | ||
| flashinfer/jit/gdn.py @flashinfer-ai/misc-op-owners @kahyunnam | ||
| flashinfer/norm.py @flashinfer-ai/misc-op-owners @kahyunnam | ||
| scripts/codeowner_overrides.json @ci-users |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Description: Verify if `@ci-users` is a valid GitHub user or team
# Check if ci-users is a valid GitHub user
echo "Checking if ci-users is a valid GitHub user..."
gh api /users/ci-users 2>&1 || echo "User ci-users not found"
# Check if there's a team called ci-users in the flashinfer-ai org
echo -e "\nChecking for teams in flashinfer-ai org matching 'ci'..."
gh api /orgs/flashinfer-ai/teams --jq '.[].slug' | grep -i ci || echo "No ci-related teams found"
# List all teams to see what's available
echo -e "\nAll teams in flashinfer-ai org:"
gh api /orgs/flashinfer-ai/teams --jq '.[].slug'Repository: flashinfer-ai/flashinfer
Length of output: 590
Change @ci-users to @flashinfer-ai/ci-users to match the team naming convention used throughout the file.
Line 77 has @ci-users, which breaks the @org/team-name format used consistently elsewhere in this file (e.g., @flashinfer-ai/attention-owners, @flashinfer-ai/moe-owners). This should be @flashinfer-ai/ci-users to be a valid GitHub team reference.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In @.github/CODEOWNERS at line 77, Replace the incorrect team reference
`@ci-users` in the CODEOWNERS entry that points to
`scripts/codeowner_overrides.json` with the organization-qualified team
`@flashinfer-ai/ci-users`; locate the line containing
`scripts/codeowner_overrides.json `@ci-users`` and update it to use
`@flashinfer-ai/ci-users` so it matches the `@org/team-name` format used
elsewhere (e.g., `@flashinfer-ai/attention-owners`,
`@flashinfer-ai/moe-owners`).
1 participant
Summary
This PR updates the CODEOWNERS file based on git commit history analysis from the last 180 days.
Changes
.github/CODEOWNERSwith current code ownership based on:scripts/codeowner_overrides.jsonHow to Review
.github/CODEOWNERSNotes
🤖 This PR was automatically generated by the update-codeowners workflow
Summary by CodeRabbit