[chore] Add jiahanc to moe related code owner#2748
[chore] Add jiahanc to moe related code owner#2748aleozlx merged 2 commits intoflashinfer-ai:mainfrom
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughAppended codeowner "jiahanc" to three entries in Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the code ownership configuration to assign Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds @jiahanc as a code owner for MoE-related paths. The changes in scripts/codeowner_overrides.json correctly add the new owner to flashinfer/fused_moe, csrc/fused_moe, and tests/moe. However, there is an additional change that grants ownership of the entire csrc directory, which seems to be broader than the stated intent of the PR. Please see the specific comment for details.
Note: Security Review has been skipped due to the limited scope of the PR.
scripts/codeowner_overrides.json
Outdated
| { | ||
| "scripts/codeowner_overrides.json": ["@ci-users"], | ||
|
|
||
| "csrc": ["@jiahanc"], |
There was a problem hiding this comment.
This line makes @jiahanc the owner of the entire csrc directory. The PR title and description mention adding ownership for MoE-related code only. This change seems broader than intended, as it grants ownership over non-MoE parts of csrc like attention, gemm, and comm. If the goal is to only be an owner for MoE code, this line should probably be removed, as the more specific ownership rules for MoE paths have already been added below.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@scripts/codeowner_overrides.json`:
- Line 4: The override currently sets the broad JSON key "csrc": ["@jiahanc"],
making `@jiahanc` a fallback owner for all csrc/** paths; narrow this to only the
MOE paths by removing or replacing the "csrc" key with the MOE-specific module
key (e.g., "csrc/moe" or "csrc/moe/**") so the override only applies to MOE
files, and ensure the three existing MOE-specific overrides below remain intact.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: de471799-61e6-4ad2-b22a-f75ae741fb56
📒 Files selected for processing (1)
scripts/codeowner_overrides.json
jiahanc
force-pushed
the
updateCodeOwner
branch
2 times, most recently
from
fc71e6f to
7cfbbcc
Compare
Made-with: Cursor
Signed-off-by: jiahanc <173873397+jiahanc@users.noreply.github.com>
jiahanc
force-pushed
the
updateCodeOwner
branch
from
7cfbbcc to
843a773
Compare
Made-with: Cursor <!-- .github/pull_request_template.md --> ## 📌 Description Add jiahanc to MOE related code owner ## 🔍 Related Issues <!-- Link any related issues here --> ## 🚀 Pull Request Checklist Thank you for contributing to FlashInfer! Before we review your pull request, please make sure the following items are complete. ### ✅ Pre-commit Checks - [x] I have installed `pre-commit` by running `pip install pre-commit` (or used your preferred method). - [x] I have installed the hooks with `pre-commit install`. - [x] I have run the hooks manually with `pre-commit run --all-files` and fixed any reported issues. > If you are unsure about how to set up `pre-commit`, see [the pre-commit documentation](https://pre-commit.com/). ## 🧪 Tests - [x] Tests have been added or updated as needed. - [x] All tests are passing (`unittest`, etc.). ## Reviewer Notes <!-- Optional: anything you'd like reviewers to focus on, concerns, etc. --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Chores** * Updated code ownership assignments for internal modules and test directories to reflect organizational changes in development responsibilities. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Signed-off-by: jiahanc <173873397+jiahanc@users.noreply.github.com>
Made-with: Cursor <!-- .github/pull_request_template.md --> ## 📌 Description Add jiahanc to MOE related code owner ## 🔍 Related Issues <!-- Link any related issues here --> ## 🚀 Pull Request Checklist Thank you for contributing to FlashInfer! Before we review your pull request, please make sure the following items are complete. ### ✅ Pre-commit Checks - [x] I have installed `pre-commit` by running `pip install pre-commit` (or used your preferred method). - [x] I have installed the hooks with `pre-commit install`. - [x] I have run the hooks manually with `pre-commit run --all-files` and fixed any reported issues. > If you are unsure about how to set up `pre-commit`, see [the pre-commit documentation](https://pre-commit.com/). ## 🧪 Tests - [x] Tests have been added or updated as needed. - [x] All tests are passing (`unittest`, etc.). ## Reviewer Notes <!-- Optional: anything you'd like reviewers to focus on, concerns, etc. --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Chores** * Updated code ownership assignments for internal modules and test directories to reflect organizational changes in development responsibilities. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Signed-off-by: jiahanc <173873397+jiahanc@users.noreply.github.com> Signed-off-by: Amey Naik <212485788+ameynaik-hub@users.noreply.github.com>
3 participants
Made-with: Cursor
📌 Description
Add jiahanc to MOE related code owner
🔍 Related Issues
🚀 Pull Request Checklist
Thank you for contributing to FlashInfer! Before we review your pull request, please make sure the following items are complete.
✅ Pre-commit Checks
pre-commitby runningpip install pre-commit(or used your preferred method).pre-commit install.pre-commit run --all-filesand fixed any reported issues.🧪 Tests
unittest, etc.).Reviewer Notes
Summary by CodeRabbit