Experiment Add @kahyunnam as co-owner for several files#2713
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the code ownership configuration by assigning Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
📝 WalkthroughWalkthroughUpdated code ownership assignments in Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Code ReviewThis PR adds Summary The change is straightforward and mechanically consistent. Observations
Verdict: No issues with the change itself. Suggest filling in the PR description for record-keeping and confirming whether |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds @kahyunnam as a co-owner for several files and directories related to norm and gdn features by modifying the scripts/codeowner_overrides.json file. The changes are straightforward and align with the PR's title. The modifications are consistent across all specified paths. I've reviewed the changes and found no issues.
Note: Security Review has been skipped due to the limited scope of the PR.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
scripts/codeowner_overrides.json (1)
22-32: Minor inconsistency: trailing slashes on directory paths.Existing directory entries in this file (e.g.,
"include/flashinfer/attention","tests/attention","tests/gemm") omit trailing slashes, but some new entries include them ("benchmarks/gdn/","flashinfer/gdn_kernels/","tests/gdn/"). Consider removing trailing slashes for consistency, unless the codeowner tooling requires them for directory matching.Suggested fix for consistency
- "benchmarks/gdn/": ["@flashinfer-ai/misc-op-owners", "@kahyunnam"], + "benchmarks/gdn": ["@flashinfer-ai/misc-op-owners", "@kahyunnam"], "csrc/gdn_prefill_launcher.cu": ["@flashinfer-ai/misc-op-owners", "@kahyunnam"], "csrc/gdn_prefill_sm90_kernel_inst.jinja": ["@flashinfer-ai/misc-op-owners", "@kahyunnam"], "flashinfer/gdn_decode.py": ["@flashinfer-ai/misc-op-owners", "@kahyunnam"], - "flashinfer/gdn_kernels/": ["@flashinfer-ai/misc-op-owners", "@kahyunnam"], + "flashinfer/gdn_kernels": ["@flashinfer-ai/misc-op-owners", "@kahyunnam"], "flashinfer/gdn_prefill.py": ["@flashinfer-ai/misc-op-owners", "@kahyunnam"], "flashinfer/jit/gdn.py": ["@flashinfer-ai/misc-op-owners", "@kahyunnam"], - "tests/gdn/": ["@flashinfer-ai/misc-op-owners", "@kahyunnam"] + "tests/gdn": ["@flashinfer-ai/misc-op-owners", "@kahyunnam"]🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@scripts/codeowner_overrides.json` around lines 22 - 32, The new entries in scripts/codeowner_overrides.json use inconsistent trailing slashes for directory keys; update the keys "benchmarks/gdn/", "flashinfer/gdn_kernels/", and "tests/gdn/" to remove the trailing slash (make them "benchmarks/gdn", "flashinfer/gdn_kernels", "tests/gdn") so they match the existing style used for other directories like "tests/attention"; ensure no other entries use trailing slashes unless your codeowner tooling explicitly requires them.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@scripts/codeowner_overrides.json`:
- Around line 22-32: The new entries in scripts/codeowner_overrides.json use
inconsistent trailing slashes for directory keys; update the keys
"benchmarks/gdn/", "flashinfer/gdn_kernels/", and "tests/gdn/" to remove the
trailing slash (make them "benchmarks/gdn", "flashinfer/gdn_kernels",
"tests/gdn") so they match the existing style used for other directories like
"tests/attention"; ensure no other entries use trailing slashes unless your
codeowner tooling explicitly requires them.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 45501468-13d2-46dd-bd5c-3b5d610ffc5d
📒 Files selected for processing (1)
scripts/codeowner_overrides.json
|
this pr is aiming at investigating an observation in the code owner behavior in |
|
i hope there is a way to skip CI for edits on this file? does such thing already exist? i thought the CI skips in certain situations |
|
adding CI exclusion for codeowner_overrides.json to make future changes more efficient |
…i#2713) <!-- .github/pull_request_template.md --> ## 📌 Description <!-- What does this PR do? Briefly describe the changes and why they’re needed. --> ## 🔍 Related Issues <!-- Link any related issues here --> ## 🚀 Pull Request Checklist Thank you for contributing to FlashInfer! Before we review your pull request, please make sure the following items are complete. ### ✅ Pre-commit Checks - [ ] I have installed `pre-commit` by running `pip install pre-commit` (or used your preferred method). - [ ] I have installed the hooks with `pre-commit install`. - [ ] I have run the hooks manually with `pre-commit run --all-files` and fixed any reported issues. > If you are unsure about how to set up `pre-commit`, see [the pre-commit documentation](https://pre-commit.com/). ## 🧪 Tests - [ ] Tests have been added or updated as needed. - [ ] All tests are passing (`unittest`, etc.). ## Reviewer Notes <!-- Optional: anything you'd like reviewers to focus on, concerns, etc. --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Chores** * Updated internal code ownership configuration. No changes to product functionality or user-facing features. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
…i#2713) <!-- .github/pull_request_template.md --> ## 📌 Description <!-- What does this PR do? Briefly describe the changes and why they’re needed. --> ## 🔍 Related Issues <!-- Link any related issues here --> ## 🚀 Pull Request Checklist Thank you for contributing to FlashInfer! Before we review your pull request, please make sure the following items are complete. ### ✅ Pre-commit Checks - [ ] I have installed `pre-commit` by running `pip install pre-commit` (or used your preferred method). - [ ] I have installed the hooks with `pre-commit install`. - [ ] I have run the hooks manually with `pre-commit run --all-files` and fixed any reported issues. > If you are unsure about how to set up `pre-commit`, see [the pre-commit documentation](https://pre-commit.com/). ## 🧪 Tests - [ ] Tests have been added or updated as needed. - [ ] All tests are passing (`unittest`, etc.). ## Reviewer Notes <!-- Optional: anything you'd like reviewers to focus on, concerns, etc. --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Chores** * Updated internal code ownership configuration. No changes to product functionality or user-facing features. <!-- end of auto-generated comment: release notes by coderabbit.ai --> Signed-off-by: Amey Naik <212485788+ameynaik-hub@users.noreply.github.com>
3 participants
📌 Description
🔍 Related Issues
🚀 Pull Request Checklist
Thank you for contributing to FlashInfer! Before we review your pull request, please make sure the following items are complete.
✅ Pre-commit Checks
pre-commitby runningpip install pre-commit(or used your preferred method).pre-commit install.pre-commit run --all-filesand fixed any reported issues.🧪 Tests
unittest, etc.).Reviewer Notes
Summary by CodeRabbit