Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add basic support for Biome #316

Merged
merged 8 commits into from
Jul 9, 2024
Merged

Conversation

KurtGokhan
Copy link
Contributor

@KurtGokhan KurtGokhan commented May 6, 2024

Fixes #279

Mostly based on the ESLint checker.

I can add examples later.

I tried to create an example in StackBlitz but Biome doesn't work in StackBlitz for now.

CodeSandbox example

Copy link

changeset-bot bot commented May 6, 2024

🦋 Changeset detected

Latest commit: a06f0df

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
vite-plugin-checker Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented May 6, 2024

Deploy Preview for vite-plugin-checker ready!

Name Link
🔨 Latest commit a06f0df
🔍 Latest deploy log https://app.netlify.com/sites/vite-plugin-checker/deploys/668c55f1c531fd0008f3c412
😎 Deploy Preview https://deploy-preview-316--vite-plugin-checker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@KurtGokhan
Copy link
Contributor Author

@fi3ework any concerns about this?

@KurtGokhan KurtGokhan mentioned this pull request May 9, 2024
3 tasks
@momococomomo
Copy link

This is all that's holding us back from adopting Biome ATM. When will you merge this?

@yann-combarnous
Copy link

@fi3ework , any chance to merge this, maybe with an experimental _unstable prefix until there is more feedback?

@KurtGokhan
Copy link
Contributor Author

KurtGokhan commented Jun 24, 2024

As this is not getting merged, I am going to create a temporary fork and merge this there. I want to get out of ESlint ecosystem soon and this is blocking me.

Edit: My fork is ready and can be installed as vite-plugin-checker-biome

@kamikazePT
Copy link

@KurtGokhan the failed tests, was it just a faulty run or is it broken in those scenarios? asking mostly because of node-20 ubuntu

@jhoermann
Copy link
Contributor

@KurtGokhan the failed tests, was it just a faulty run or is it broken in those scenarios? asking mostly because of node-20 ubuntu

@kamikazePT Tests are faulty for quite some time - see #264. Seems like they are getting fixed in PR #327.

@fi3ework
Copy link
Owner

fi3ework commented Jul 7, 2024

Thanks @KurtGokhan for your contributing, and sorry for the long time to respond. I tweaked the code and it almost done. While there's something wrong when updating file diagnostic on Windows (I guess that's caused by the mix use of absPath and Biome's file.path. Could you help out if you're using a Window machine, or I'll take some time to grab a Windows machine next week. Thanks.

@KurtGokhan
Copy link
Contributor Author

@fi3ework Thanks a lot for the updates. It looks much more polished now.

I noticed the issue now. Will try to fix it.

@KurtGokhan
Copy link
Contributor Author

The issue should be fixed now.

Although now I think, it would be easier to just re-run Biome on all files on every file change, and it wouldn't even be noticeable because Biome is so fast. Maybe can add it as an option later.

@fi3ework
Copy link
Owner

fi3ework commented Jul 9, 2024

The issue should be fixed now.
Although now I think, it would be easier to just re-run Biome on all files on every file change, and it wouldn't even be
noticeable because Biome is so fast. Maybe can add it as an option later.

If we could make it incremental and scalable now, we'd keep in this way. Full re-scan will take up all CPU resources (I guess, Biome will try to use the utmost resource it could), and that could cause a lag in user's device.

@fi3ework
Copy link
Owner

fi3ework commented Jul 9, 2024

Thank you very much @KurtGokhan.

@fi3ework fi3ework merged commit 568b782 into fi3ework:main Jul 9, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Biome support
6 participants