normalize path returned by biome

fi3ework · Jul 8, 2024 · a06f0df · a06f0df
1 parent e9c4791
commit a06f0df
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 26 deletions.
diff --git a/packages/vite-plugin-checker/src/checkers/biome/cli.ts b/packages/vite-plugin-checker/src/checkers/biome/cli.ts
@@ -1,4 +1,5 @@
 import { exec } from 'node:child_process'
+import path from 'node:path'
 import strip from 'strip-ansi'
 import { createFrame } from '../../codeFrame.js'
 import type { NormalizedDiagnostic } from '../../logger.js'
@@ -39,8 +40,11 @@ function parseBiomeOutput(output: string) {
   }
 
   const diagnostics: NormalizedDiagnostic[] = parsed.diagnostics.map((d) => {
+    let file = d.location.path?.file
+    if (file) file = path.normalize(file)
+
     const loc = {
-      file: d.location.path?.file || '',
+      file: file || '',
       start: getLineAndColumn(d.location.sourceCode, d.location.span?.[0]),
       end: getLineAndColumn(d.location.sourceCode, d.location.span?.[1]),
     }
@@ -52,7 +56,7 @@ function parseBiomeOutput(output: string) {
       conclusion: '',
       level: severityMap[d.severity as keyof typeof severityMap] ?? DiagnosticLevel.Error,
       checker: 'Biome',
-      id: d.location.path?.file,
+      id: file,
       codeFrame,
       stripedCodeFrame: codeFrame && strip(codeFrame),
       loc,

diff --git a/packages/vite-plugin-checker/src/checkers/biome/main.ts b/packages/vite-plugin-checker/src/checkers/biome/main.ts
@@ -1,8 +1,7 @@
-import { fileURLToPath } from 'node:url'
-import chokidar from 'chokidar'
-
 import path from 'node:path'
+import { fileURLToPath } from 'node:url'
 import { parentPort } from 'node:worker_threads'
+import chokidar from 'chokidar'
 import { Checker } from '../../Checker.js'
 import { FileDiagnosticManager } from '../../FileDiagnosticManager.js'
 import {

diff --git a/playground/biome-default/__tests__/__snapshots__/test.spec.ts.snap b/playground/biome-default/__tests__/__snapshots__/test.spec.ts.snap
@@ -27,30 +27,11 @@ exports[`biome > serve > get initial error and subsequent error 2`] = `
 ]
 `;
 
-exports[`biome > serve > get initial error and subsequent error 3`] = `"[{"checkerId":"Biome","frame":"    1 | const a = 'hello'/n  > 2 | var b = 'world'/n      | ^^^^^^^^^^^^^^^/n    3 | const c = '!'/n    4 | var d = a + b + c/n    5 |","id":"<PROJECT_ROOT>/playground-temp/biome-default/src/index.js","level":1,"loc":{"column":1,"file":"<PROJECT_ROOT>/playground-temp/biome-default/src/index.js","line":2},"message":"[lint/style/noVar] Use let or const instead of var.","stack":""},{"checkerId":"Biome","frame":"    2 | var b = 'world'/n    3 | const c = '!'/n  > 4 | var d = a + b + c/n      | ^^^^^^^^^^^^^^^^^/n    5 |","id":"<PROJECT_ROOT>/playground-temp/biome-default/src/index.js","level":1,"loc":{"column":1,"file":"<PROJECT_ROOT>/playground-temp/biome-default/src/index.js","line":4},"message":"[lint/style/noVar] Use let or const instead of var.","stack":""},{"checkerId":"Biome","frame":"    2 | const b = 'world'/n    3 | const c = '!'/n  > 4 | var d = a + b + c/n      | ^^^^^^^^^^^^^^^^^/n    5 |","id":"<PROJECT_ROOT>/playground-temp/biome-default/src/index.js","level":1,"loc":{"column":1,"file":"<PROJECT_ROOT>/playground-temp/biome-default/src/index.js","line":4},"message":"[lint/style/noVar] Use let or const instead of var.","stack":""}]"`;
+exports[`biome > serve > get initial error and subsequent error 3`] = `"[{"checkerId":"Biome","frame":"    2 | const b = 'world'/n    3 | const c = '!'/n  > 4 | var d = a + b + c/n      | ^^^^^^^^^^^^^^^^^/n    5 |","id":"<PROJECT_ROOT>/playground-temp/biome-default/src/index.js","level":1,"loc":{"column":1,"file":"<PROJECT_ROOT>/playground-temp/biome-default/src/index.js","line":4},"message":"[lint/style/noVar] Use let or const instead of var.","stack":""}]"`;
 
 exports[`biome > serve > get initial error and subsequent error 4`] = `
 [
   " ERROR(Biome)  [lint/style/noVar] Use let or const instead of var.
- FILE  <PROJECT_ROOT>/playground-temp/biome-default/src/index.js:2:1
-
-    1 | const a = 'hello'
-  > 2 | var b = 'world'
-      | ^^^^^^^^^^^^^^^
-    3 | const c = '!'
-    4 | var d = a + b + c
-    5 |
-",
-  " ERROR(Biome)  [lint/style/noVar] Use let or const instead of var.
- FILE  <PROJECT_ROOT>/playground-temp/biome-default/src/index.js:4:1
-
-    2 | var b = 'world'
-    3 | const c = '!'
-  > 4 | var d = a + b + c
-      | ^^^^^^^^^^^^^^^^^
-    5 |
-",
-  " ERROR(Biome)  [lint/style/noVar] Use let or const instead of var.
  FILE  <PROJECT_ROOT>/playground-temp/biome-default/src/index.js:4:1
 
     2 | const b = 'world'
@@ -59,6 +40,6 @@ exports[`biome > serve > get initial error and subsequent error 4`] = `
       | ^^^^^^^^^^^^^^^^^
     5 |
 ",
-  "[Biome] Found 3 errors and 0 warning",
+  "[Biome] Found 1 error and 0 warning",
 ]
 `;