-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: compatibility with vue-tsc 2.x #327
Conversation
🦋 Changeset detectedLatest commit: ef0479f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for vite-plugin-checker ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
packages/vite-plugin-checker/src/checkers/vueTsc/languagePlugins.js
Outdated
Show resolved
Hide resolved
I checked the PR code and found |
Invalid back references breaks dts build, any thoughts? |
Just follow the new version of typescript's instruction and change to |
I suppose \x03 is hex while \3 is a back reference? |
I also found that import { text } from './text'
+ let count: string = 0
var hello = 'Hello'
const rootDom = document.querySelector('#root')!
rootDom.innerHTML = hello + text
export {}
import { defineConfig } from 'vite'
import checker from 'vite-plugin-checker'
export default defineConfig({
plugins: [
checker({
+ typescript: true,
eslint: {
lintCommand: 'eslint ./src --ext .ts',
},
}),
],
}) |
Guess we could |
@so1ve Could you help to check the Windows CI issue, it's relatively slow for me to test it on CI and I can't reach my Windows machine until next week. 🥺 |
関連のIssue: fi3ework/vite-plugin-checker#306 (comment) vuejs/language-tools#4484 一時的な回避案で、正式な修正は`vite-plugin-checker`のvue-tsc v2.x対応待ち fi3ework/vite-plugin-checker#327
Hi @fi3ework, I don't have enough time to work on windows tests recently, but I can work on this issue in two days. How about we merge this PR first, and then I will submit another PR to fix it? |
Sure, I'll merge this PR tonight (I'll try to fix the Windows CI one more time before that 🥲). |
GitHub is down https://www.githubstatus.com/incidents/9vwllhs2w1kj, I can't merge the PR right now. It's late tonight, I'll try to merge this PR tomorrow morning. ![]() |
@so1ve Thanks for the hard work, I really appreciate that. Looking forward to releasing this after fixing the left comment.
|
windows test seem to be failing due to jest-serializer-path normalization, path drive path is replaced with i created a PR, that hack "fixes" this issue #313 |
Hi @fi3ework, yes, we don't support ts 4. We rely on ts 5 specific apis. |
@so1ve Hmm, I'm wondering why peer dep is set |
Yeah, it would be better to point it to |
fixes #306, close #321
This is a naive fix - it may cause problems described in #306 (comment), but it will avoid crashes.I'm still working on a complete solution.Fixed, but requires installing@vue/language-core
as a dependency, which may cause version mismatch.Ran e2e tests locally and passed, the ci is failing due to d ts building issues and low nodejs version