Modified deepFreezeAndThrowOnMutationInDev to use Object.prototype.ha…

[dysonpro]

This PR fixes a bug in deepFreezeAndThrowOnMutationInDev which did not take into account that objects passed to it may have been created with Object.create(null) and thus may not have a prototype. Such objects don't have the methods hasOwnProperty, __defineGetter__, or __defineSetter__ on the instance.

I ran into an unrecoverable error in React Native when passing this type of object across the bridge because deepFreezeAndThrowOnMutationInDev attempts to call object.hasOwnProperty(key), object.__defineGetter__ and object__defineSetter__ on objects passed to it. But my object instance does not have these prototype methods.

Changes:

• Defined Object.prototype.hasOwnProperty as a const (pattern used elsewhere in React Native)
• Modified calls to object.hasOwnProperty(key) to use hasOwnProperty.call(object, key) (Per ESLint rule here)
• Modified calls to deprecated methods object.__defineGetter__ and object.__defineSetter__ to instead use Object.defineProperty to define get and set methods on the object. (Per guidance on MDN)
• Added a new test to deepFreezeAndThrowOnMutationInDev-test to verify the fix.

Test Plan

I tried to create a reproducible example to post to Snack by passing prototype-less objects to a Text component, in various ways, but they appear to be converted to plain objects before crossing the bridge and therefore they do not throw an error.

However, I was able to create a new test to reproduce the issue. I added the following test to deepFreezeAndThrowOnMutationInDev-test:

it('should not throw on object without prototype', () => {
    __DEV__ = true;
    var o = Object.create(null);
    o.key = 'Value';
    expect(() => deepFreezeAndThrowOnMutationInDev(o)).not.toThrow();
  });

The changes in this PR include this new test.

ESLint test produced no change in Error count (3) or Warnings (671)

Related PRs

N/A
Other areas with possibly the same issue:

react-native/Libraries/vendor/core/mergeInto.js

Line 50 in c6b96c0

if (!two.hasOwnProperty(key)) {

react-native/Libraries/ReactNative/requireNativeComponent.js

Line 134 in 8dc3ba0

if (!source.hasOwnProperty(key)) {

Release Notes

[GENERAL] [BUGFIX] [Libraries/Utilities/deepFreezeAndThrowOnMutationInDev] -Fix for compatibility with objects without a prototype.

[facebook-github-bot]

@TheSavior is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.