-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CLI]Add iOS Validate Environment Script #19750
Conversation
@hramos just checking in. Is their anything else you would like me to add to this? Thanks. |
@hgale I tried to find reviewers for this pull request and wanted to ping them to take another look. However, based on the blame information for the files in this pull request I couldn't find any reviewers. This sometimes happens when the files in the pull request are new or don't exist on master anymore. Is this pull request still relevant? If yes could you please rebase? In case you know who has context on this code feel free to mention them in a comment (one person is fine). Thanks for reading and hope you will continue contributing to the project. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
I tried to merge this pull request into the Facebook internal repo but some checks failed. To unblock yourself please check the following: Does this pull request pass all open source tests on GitHub? If not please fix those. Does the code still apply cleanly on top of GitHub master? If not can please rebase. In all other cases this means some internal test failed, for example a part of a fb app won't work with this pull request. I've added the Import Failed label to this pull request so it is easy for someone at fb to find the pull request and check what failed. If you don't see anyone comment in a few days feel free to comment mentioning one of the core contributors to the project so they get a notification. |
scripts/validate-ios-test-env.sh
Outdated
|
||
# Check that Xcode is installed. | ||
if [ -z "$(which xcodebuild)" ]; then | ||
echo "You need to install nodejs." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tihnk this is the wrong error message for xcodebuild
The import timed out last week. Trying again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
This pull request was closed by Harry Tormey in 1fb7a25. Once this commit is added to a release, you will see the corresponding version tag below the description at 1fb7a25. If the commit has a single |
Fixes #19694 this diff adds an iOS environment validation script as requested by @hramos.
A similar script for Android exists: scripts/validate-android-test-env.sh.
This script:
Validates that the minimum required Xcode version is installed (people using Xcode 8 with a recent release may encounter cryptic build errors).
Validates the correct Node version is installed (Node 10 is not fully supported at the time, Node 6 is no longer supported).
Test Plan
Run ./scripts/validate-ios-test-env.sh on a properly setup OSX machine and verify it works, change the version comparison and make sure it fails.
Related PRs
Release Notes
[INTERNAL] [ENHANCEMENT] [scripts] - Add iOS validate environment script