Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump versions for 17 #20062

Merged
merged 1 commit into from
Oct 20, 2020
Merged

Bump versions for 17 #20062

merged 1 commit into from
Oct 20, 2020

Conversation

gaearon
Copy link
Collaborator

@gaearon gaearon commented Oct 20, 2020

Just re-doing the same our script did on build + bumps a few more that are private but stale.
I changed peerDeps for React and ReactDOM to use an exact version of React. Kept it a caret in other places.

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Oct 20, 2020
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 8a385e4:

Sandbox Source
React Configuration

@sizebot
Copy link

sizebot commented Oct 20, 2020

No significant bundle size changes to report.

Size changes (experimental)

Generated by 🚫 dangerJS against 8a385e4

@sizebot
Copy link

sizebot commented Oct 20, 2020

No significant bundle size changes to report.

Size changes (stable)

Generated by 🚫 dangerJS against 8a385e4

@gaearon gaearon merged commit f021a98 into facebook:master Oct 20, 2020
@gaearon gaearon deleted the vbump branch October 20, 2020 20:41
jaydenseric
jaydenseric reviewed Oct 21, 2020
View reviewed changes
packages/eslint-plugin-react-hooks/package.json
"version": "4.1.2",
"version": "4.2.0",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What was the point of this eslint-plugin-react-hooks minor version bump, it appears there are no changes? Also, this new version was published without a changelog entry:

https://github.com/facebook/react/blob/master/packages/eslint-plugin-react-hooks/CHANGELOG.md

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No particular reason other than our release script releases all packages.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Edited changelog.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Such a script is undesirable. Millions of developers are needlessly updating a "outdated" dependency, looking around for a changelog entry (that doesn't exist) to explain the new semver minor features (that also don't exist).

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added the changelog entry. Your opinion is noted. This was a stressful release that took us many months, and I overlooked this detail. I'm sorry to hear you were frustrated by it.

@facebook facebook locked as resolved and limited conversation to collaborators Oct 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jaydenseric jaydenseric jaydenseric left review comments

@acdlite acdlite acdlite approved these changes

Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gaearon @sizebot @jaydenseric @acdlite @facebook-github-bot