Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

snapToInterval not implemented on android for vertical scroll view #19552

Closed
nuKs opened this issue Jun 4, 2018 · 1 comment
Closed

snapToInterval not implemented on android for vertical scroll view #19552

nuKs opened this issue Jun 4, 2018 · 1 comment
Labels
Platform: Android Android applications. Resolution: Locked This issue was locked by the bot.

Comments

@nuKs
Copy link

nuKs commented Jun 4, 2018 •
edited
Loading

Environment

OS: macOS High Sierra 10.13.4
Node: 9.11.1
Yarn: 1.0.2
npm: 5.6.0
Watchman: 4.9.0
Xcode: Xcode 9.2 Build version 9C40b
Android Studio: 3.1 AI-173.4720617

Packages: (wanted => installed)
react: [email protected] => 16.3.2
react-native: 0.55.0 => 0.55.0

Description

snapToInterval is not implemented on android for vertical scroll view.

react-native/Libraries/Components/ScrollView/ScrollView.js

Line 511 in 8dc3ba0

* Supported for horizontal scrollview on android.

The official doc states the feature is actually implemented.

https://facebook.github.io/react-native/docs/scrollview.html#snaptointerval
@react-native-bot react-native-bot added the Platform: Android Android applications. label Jun 4, 2018
grabbou pushed a commit that referenced this issue Aug 31, 2018
@olegbl @grabbou
ScrollView snapToOffsets
ef7e99c 
Summary:
* Added snapToOffsets prop to ScrollView. Allows snapping at arbitrary points.

* Fixed pagingEnabled not being overridden by snapToInterval on iOS.

* Fixed Android *requiring* pagingEnabled to be defined alongside snapToInterval.
* Added support for decelerationRate on Android.

* Fixed snapping implementation. It was not calculating end position correctly at all (velocity is not a linear offset).
  * Resolves #20155
* Added support for new content being added during scroll (mirrors existing functionality in vertical ScrollView).

* Added support for snapToInterval.
  * Resolves #19552

Reviewed By: yungsters

Differential Revision: D9405703

fbshipit-source-id: b3c367b8079e6810794b0165dfdbcff4abff2eda
gengjiawen pushed a commit to gengjiawen/react-native that referenced this issue Sep 14, 2018
@olegbl @gengjiawen
ScrollView snapToOffsets
3208f9f 
Summary:
* Added snapToOffsets prop to ScrollView. Allows snapping at arbitrary points.

* Fixed pagingEnabled not being overridden by snapToInterval on iOS.

* Fixed Android *requiring* pagingEnabled to be defined alongside snapToInterval.
* Added support for decelerationRate on Android.

* Fixed snapping implementation. It was not calculating end position correctly at all (velocity is not a linear offset).
  * Resolves facebook#20155
* Added support for new content being added during scroll (mirrors existing functionality in vertical ScrollView).

* Added support for snapToInterval.
  * Resolves facebook#19552

Reviewed By: yungsters

Differential Revision: D9405703

fbshipit-source-id: b3c367b8079e6810794b0165dfdbcff4abff2eda
aleclarson pushed a commit to aleclarson/react-native that referenced this issue Sep 16, 2018
@olegbl @aleclarson
ScrollView snapToOffsets
91a9e2f 
Summary:
* Added snapToOffsets prop to ScrollView. Allows snapping at arbitrary points.

* Fixed pagingEnabled not being overridden by snapToInterval on iOS.

* Fixed Android *requiring* pagingEnabled to be defined alongside snapToInterval.
* Added support for decelerationRate on Android.

* Fixed snapping implementation. It was not calculating end position correctly at all (velocity is not a linear offset).
  * Resolves facebook#20155
* Added support for new content being added during scroll (mirrors existing functionality in vertical ScrollView).

* Added support for snapToInterval.
  * Resolves facebook#19552

Reviewed By: yungsters

Differential Revision: D9405703

fbshipit-source-id: b3c367b8079e6810794b0165dfdbcff4abff2eda
@thecryptovalley
Copy link

How to merge the above commit to RN 0.56?

t-nanava pushed a commit to microsoft/react-native-macos that referenced this issue Jun 17, 2019
@olegbl @facebook-github-bot
ScrollView snapToOffsets
2bf7cd0 
Summary:
* Added snapToOffsets prop to ScrollView. Allows snapping at arbitrary points.

* Fixed pagingEnabled not being overridden by snapToInterval on iOS.

* Fixed Android *requiring* pagingEnabled to be defined alongside snapToInterval.
* Added support for decelerationRate on Android.

* Fixed snapping implementation. It was not calculating end position correctly at all (velocity is not a linear offset).
  * Resolves facebook#20155
* Added support for new content being added during scroll (mirrors existing functionality in vertical ScrollView).

* Added support for snapToInterval.
  * Resolves facebook#19552

Reviewed By: yungsters

Differential Revision: D9405703

fbshipit-source-id: b3c367b8079e6810794b0165dfdbcff4abff2eda
t-nanava pushed a commit to microsoft/react-native-macos that referenced this issue Jun 17, 2019
@olegbl @grabbou
ScrollView snapToOffsets
63f871d 
Summary:
* Added snapToOffsets prop to ScrollView. Allows snapping at arbitrary points.

* Fixed pagingEnabled not being overridden by snapToInterval on iOS.

* Fixed Android *requiring* pagingEnabled to be defined alongside snapToInterval.
* Added support for decelerationRate on Android.

* Fixed snapping implementation. It was not calculating end position correctly at all (velocity is not a linear offset).
  * Resolves facebook#20155
* Added support for new content being added during scroll (mirrors existing functionality in vertical ScrollView).

* Added support for snapToInterval.
  * Resolves facebook#19552

Reviewed By: yungsters

Differential Revision: D9405703

fbshipit-source-id: b3c367b8079e6810794b0165dfdbcff4abff2eda
@facebook facebook locked as resolved and limited conversation to collaborators Aug 30, 2019
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Aug 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Platform: Android Android applications. Resolution: Locked This issue was locked by the bot.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nuKs @react-native-bot @thecryptovalley