Updating Native Modules Documentation #2261

lauramedalia · 2020-10-20T02:35:10Z

To Do

Make Note wording consistent (Note: vs NOTE etc)
Constituency around what is code formatted or not (file names or data types for example)
Move synchronous methods to “beyond a calendar module” section?
FYI seperated side bar into 2 parts
Callback order

facebook-github-bot · 2020-10-20T02:35:17Z

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

charpeni · 2020-10-20T02:38:49Z

Deploy preview for react-native ready!

Built with commit 63dc05f

https://deploy-preview-2261--react-native.netlify.app

website/versioned_docs/version-0.63/native-modules-ios.md

docs/native-modules-android.md

docs/native-modules-ios.md

RSNara

Reviewed the iOS docs. Just a few minor suggestions! No correctness mistakes. Will take a look at Android soon.

RSNara · 2020-10-22T00:06:45Z

docs/native-modules-ios.md

-In addition to implementing the `RCTBridgeModule` protocol, your class must also include the `RCT_EXPORT_MODULE()` macro. This takes an optional argument that specifies the name that the module will be accessible as in your JavaScript code (more on this later). If you do not specify a name, the JavaScript module name will match the Objective-C class name. If the Objective-C class name begins with RCT, the JavaScript module name will exclude the RCT prefix.
+You can use any name that fits the native module you are building. Name the interface `RCTCalendarModule` since you are creating a calendar native module. Since ObjC does not have namespaces like Java or C++, convention is to prepend the interface name with a substring like RCT (an abbreviation or React).
+
+As you can see below, the CalendarModule interface implements the `RCTBridgeModule` protocol. A native module is an Objective-C class that implements the `RCTBridgeModule` protocol.


In this sentence, we use "interface" and "class" to refer to the thing. I wonder if this would confuse people, because they are two distinct concepts in general programming. Thoughts?

Forgot to respond, but yes nice call I updated this!

docs/native-modules-ios.md

RSNara · 2020-10-22T00:17:04Z

docs/native-modules-ios.md

-  'Birthday Party',
-  '4 Privet Drive, Surrey'
-);
+const { CalendarModuleFoo } = ReactNative.NativeModules;


I think there is some redundancy in this section. We mention the RCT_EXPORT_MODULE() macro and the fact that we can grab the NativeModule from ReactNative.NativeModules.CalendarModuleFoo twice. Maybe we could make this more succinct?

Just updated!

docs/native-modules-ios.md

RSNara · 2020-10-22T04:59:34Z

docs/native-modules-ios.md

+You can do this by creating a class that implements the `RCTBridgeDelegate` Protocol, initializing an `RCTBridge` with the delegate as an argument and initialising a `RCTRootView` with the initialized bridge.
+
+```objectivec
+id<RCTBridgeDelegate> moduleInitialiser = [[classThatImplementsRCTBridgeDelegate alloc] init];
+
+RCTBridge *bridge = [[RCTBridge alloc] initWithDelegate:moduleInitialiser launchOptions:nil];
+
+RCTRootView *rootView = [[RCTRootView alloc]
+                        initWithBridge:bridge
+                            moduleName:kModuleName
+                     initialProperties:nil];
+```


It feels like the message might be lost in the details. We want to say something like: If you want to create and initialize the native module (with custom arguments) yourself, leverage the RCTBridgeDelegate you pass into the React Native bridge. You can insert the initialized NativeModule into the array returned from RCTBridgeDelegate extraModulesForBridge, and React Native will expose that native module to JavaScript.

@RSNaraj just to confirm - do you want to replace the first 2 paragraphs in this section with that text?

docs/native-modules-ios.md

RSNara

Looks good! Left a few suggestions.

website/versioned_docs/version-0.63/native-modules-android.md

RSNara · 2020-10-22T20:32:24Z

website/versioned_docs/version-0.63/native-modules-android.md

+
+To date, on Android, all native module async methods execute on one thread. On iOS, each native module can provide its method queue, or have React Native generate a method queue for it. On iOS, native modules also have an API to get a hold of the method queue on which their async methods are executed.
+
+Native modules should not have any assumptions about what thread they are being called on, as the current assignment is subject to change in the future. If a blocking call is required, the heavy work should be dispatched to an internally managed worker thread, and any callbacks distributed from there.


It looks like we don't mention the invalidate Android analogue. In Java, NativeModules can have a onCatalystInstanceDestroy() method that they can implement to do cleanup of any resources they own. There's also an initialize method: https://github.com/facebook/react-native/blob/ae418b83c071d27d1a5bc7dcb46d546686bd21b8/ReactAndroid/src/main/java/com/facebook/react/bridge/NativeModule.java#L40-L51.

@RSNara I ended up removing the notes about iOS here. Do you want to add this info about Android here?

website/versioned_docs/version-0.63/native-modules-android.md

RSNara · 2020-10-22T21:28:14Z

website/versioned_docs/version-0.63/native-modules-android.md


-The last step within Java is to register the Module; this happens in the `createNativeModules` of your apps package. If a module is not registered it will not be available from JavaScript.
+Once a native module is written, it needs to be registered with React Native. In order to do so, you need to add your native module to a `ReactPackage` and register the `ReactPackage` with React Native. During initialization, React Native will loop over all packages, and for each `ReactPackage`, register each native module within.


register each native module within.

After reading this, I'm left wondering what it means to register a NativeModule with React Native. Maybe we should elaborate on this. What we're really doing is making each NativeModule available to JavaScript code.

Edit: Looks like we already talk about this down the line.

website/versioned_docs/version-0.63/native-modules-android.md

Co-authored-by: Ramanpreet Nara <[email protected]>

…native-website into native-modules-edits

docs/native-modules-android.md

website/i18n/en.json

Simek

Thank you for this contribution, that's a great improvement! 👏

Please address the the minor issues from the comments above 🙂

website/versioned_docs/version-0.60/native-modules-intro.md

website/versioned_docs/version-0.63/native-modules-intro.md

… its not needed but it should no longer exist in docusouras V2 (i18n will be added in the future)

lauramedalia · 2020-11-28T03:03:33Z

Yes! I love this idea. We had chatted about adding a section at the beginning as well that noted what turbo modules is. I am happy with either/or but would love a partner to come up with the summary. Maybe something like the following as a note at the beginning of the Android/iOS docs?

The React Native team is currently working on a re-architecture of the NativeModule system. This new system is called TurboModules, and it will help facilitate more efficient type-safe communication between JavaScript and native, without relying on the React Native bridge. It will also enable new extensions that weren't possible with the legacy NativeModule system. You can read more about it here. Throughout these docs we have added notes around parts of Native Modules that will change in the TurboModules release and how you can best prepare for a smooth upgrade to TurboModules.

@RSNara where was the "here" supposed to link to? I see in a release doc you linked to here - is this what you intended (I've linked to that for now)? react-native-community/discussions-and-proposals#40

lauramedalia · 2020-11-28T04:51:17Z

Thank you for this contribution, that's a great improvement! 👏

Please address the the minor issues from the comments above 🙂

@Simek addressed feedback, LMK if it looks good!

Simek · 2020-12-02T00:27:51Z

@lauramedalia Thank you so much for the updates! 👍

I have left one more question about the types table in non-collapsed comment above. Other than that this changeset LGTM!

Hope that other reviewers (@rachelnabors, @RSNara) are also happy about the changes. 😉

rachelnabors

Thanks so much for working so hard on these, @lauramedalia, and thank you for your editing @Simek! This looks good from here. Let's get it into the site :)

rachelnabors · 2020-12-03T16:37:35Z

PARTY!

commit 82142cc Merge: 38be89c aa97a8f Author: sunnylqm <[email protected]> Date: Mon Dec 7 17:10:40 2020 +0800 Merge branch 'master' of https://github.com/facebook/react-native-website into facebook-master # Conflicts: # website/core/Footer.js commit 38be89c Merge: 0d9a929 bcb8a3d Author: Sunny Luo <[email protected]> Date: Mon Dec 7 16:46:37 2020 +0800 Merge pull request #315 from noah227/production 做了一些调整 commit bcb8a3d Author: Sunny Luo <[email protected]> Date: Mon Dec 7 15:47:32 2020 +0800 Update pressable.md commit 0d9a929 Merge: e9c11c0 d959587 Author: Sunny Luo <[email protected]> Date: Mon Dec 7 15:14:38 2020 +0800 Merge pull request #316 from hqwlkj/patch-4 Update typescript.md commit d959587 Author: Yanghc <[email protected]> Date: Mon Dec 7 15:02:20 2020 +0800 Update typescript.md commit 21eeb45 Author: noah227 <[email protected]> Date: Mon Dec 7 12:10:33 2020 +0800 commit e9c11c0 Merge: 3ebae53 dbac391 Author: Sunny Luo <[email protected]> Date: Mon Dec 7 11:10:45 2020 +0800 Merge pull request #309 from noah227/production cndocs pressable translation(partially) commit dbac391 Author: Sunny Luo <[email protected]> Date: Mon Dec 7 11:06:28 2020 +0800 Update pressable.md commit aa97a8f Author: Ray Holland <[email protected]> Date: Sat Dec 5 17:06:02 2020 -0600 Update drawerlayoutandroid.md (facebook#2342) * Update drawerlayoutandroid.md More detailed example of how to use openDrawer and closeDrawer * revert changes, update snack example, update base docs Co-authored-by: Bartosz Kaszubowski <[email protected]> commit 92f92be Author: Ilya Zarembsky <[email protected]> Date: Sat Dec 5 17:22:46 2020 -0500 Recommend Node be installed via nvm-windows (facebook#2312) * Recommend Node be installed via nvm-windows By installing Node via nvm-windows instead of directly, users will be able to easily switch between the multiple different versions of Node that their various projects may require. * Pacify language linter * convert nvm addition to separate paragraph, update base docs * revert change in versioned docs Co-authored-by: Ilya Zarembsky <[email protected]> Co-authored-by: Bartosz Kaszubowski <[email protected]> commit e50d8a4 Author: Bartosz Kaszubowski <[email protected]> Date: Sat Dec 5 22:54:33 2020 +0100 fix few Lighthouse warnings, remove old Footer file (facebook#2371) commit ecd6041 Author: Bartosz Kaszubowski <[email protected]> Date: Sat Dec 5 20:44:50 2020 +0100 update Share, Shadow and View Props pages to match latest patterns (facebook#2370) commit 03eb786 Author: Luis Miguel Alvarado <[email protected]> Date: Sat Dec 5 14:13:36 2020 -0400 [docs]: Add 0.64 required updates to the documentation - Part 1/x (facebook#2368) * Add support for shadowColor on Android >= 28 * Add support to image progress event on Android * ScrollView now supports contentOffset in Android * Add showSoftInputOnFocus to TextInput on iOS * Removed DEPRECATED_sendUpdatedChildFrames prop from ScrollView * Added unstable_pressDelay prop to Pressable * Apply suggested changes commit 0ad8af3 Author: Bartosz Kaszubowski <[email protected]> Date: Sat Dec 5 14:57:59 2020 +0100 add loading param to remark-snackplayer plugin (facebook#2367) commit 3e30040 Author: Magnus Brattlöf <[email protected]> Date: Sat Dec 5 14:57:42 2020 +0100 Extends and class are no longer part of the example code 'above'. Add… (facebook#2366) * Extends and class are no longer part of the example code 'above'. Added the arrow function as an additional example * use fix from the current docs Co-authored-by: Bartosz Kaszubowski <[email protected]> commit 48e2417 Author: Xuan Huang (黄玄) <[email protected]> Date: Fri Dec 4 09:12:36 2020 -0800 Update hermes.md to include RN compatibility (facebook#2361) * Update hermes.md to include RN compatibility Hermes works more reliably following the versions explicitly documented in its releases page. This is suggested by the community at facebook/hermes#33 (comment) * port the addition to the base docs Co-authored-by: Bartosz Kaszubowski <[email protected]> commit 3c72887 Author: Xuan Huang (黄玄) <[email protected]> Date: Fri Dec 4 08:18:34 2020 -0800 Update hermes.md to explain debugging on Hermes (facebook#2360) * Update hermes.md to explain debugging on Hermes This has been a frequently source of confusion. See facebook/hermes#48 (comment) for an example. * fix link format, update base docs * add missing tweak to base docs Co-authored-by: Bartosz Kaszubowski <[email protected]> commit c5f95fa Author: Bartosz Kaszubowski <[email protected]> Date: Thu Dec 3 19:19:36 2020 +0100 fix "Javascript" capitalization typo across all docs (facebook#2365) commit 572843a Author: Moti Zilberman <[email protected]> Date: Thu Dec 3 17:50:57 2020 +0000 Javascript->JavaScript in native-modules-intro (facebook#2364) Capitalisation fix. commit 1e82527 Author: lauramedalia <[email protected]> Date: Thu Dec 3 10:01:42 2020 -0500 Updating Native Modules Documentation (facebook#2261) * feat: updating Native Modules docs * feat: update native modules documentation (missed the docs changes) * converting nativemodules to native modules * language lint tweaks * Update docs/native-modules-ios.md * feat: apply code review comments that needed grammer. changes * feat: updating intro * feat: apply comment changes * feat: remove () from method names * feat: cleaning up docs/responding to comments * feat: adding the new titles to the original docs * feat: updating base doc title * feat: cleaning up notes and removing references to other mobile platforms in mobile platform docs * feat: updating some we's to you's * pulling direct manipulation out * fixing some outstanding yous and wes * updating these to new titles * move ios/android native components section under native components * Adding platform agnostic note back (it was removed when removing content related to iOS from this androids section) * fixing an out of date link to the getting started guides * correcting link * adding turbomodules note * adding parentheses for method names * native module consistency * editing run ios/android commands * using correct code block for java * removing this file, must have stuck around after a merge conflict but its not needed but it should no longer exist in docusouras V2 (i18n will be added in the future) * only editing in 0.63 moving forward * original_id is not needed * cleaning up white space * using correct Apostrophe characters * moving argument types to a table * adding note about where we are adding the method * adding a link to info on turbo modules Co-authored-by: lauramedalia <[email protected]> Co-authored-by: Ramanpreet Nara <[email protected]> commit bfe4f83 Author: Bartosz Kaszubowski <[email protected]> Date: Thu Dec 3 11:25:03 2020 +0100 refreshed FB OSS logo, footer and menu small UI tweaks (facebook#2362) commit 3ebae53 Author: sunnylqm <[email protected]> Date: Thu Dec 3 16:28:49 2020 +0800 Trigger update commit feb0d32 Author: Ben McDonald <[email protected]> Date: Thu Dec 3 02:00:26 2020 -0500 Update intro-react-native-components.md (facebook#2363) Small typo. A grammatical fix. commit 7d6a964 Author: Harsh Thakkar <[email protected]> Date: Wed Dec 2 05:44:52 2020 +0530 Installation word spelling mistake (facebook#2353) * Installation word spelling mistake * fix remaining "intallation" typos Co-authored-by: Bartosz Kaszubowski <[email protected]> commit f3ee2ef Author: Jessica Lin <[email protected]> Date: Tue Dec 1 15:39:30 2020 -0800 Add Call of Duty Companion App, NerdWallet, Foreca, LendMN, and FlipKart into showcase (facebook#2344) * Add Call of Duty Companion App and NerdWallet into showcase * Move Discord up on showcase * Add FlipKart, Foreca, LendMN to showcase commit dcfcda3 Author: Bartosz Kaszubowski <[email protected]> Date: Mon Nov 30 14:00:44 2020 +0100 add simple React Native logo animation (facebook#2339) commit 2354d56 Author: Bartosz Kaszubowski <[email protected]> Date: Mon Nov 30 13:58:44 2020 +0100 small tweaks for the docs sidebar (facebook#2359) commit 87fa863 Author: Bartosz Kaszubowski <[email protected]> Date: Mon Nov 30 13:17:45 2020 +0100 add temporary fix for navbar overflow issue (facebook#2358) * add temporary fix for navbar overflow issue * small tweak commit 572f7a7 Author: noah227 <[email protected]> Date: Sun Nov 29 19:03:47 2020 +0800 pressable.md 翻译（不完全）小调整 commit 267770c Author: noah227 <[email protected]> Date: Sun Nov 29 18:49:13 2020 +0800 pressable.md 翻译细微调整 commit 53c6718 Author: noah227 <[email protected]> Date: Sun Nov 29 18:38:51 2020 +0800 most part translated. commit 27a3372 Author: luism3861 <[email protected]> Date: Fri Nov 27 13:10:22 2020 -0600 update link name in MaskedViewIOS (facebook#2354) Co-authored-by: luism3861 <[email protected]> commit e73993f Author: Khalid Magdy Khalil <[email protected]> Date: Fri Nov 27 21:06:31 2020 +0200 Update running-on-device.md (facebook#2357) * Update running-on-device.md Remove the parts that mention xip.io since it's no longer used. facebook/react-native@40a8434#diff-0eeea47fa4bace26fa6c492a03fa0ea3923a2d8d54b7894f7760cb9131ab65eb * Update running-on-device.md commit 2f651e4 Author: HenokT <[email protected]> Date: Thu Nov 26 19:56:42 2020 +0300 Minor grammar correction to tutorial.md (facebook#2351) * Update tutorial.md * Update tutorial.md for version-0.62

* Init * Squashed commit of the following: commit 82142cc Merge: 38be89c aa97a8f Author: sunnylqm <[email protected]> Date: Mon Dec 7 17:10:40 2020 +0800 Merge branch 'master' of https://github.com/facebook/react-native-website into facebook-master # Conflicts: # website/core/Footer.js commit 38be89c Merge: 0d9a929 bcb8a3d Author: Sunny Luo <[email protected]> Date: Mon Dec 7 16:46:37 2020 +0800 Merge pull request #315 from noah227/production 做了一些调整 commit bcb8a3d Author: Sunny Luo <[email protected]> Date: Mon Dec 7 15:47:32 2020 +0800 Update pressable.md commit 0d9a929 Merge: e9c11c0 d959587 Author: Sunny Luo <[email protected]> Date: Mon Dec 7 15:14:38 2020 +0800 Merge pull request #316 from hqwlkj/patch-4 Update typescript.md commit d959587 Author: Yanghc <[email protected]> Date: Mon Dec 7 15:02:20 2020 +0800 Update typescript.md commit 21eeb45 Author: noah227 <[email protected]> Date: Mon Dec 7 12:10:33 2020 +0800 commit e9c11c0 Merge: 3ebae53 dbac391 Author: Sunny Luo <[email protected]> Date: Mon Dec 7 11:10:45 2020 +0800 Merge pull request #309 from noah227/production cndocs pressable translation(partially) commit dbac391 Author: Sunny Luo <[email protected]> Date: Mon Dec 7 11:06:28 2020 +0800 Update pressable.md commit aa97a8f Author: Ray Holland <[email protected]> Date: Sat Dec 5 17:06:02 2020 -0600 Update drawerlayoutandroid.md (facebook#2342) * Update drawerlayoutandroid.md More detailed example of how to use openDrawer and closeDrawer * revert changes, update snack example, update base docs Co-authored-by: Bartosz Kaszubowski <[email protected]> commit 92f92be Author: Ilya Zarembsky <[email protected]> Date: Sat Dec 5 17:22:46 2020 -0500 Recommend Node be installed via nvm-windows (facebook#2312) * Recommend Node be installed via nvm-windows By installing Node via nvm-windows instead of directly, users will be able to easily switch between the multiple different versions of Node that their various projects may require. * Pacify language linter * convert nvm addition to separate paragraph, update base docs * revert change in versioned docs Co-authored-by: Ilya Zarembsky <[email protected]> Co-authored-by: Bartosz Kaszubowski <[email protected]> commit e50d8a4 Author: Bartosz Kaszubowski <[email protected]> Date: Sat Dec 5 22:54:33 2020 +0100 fix few Lighthouse warnings, remove old Footer file (facebook#2371) commit ecd6041 Author: Bartosz Kaszubowski <[email protected]> Date: Sat Dec 5 20:44:50 2020 +0100 update Share, Shadow and View Props pages to match latest patterns (facebook#2370) commit 03eb786 Author: Luis Miguel Alvarado <[email protected]> Date: Sat Dec 5 14:13:36 2020 -0400 [docs]: Add 0.64 required updates to the documentation - Part 1/x (facebook#2368) * Add support for shadowColor on Android >= 28 * Add support to image progress event on Android * ScrollView now supports contentOffset in Android * Add showSoftInputOnFocus to TextInput on iOS * Removed DEPRECATED_sendUpdatedChildFrames prop from ScrollView * Added unstable_pressDelay prop to Pressable * Apply suggested changes commit 0ad8af3 Author: Bartosz Kaszubowski <[email protected]> Date: Sat Dec 5 14:57:59 2020 +0100 add loading param to remark-snackplayer plugin (facebook#2367) commit 3e30040 Author: Magnus Brattlöf <[email protected]> Date: Sat Dec 5 14:57:42 2020 +0100 Extends and class are no longer part of the example code 'above'. Add… (facebook#2366) * Extends and class are no longer part of the example code 'above'. Added the arrow function as an additional example * use fix from the current docs Co-authored-by: Bartosz Kaszubowski <[email protected]> commit 48e2417 Author: Xuan Huang (黄玄) <[email protected]> Date: Fri Dec 4 09:12:36 2020 -0800 Update hermes.md to include RN compatibility (facebook#2361) * Update hermes.md to include RN compatibility Hermes works more reliably following the versions explicitly documented in its releases page. This is suggested by the community at facebook/hermes#33 (comment) * port the addition to the base docs Co-authored-by: Bartosz Kaszubowski <[email protected]> commit 3c72887 Author: Xuan Huang (黄玄) <[email protected]> Date: Fri Dec 4 08:18:34 2020 -0800 Update hermes.md to explain debugging on Hermes (facebook#2360) * Update hermes.md to explain debugging on Hermes This has been a frequently source of confusion. See facebook/hermes#48 (comment) for an example. * fix link format, update base docs * add missing tweak to base docs Co-authored-by: Bartosz Kaszubowski <[email protected]> commit c5f95fa Author: Bartosz Kaszubowski <[email protected]> Date: Thu Dec 3 19:19:36 2020 +0100 fix "Javascript" capitalization typo across all docs (facebook#2365) commit 572843a Author: Moti Zilberman <[email protected]> Date: Thu Dec 3 17:50:57 2020 +0000 Javascript->JavaScript in native-modules-intro (facebook#2364) Capitalisation fix. commit 1e82527 Author: lauramedalia <[email protected]> Date: Thu Dec 3 10:01:42 2020 -0500 Updating Native Modules Documentation (facebook#2261) * feat: updating Native Modules docs * feat: update native modules documentation (missed the docs changes) * converting nativemodules to native modules * language lint tweaks * Update docs/native-modules-ios.md * feat: apply code review comments that needed grammer. changes * feat: updating intro * feat: apply comment changes * feat: remove () from method names * feat: cleaning up docs/responding to comments * feat: adding the new titles to the original docs * feat: updating base doc title * feat: cleaning up notes and removing references to other mobile platforms in mobile platform docs * feat: updating some we's to you's * pulling direct manipulation out * fixing some outstanding yous and wes * updating these to new titles * move ios/android native components section under native components * Adding platform agnostic note back (it was removed when removing content related to iOS from this androids section) * fixing an out of date link to the getting started guides * correcting link * adding turbomodules note * adding parentheses for method names * native module consistency * editing run ios/android commands * using correct code block for java * removing this file, must have stuck around after a merge conflict but its not needed but it should no longer exist in docusouras V2 (i18n will be added in the future) * only editing in 0.63 moving forward * original_id is not needed * cleaning up white space * using correct Apostrophe characters * moving argument types to a table * adding note about where we are adding the method * adding a link to info on turbo modules Co-authored-by: lauramedalia <[email protected]> Co-authored-by: Ramanpreet Nara <[email protected]> commit bfe4f83 Author: Bartosz Kaszubowski <[email protected]> Date: Thu Dec 3 11:25:03 2020 +0100 refreshed FB OSS logo, footer and menu small UI tweaks (facebook#2362) commit 3ebae53 Author: sunnylqm <[email protected]> Date: Thu Dec 3 16:28:49 2020 +0800 Trigger update commit feb0d32 Author: Ben McDonald <[email protected]> Date: Thu Dec 3 02:00:26 2020 -0500 Update intro-react-native-components.md (facebook#2363) Small typo. A grammatical fix. commit 7d6a964 Author: Harsh Thakkar <[email protected]> Date: Wed Dec 2 05:44:52 2020 +0530 Installation word spelling mistake (facebook#2353) * Installation word spelling mistake * fix remaining "intallation" typos Co-authored-by: Bartosz Kaszubowski <[email protected]> commit f3ee2ef Author: Jessica Lin <[email protected]> Date: Tue Dec 1 15:39:30 2020 -0800 Add Call of Duty Companion App, NerdWallet, Foreca, LendMN, and FlipKart into showcase (facebook#2344) * Add Call of Duty Companion App and NerdWallet into showcase * Move Discord up on showcase * Add FlipKart, Foreca, LendMN to showcase commit dcfcda3 Author: Bartosz Kaszubowski <[email protected]> Date: Mon Nov 30 14:00:44 2020 +0100 add simple React Native logo animation (facebook#2339) commit 2354d56 Author: Bartosz Kaszubowski <[email protected]> Date: Mon Nov 30 13:58:44 2020 +0100 small tweaks for the docs sidebar (facebook#2359) commit 87fa863 Author: Bartosz Kaszubowski <[email protected]> Date: Mon Nov 30 13:17:45 2020 +0100 add temporary fix for navbar overflow issue (facebook#2358) * add temporary fix for navbar overflow issue * small tweak commit 572f7a7 Author: noah227 <[email protected]> Date: Sun Nov 29 19:03:47 2020 +0800 pressable.md 翻译（不完全）小调整 commit 267770c Author: noah227 <[email protected]> Date: Sun Nov 29 18:49:13 2020 +0800 pressable.md 翻译细微调整 commit 53c6718 Author: noah227 <[email protected]> Date: Sun Nov 29 18:38:51 2020 +0800 most part translated. commit 27a3372 Author: luism3861 <[email protected]> Date: Fri Nov 27 13:10:22 2020 -0600 update link name in MaskedViewIOS (facebook#2354) Co-authored-by: luism3861 <[email protected]> commit e73993f Author: Khalid Magdy Khalil <[email protected]> Date: Fri Nov 27 21:06:31 2020 +0200 Update running-on-device.md (facebook#2357) * Update running-on-device.md Remove the parts that mention xip.io since it's no longer used. facebook/react-native@40a8434#diff-0eeea47fa4bace26fa6c492a03fa0ea3923a2d8d54b7894f7760cb9131ab65eb * Update running-on-device.md commit 2f651e4 Author: HenokT <[email protected]> Date: Thu Nov 26 19:56:42 2020 +0300 Minor grammar correction to tutorial.md (facebook#2351) * Update tutorial.md * Update tutorial.md for version-0.62 * Update * Update prettier * Update security * WIP * Update * Add sponsor and remove old doc * Update * Update * Update * Update * Fix environment setting * Update integration * Update integration * Update integration * Update tabs * Archive doc * Update index * Update introduction * Fix docs * Update docusaurus * Update github action

feat: updating Native Modules docs

e87ce68

laurajohannet added 3 commits October 19, 2020 22:50

feat: update native modules documentation (missed the docs changes)

0d0d3b7

converting nativemodules to native modules

fc827e7

language lint tweaks

159e0c1

lauramedalia commented Oct 20, 2020

View reviewed changes

website/versioned_docs/version-0.63/native-modules-ios.md Outdated Show resolved Hide resolved

RSNara reviewed Oct 21, 2020

View reviewed changes

docs/native-modules-android.md Outdated Show resolved Hide resolved

RSNara reviewed Oct 22, 2020

View reviewed changes

docs/native-modules-ios.md Outdated Show resolved Hide resolved

RSNara reviewed Oct 22, 2020

View reviewed changes

facebook-github-bot added the CLA Signed label Oct 23, 2020

lauramedalia and others added 17 commits October 22, 2020 21:33

Update docs/native-modules-ios.md

bfbfad1

Co-authored-by: Ramanpreet Nara <[email protected]>

Update website/versioned_docs/version-0.63/native-modules-android.md

0e75f3c

Co-authored-by: Ramanpreet Nara <[email protected]>

Update docs/native-modules-ios.md

c3b77f2

Co-authored-by: Ramanpreet Nara <[email protected]>

Update docs/native-modules-ios.md

7355271

Co-authored-by: Ramanpreet Nara <[email protected]>

Update docs/native-modules-ios.md

dcf1d80

Co-authored-by: Ramanpreet Nara <[email protected]>

Update docs/native-modules-ios.md

0ec1384

Co-authored-by: Ramanpreet Nara <[email protected]>

Update docs/native-modules-ios.md

e4c9890

Co-authored-by: Ramanpreet Nara <[email protected]>

Apply suggestions from code review

09f357e

Co-authored-by: Ramanpreet Nara <[email protected]>

Apply suggestions from code review (android)

a259813

Co-authored-by: Ramanpreet Nara <[email protected]>

feat: apply code review comments that needed grammer. changes

ac8517a

Merge branch 'native-modules-edits' of github.com:lauramedalia/react-…

ef92268

…native-website into native-modules-edits

feat: updating intro

408852a

feat: apply comment changes

909d133

feat: remove () from method names

4d69c24

feat: cleaning up docs/responding to comments

6b3a3d7

feat: adding the new titles to the original docs

bf32ead

feat: updating base doc title

911f2ab