Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Native UI Components Documentation #2206

Closed
MrGVSV opened this issue Sep 9, 2020 · 6 comments
Closed

Improve Native UI Components Documentation #2206

MrGVSV opened this issue Sep 9, 2020 · 6 comments
Labels
Stale Issues/PR that are not getting much activity and are closer to be closed

Comments

@MrGVSV
Copy link

MrGVSV commented Sep 9, 2020

Description

There is very little detail in the documentation for Native UI Components. The documentation should be updated for both iOS and Android to reflect the basics of what can be done.

Links: Android | iOS

What is the problem?

The documentation is very sparse when it comes to things like:

Creating Native UI Components in Swift

The documentation only explains how to create a UI Module in Objective-C. I can't speak for everyone, but I much prefer working in Swift. In order to understand how to create a bridge from React Native to Objective-C to Swift took many hours of reading through blog posts and forums. Unfortunately, the documentation on the React Native site only mentions Swift in the Native Modules section.

Implementing Commands in Android

There is no documentation for calling a Native View's method on Android via UIManager.dispatchViewManagerCommand. Furthermore, receiveCommand(@NonNull ITCameraView root, int commandId, @Nullable ReadableArray args) is deprecated, and there is no documentation on the updated version.

How can we address it?

Add to documentation to better illustrate how to implement a Native UI Component on both iOS and Android. Additionally, organize documentation subsections (e.g. renaming "Handling multiple native views" to "Calling native methods", etc.)

Why is it important?

Good documentation saves developers hours upon hours of time trying to solve an issue.

Who needs this?

Anyone who wants to create custom Native UI Components for their own projects or for plugins that spare others having to do so themselves.

When should this happen (use version numbers if needed)?

This is not a high priority issue, but could be addressed as soon as the current version (0.63).

@Simek
Copy link
Collaborator

Simek commented Sep 9, 2020

Refs #706, #1064, #1569, #1708, #2107 and more.

@betoharres
Copy link

betoharres commented Oct 31, 2020

I agree, and as a newbie that would like to start creating native modules to react-native on android:
Where's the imports? where should I search for such information? I'd like to contribute if at least I'd know where to look at :/
I don't get it why the person omitted such info; I'm scavenging popular repos just to copy/paste these things

I thing that it would be much easier and much better for newbies AND maintainers to just create an example repo showing off Native module and component UIs; people could even contribute directly to the repo by adding different types of examples, like the basics to gather video/audio data, etc... that'd be a game changer for react-native

@Simek
Copy link
Collaborator

Simek commented Dec 4, 2020

@MrGVSV, @betoharres please check out the updated Native Modules and Native Components guides pushed lately within #2261 PR:

I would like to know what you think about the pages after the update and if your previous issues has been addressed.

@betoharres
Copy link

@Simek Thanks a lot for updating the docs! It looks better now! I'll try to make a new ui module and give a better feedback here :)

@stale
Copy link

stale bot commented Jan 9, 2022

👋 Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale Issues/PR that are not getting much activity and are closer to be closed label Jan 9, 2022
@github-actions
Copy link

Closing this issue after a prolonged period of inactivity. If this issue is still present in the latest release, please feel free to create a new issue with up-to-date information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Stale Issues/PR that are not getting much activity and are closer to be closed
Projects
None yet
Development

No branches or pull requests

3 participants