Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React-Native app is more faster on remote debugging #48

Closed
carlosroberto555 opened this issue Jul 17, 2019 · 32 comments
Closed

React-Native app is more faster on remote debugging #48

carlosroberto555 opened this issue Jul 17, 2019 · 32 comments
Labels
need more info Awating additional info before proceeding question Further information is requested

Comments

@carlosroberto555
Copy link

I did start a app with rn 0.60.3 and enabled Hermes.
I did make a simple app using react-navigation with only 3 screens with two Buttons in all screens.
When I use JS Dev Mode with true or false my app is slow, and enable js minify is still slow.
But when I enable Remote JS Debugging the app is very faster, like a native only.

It's anything with the remote debugging for improve performance?

@mhorowitz
Copy link
Contributor

Can you describe your environment in more detail? In particular, are you running your app in a simulator (what kind?) or on device (what kind?)?

@mhorowitz mhorowitz added question Further information is requested need more info Awating additional info before proceeding and removed question Further information is requested labels Jul 17, 2019
@sontb
Copy link

sontb commented Jul 18, 2019

same here

@AlithAnar
Copy link

confirmed

@Inovassist-dev
Copy link

Yeah guys, same here...
Any idea of what can be happening?

@mhorowitz
Copy link
Contributor

Without more information on the environment you are running in, it's hard to say for certain. I would be interested in hearing about what android environment you are using, and what the actual measured times are. That said, I have a few general observations.

When you use Remote JS Debugging, the JavaScript does not run on your phone or simulator. It actually runs on Chrome running on your development machine (laptop or deskop). Your dev machine is likely many faster than a phone. Running in a simulator will likely perform better than a real device, but it still will not be as fast as a local non-simulated environment.

When you use Hermes in a production build, the bytecode is compiled in advance and can be executed quickly. When you use Hermes locally with Metro, Hermes is running in a lazy compilation mode. This is faster than compiling all the bytecode every time you reload from Metro, but slower than a production build. So slowness in dev mode does not necessarily means slowness in release mode. If Metro were able to compile bytecode one module at a time and deliver it incrementally to the device, this would probably help, but we don't have a plan to do this on our roadmap right now. This would be a great project for someone who wanted to help make Hermes work better in development environments.

@ca-beller
Copy link

Yeah I'm having the same issue as well.

@carlosroberto555
Copy link
Author

carlosroberto555 commented Jul 22, 2019

@mhorowitz this is a good explanation.
Makes all sense run faster when js code is runing on browser. It's faster like a fully native platform experience.
I did not tested production build yet, because I didn't had time, but I try tomorrow.
The results is with Hermes on, and I think with Hermes off more faster on config 1 and 2.

Configuration 1 (very slow)

JS Dev Mode: true
JS minify: false
Remote JS Debugging: false

Configuration 2 (slow)

JS Dev Mode: false
JS minify: true
Remote JS Debugging: false

Configuration 3 (inacreditable fast)

JS Dev Mode: true
JS minify: false
Remote JS Debugging: true

Configuration 4 (I think fast like config 3)

JS Dev Mode: false
JS minify: true
Remote JS Debugging: true

My device info:

Device: Moto G3
Processor: 1.4 GHz Quad Core
Android: 6.0
RAM: 1GB

More details on this technical page

@mhorowitz
Copy link
Contributor

mhorowitz commented Jul 22, 2019

@carlosroberto555 thanks for the additional detail. It's not surprising that Chrome running on your laptop is faster than Hermes running on a device first introduced four years ago. I would expect JS in Chrome on your laptop to be faster than any JS engine on this phone. Have you tried this with Remote JS Debugging disabled and Hermes disabled?

@carlosroberto555
Copy link
Author

Not yet, I'll try it tomorow too

@carlosroberto555
Copy link
Author

I don't had time on last week for test, but I got theese configurations without hermes:

Configuration 5 without hermes (faster than config 1 and 2)

JS Dev Mode: true
JS minify: false
Remote JS Debugging: false

Configuration 6 without hermes (I think fast like config 3 and 4)

JS Dev Mode: false
JS minify: true
Remote JS Debugging: false

Without hermes I had performance improvement Remote JS Debugging disabled.
When I have time for test, I'll compare with --variant=release for get more results.

@carlosroberto555
Copy link
Author

I've upgraded to from 0.60.3 to 0.60.4 and now configuration 2 seems a bit more fast

@tmikov
Copy link
Contributor

tmikov commented Jul 31, 2019

When #73 is done, it might improve things.

@RichardLindhout
Copy link

For me it's slower too on debug, any result @carlosroberto555 from variant release?

@carlosroberto555
Copy link
Author

@RichardLindhout I am working in another priorized project, but on this weekend I will try it

@RichardLindhout
Copy link

I'm trying it out a.t.m.

@RichardLindhout
Copy link

Wow definitely a lot faster, fastest version of my app I have ever seen!

@RichardLindhout
Copy link

I disabled hermes for now since the debug mode without remote debugging is too slow right know. Should not be a problem most of the time but the application I work on has some GPS features which I need to test outside. So connection breaks with the remote debugger ;)

@carlosroberto555
Copy link
Author

We are waiting for enhancement that @tmikov says above with debug performance improves.
If have to make continuous tests on app is more easy disable hermes until finish then.
Sorry if I talk confuse, I'm learning english yet haha

@Ashkan-Oliaie
Copy link

thanks so much for this issue :D , I've been crying all day trying to uninstall and install modules and debugging :D till I found out about Hermes low performance

@WoodyWoodsta
Copy link

I stand to be corrected, but when the remote debugger is connected, the app does not use the target device's JS engine, but rather the debugger's. So when connected to the React Native Debugger, the JS engine is not Hermes (unless I have categorically misunderstood how RN works!). This would explain the speedup when connected to the debugger.

@RichardLindhout
Copy link

@WoodyWoodsta That is correct for the old JSC, but with Hermes it's also Hermes in Chrome I think.

@RichardLindhout
Copy link

You're maybe right. I think I misunderstood some debugging things here: https://engineering.fb.com/android/hermes/

@mhorowitz
Copy link
Contributor

mhorowitz commented Aug 20, 2019

@WoodyWoodsta @RichardLindhout
If you use "Remote JS Debugging" you are getting a JS engine (v8) in Chrome. If you use Chrome's chrome://inspect mechanism to attach to Hermes, then you get Hermes. It is expected that the former will be faster than the latter. Your laptop is usually faster than your phone.

@WoodyWoodsta
Copy link

So if we use something like https://github.com/jhen0409/react-native-debugger, we're getting v8 as opposed to Hermes? (My guess is yes, since I've come across some actual differing behaviour between debugging/not-debugging in the past)

@mhorowitz
Copy link
Contributor

I'm not familiar with that particular tool, but based on the documentation, I believe you are correct.

@RichardLindhout
Copy link

If you turn off JS Dev Mode the performance is acceptable without disabling Hermes or using the remote debugging.

@JManuelMT-zz
Copy link

this is also happening to me in iPhone

@JManuelMT-zz
Copy link

Hey guys in my case the createLogger and composeWithDevTools was the problem, It seems is saturating the memory (in debug mode there is no problem because you are using JS engine (v8) in Chrome as @mhorowitz said), remove that for prod

@vitto-moz
Copy link

vitto-moz commented Sep 25, 2019

maybe the reason is that in case of using "Remote Debugging" you have Chrome V8 as a javascript engine

@jjhampton
Copy link

jjhampton commented Jan 28, 2020

I've also observed a significant slowdown when running my RN app (on Android or iOS) in development mode, on a device, without the remote debugging turned on.

To add on to @carlosroberto555's comments, when I add --minify=false to my Metro Bundler command, the app seems to run much faster than before.

Huxpro added a commit to Huxpro/react-native-website that referenced this issue Dec 1, 2020
This has been a frequently source of confusion. See facebook/hermes#48 (comment) for an example.
Simek added a commit to facebook/react-native-website that referenced this issue Dec 4, 2020
* Update hermes.md to explain debugging on Hermes 

This has been a frequently source of confusion. See facebook/hermes#48 (comment) for an example.

* fix link format, update base docs

* add missing tweak to base docs

Co-authored-by: Bartosz Kaszubowski <[email protected]>
sunnylqm added a commit to reactnativecn/react-native-website that referenced this issue Dec 7, 2020
commit 82142cc
Merge: 38be89c aa97a8f
Author: sunnylqm <[email protected]>
Date:   Mon Dec 7 17:10:40 2020 +0800

    Merge branch 'master' of https://github.com/facebook/react-native-website into facebook-master

    # Conflicts:
    #	website/core/Footer.js

commit 38be89c
Merge: 0d9a929 bcb8a3d
Author: Sunny Luo <[email protected]>
Date:   Mon Dec 7 16:46:37 2020 +0800

    Merge pull request #315 from noah227/production

    做了一些调整

commit bcb8a3d
Author: Sunny Luo <[email protected]>
Date:   Mon Dec 7 15:47:32 2020 +0800

    Update pressable.md

commit 0d9a929
Merge: e9c11c0 d959587
Author: Sunny Luo <[email protected]>
Date:   Mon Dec 7 15:14:38 2020 +0800

    Merge pull request #316 from hqwlkj/patch-4

    Update typescript.md

commit d959587
Author: Yanghc <[email protected]>
Date:   Mon Dec 7 15:02:20 2020 +0800

    Update typescript.md

commit 21eeb45
Author: noah227 <[email protected]>
Date:   Mon Dec 7 12:10:33 2020 +0800

commit e9c11c0
Merge: 3ebae53 dbac391
Author: Sunny Luo <[email protected]>
Date:   Mon Dec 7 11:10:45 2020 +0800

    Merge pull request #309 from noah227/production

    cndocs pressable translation(partially)

commit dbac391
Author: Sunny Luo <[email protected]>
Date:   Mon Dec 7 11:06:28 2020 +0800

    Update pressable.md

commit aa97a8f
Author: Ray Holland <[email protected]>
Date:   Sat Dec 5 17:06:02 2020 -0600

    Update drawerlayoutandroid.md (facebook#2342)

    * Update drawerlayoutandroid.md

    More detailed example of how to use openDrawer and closeDrawer

    * revert changes, update snack example, update base docs

    Co-authored-by: Bartosz Kaszubowski <[email protected]>

commit 92f92be
Author: Ilya Zarembsky <[email protected]>
Date:   Sat Dec 5 17:22:46 2020 -0500

    Recommend Node be installed via nvm-windows (facebook#2312)

    * Recommend Node be installed via nvm-windows

    By installing Node via nvm-windows instead of directly, users will be able to easily switch between the multiple different versions of Node that their various projects may require.

    * Pacify language linter

    * convert nvm addition to separate paragraph, update base docs

    * revert change in versioned docs

    Co-authored-by: Ilya Zarembsky <[email protected]>
    Co-authored-by: Bartosz Kaszubowski <[email protected]>

commit e50d8a4
Author: Bartosz Kaszubowski <[email protected]>
Date:   Sat Dec 5 22:54:33 2020 +0100

    fix few Lighthouse warnings, remove old Footer file (facebook#2371)

commit ecd6041
Author: Bartosz Kaszubowski <[email protected]>
Date:   Sat Dec 5 20:44:50 2020 +0100

    update Share, Shadow and View Props pages to match latest patterns (facebook#2370)

commit 03eb786
Author: Luis Miguel Alvarado <[email protected]>
Date:   Sat Dec 5 14:13:36 2020 -0400

    [docs]: Add 0.64 required updates to the documentation - Part 1/x (facebook#2368)

    * Add support for shadowColor on Android >= 28

    * Add support to image progress event on Android

    * ScrollView now supports contentOffset in Android

    * Add showSoftInputOnFocus to TextInput on iOS

    * Removed DEPRECATED_sendUpdatedChildFrames prop from ScrollView

    * Added unstable_pressDelay prop to Pressable

    * Apply suggested changes

commit 0ad8af3
Author: Bartosz Kaszubowski <[email protected]>
Date:   Sat Dec 5 14:57:59 2020 +0100

    add loading param to remark-snackplayer plugin (facebook#2367)

commit 3e30040
Author: Magnus Brattlöf <[email protected]>
Date:   Sat Dec 5 14:57:42 2020 +0100

    Extends and class are no longer part of the example code 'above'. Add… (facebook#2366)

    * Extends and class are no longer part of the example code 'above'. Added the arrow function as an additional example

    * use fix from the current docs

    Co-authored-by: Bartosz Kaszubowski <[email protected]>

commit 48e2417
Author: Xuan Huang (黄玄) <[email protected]>
Date:   Fri Dec 4 09:12:36 2020 -0800

    Update hermes.md to include RN compatibility (facebook#2361)

    * Update hermes.md to include RN compatibility

    Hermes works more reliably following the versions explicitly documented in its releases page.

    This is suggested by the community at facebook/hermes#33 (comment)

    * port the addition to the base docs

    Co-authored-by: Bartosz Kaszubowski <[email protected]>

commit 3c72887
Author: Xuan Huang (黄玄) <[email protected]>
Date:   Fri Dec 4 08:18:34 2020 -0800

    Update hermes.md to explain debugging on Hermes (facebook#2360)

    * Update hermes.md to explain debugging on Hermes

    This has been a frequently source of confusion. See facebook/hermes#48 (comment) for an example.

    * fix link format, update base docs

    * add missing tweak to base docs

    Co-authored-by: Bartosz Kaszubowski <[email protected]>

commit c5f95fa
Author: Bartosz Kaszubowski <[email protected]>
Date:   Thu Dec 3 19:19:36 2020 +0100

    fix "Javascript" capitalization typo across all docs (facebook#2365)

commit 572843a
Author: Moti Zilberman <[email protected]>
Date:   Thu Dec 3 17:50:57 2020 +0000

    Javascript->JavaScript in native-modules-intro (facebook#2364)

    Capitalisation fix.

commit 1e82527
Author: lauramedalia <[email protected]>
Date:   Thu Dec 3 10:01:42 2020 -0500

    Updating Native Modules Documentation (facebook#2261)

    * feat: updating Native Modules docs

    * feat: update native modules documentation (missed the docs changes)

    * converting nativemodules to native modules

    * language lint tweaks

    * Update docs/native-modules-ios.md

    * feat: apply code review comments that needed grammer. changes

    * feat: updating intro

    * feat: apply comment changes

    * feat: remove () from method names

    * feat: cleaning up docs/responding to comments

    * feat: adding the new titles to the original docs

    * feat: updating base doc title

    * feat:  cleaning up notes and removing references to other mobile platforms in mobile platform docs

    * feat: updating some we's to you's

    * pulling direct manipulation out

    * fixing some outstanding yous and wes

    * updating these to new titles

    * move ios/android native components section under native components

    * Adding platform agnostic note back (it was removed when removing content related to iOS from this androids section)

    * fixing an out of date link to the getting started guides

    * correcting link

    * adding turbomodules note

    * adding parentheses for method names

    * native module consistency

    * editing run ios/android commands

    * using correct code block for java

    * removing this file, must have stuck around after a merge conflict but its not needed but it should no longer exist in docusouras V2 (i18n will be added in the future)

    * only editing in 0.63 moving forward

    * original_id is not needed

    * cleaning up white space

    * using correct Apostrophe characters

    * moving argument types to a table

    * adding note about where we are adding the method

    * adding a link to info on turbo modules

    Co-authored-by: lauramedalia <[email protected]>
    Co-authored-by: Ramanpreet Nara <[email protected]>

commit bfe4f83
Author: Bartosz Kaszubowski <[email protected]>
Date:   Thu Dec 3 11:25:03 2020 +0100

    refreshed FB OSS logo, footer and menu small UI tweaks (facebook#2362)

commit 3ebae53
Author: sunnylqm <[email protected]>
Date:   Thu Dec 3 16:28:49 2020 +0800

    Trigger update

commit feb0d32
Author: Ben McDonald <[email protected]>
Date:   Thu Dec 3 02:00:26 2020 -0500

    Update intro-react-native-components.md (facebook#2363)

    Small typo.  A grammatical fix.

commit 7d6a964
Author: Harsh Thakkar <[email protected]>
Date:   Wed Dec 2 05:44:52 2020 +0530

    Installation word spelling mistake (facebook#2353)

    * Installation word spelling mistake

    * fix remaining "intallation" typos

    Co-authored-by: Bartosz Kaszubowski <[email protected]>

commit f3ee2ef
Author: Jessica Lin <[email protected]>
Date:   Tue Dec 1 15:39:30 2020 -0800

    Add Call of Duty Companion App, NerdWallet, Foreca, LendMN, and FlipKart into showcase (facebook#2344)

    * Add Call of Duty Companion App and NerdWallet into showcase

    * Move Discord up on showcase

    * Add FlipKart, Foreca, LendMN to showcase

commit dcfcda3
Author: Bartosz Kaszubowski <[email protected]>
Date:   Mon Nov 30 14:00:44 2020 +0100

    add simple React Native logo animation (facebook#2339)

commit 2354d56
Author: Bartosz Kaszubowski <[email protected]>
Date:   Mon Nov 30 13:58:44 2020 +0100

    small tweaks for the docs sidebar (facebook#2359)

commit 87fa863
Author: Bartosz Kaszubowski <[email protected]>
Date:   Mon Nov 30 13:17:45 2020 +0100

    add temporary fix for navbar overflow issue (facebook#2358)

    * add temporary fix for navbar overflow issue

    * small tweak

commit 572f7a7
Author: noah227 <[email protected]>
Date:   Sun Nov 29 19:03:47 2020 +0800

    pressable.md 翻译(不完全)小调整

commit 267770c
Author: noah227 <[email protected]>
Date:   Sun Nov 29 18:49:13 2020 +0800

    pressable.md 翻译细微调整

commit 53c6718
Author: noah227 <[email protected]>
Date:   Sun Nov 29 18:38:51 2020 +0800

    most part translated.

commit 27a3372
Author: luism3861 <[email protected]>
Date:   Fri Nov 27 13:10:22 2020 -0600

    update link name in MaskedViewIOS (facebook#2354)

    Co-authored-by: luism3861 <[email protected]>

commit e73993f
Author: Khalid Magdy Khalil <[email protected]>
Date:   Fri Nov 27 21:06:31 2020 +0200

    Update running-on-device.md (facebook#2357)

    * Update running-on-device.md

    Remove the parts that mention xip.io since it's no longer used.
    facebook/react-native@40a8434#diff-0eeea47fa4bace26fa6c492a03fa0ea3923a2d8d54b7894f7760cb9131ab65eb

    * Update running-on-device.md

commit 2f651e4
Author: HenokT <[email protected]>
Date:   Thu Nov 26 19:56:42 2020 +0300

    Minor grammar correction to tutorial.md (facebook#2351)

    * Update tutorial.md

    * Update tutorial.md for version-0.62
sunnylqm added a commit to reactnativecn/react-native-website that referenced this issue Dec 23, 2020
* Init

* Squashed commit of the following:

commit 82142cc
Merge: 38be89c aa97a8f
Author: sunnylqm <[email protected]>
Date:   Mon Dec 7 17:10:40 2020 +0800

    Merge branch 'master' of https://github.com/facebook/react-native-website into facebook-master

    # Conflicts:
    #	website/core/Footer.js

commit 38be89c
Merge: 0d9a929 bcb8a3d
Author: Sunny Luo <[email protected]>
Date:   Mon Dec 7 16:46:37 2020 +0800

    Merge pull request #315 from noah227/production

    做了一些调整

commit bcb8a3d
Author: Sunny Luo <[email protected]>
Date:   Mon Dec 7 15:47:32 2020 +0800

    Update pressable.md

commit 0d9a929
Merge: e9c11c0 d959587
Author: Sunny Luo <[email protected]>
Date:   Mon Dec 7 15:14:38 2020 +0800

    Merge pull request #316 from hqwlkj/patch-4

    Update typescript.md

commit d959587
Author: Yanghc <[email protected]>
Date:   Mon Dec 7 15:02:20 2020 +0800

    Update typescript.md

commit 21eeb45
Author: noah227 <[email protected]>
Date:   Mon Dec 7 12:10:33 2020 +0800

commit e9c11c0
Merge: 3ebae53 dbac391
Author: Sunny Luo <[email protected]>
Date:   Mon Dec 7 11:10:45 2020 +0800

    Merge pull request #309 from noah227/production

    cndocs pressable translation(partially)

commit dbac391
Author: Sunny Luo <[email protected]>
Date:   Mon Dec 7 11:06:28 2020 +0800

    Update pressable.md

commit aa97a8f
Author: Ray Holland <[email protected]>
Date:   Sat Dec 5 17:06:02 2020 -0600

    Update drawerlayoutandroid.md (facebook#2342)

    * Update drawerlayoutandroid.md

    More detailed example of how to use openDrawer and closeDrawer

    * revert changes, update snack example, update base docs

    Co-authored-by: Bartosz Kaszubowski <[email protected]>

commit 92f92be
Author: Ilya Zarembsky <[email protected]>
Date:   Sat Dec 5 17:22:46 2020 -0500

    Recommend Node be installed via nvm-windows (facebook#2312)

    * Recommend Node be installed via nvm-windows

    By installing Node via nvm-windows instead of directly, users will be able to easily switch between the multiple different versions of Node that their various projects may require.

    * Pacify language linter

    * convert nvm addition to separate paragraph, update base docs

    * revert change in versioned docs

    Co-authored-by: Ilya Zarembsky <[email protected]>
    Co-authored-by: Bartosz Kaszubowski <[email protected]>

commit e50d8a4
Author: Bartosz Kaszubowski <[email protected]>
Date:   Sat Dec 5 22:54:33 2020 +0100

    fix few Lighthouse warnings, remove old Footer file (facebook#2371)

commit ecd6041
Author: Bartosz Kaszubowski <[email protected]>
Date:   Sat Dec 5 20:44:50 2020 +0100

    update Share, Shadow and View Props pages to match latest patterns (facebook#2370)

commit 03eb786
Author: Luis Miguel Alvarado <[email protected]>
Date:   Sat Dec 5 14:13:36 2020 -0400

    [docs]: Add 0.64 required updates to the documentation - Part 1/x (facebook#2368)

    * Add support for shadowColor on Android >= 28

    * Add support to image progress event on Android

    * ScrollView now supports contentOffset in Android

    * Add showSoftInputOnFocus to TextInput on iOS

    * Removed DEPRECATED_sendUpdatedChildFrames prop from ScrollView

    * Added unstable_pressDelay prop to Pressable

    * Apply suggested changes

commit 0ad8af3
Author: Bartosz Kaszubowski <[email protected]>
Date:   Sat Dec 5 14:57:59 2020 +0100

    add loading param to remark-snackplayer plugin (facebook#2367)

commit 3e30040
Author: Magnus Brattlöf <[email protected]>
Date:   Sat Dec 5 14:57:42 2020 +0100

    Extends and class are no longer part of the example code 'above'. Add… (facebook#2366)

    * Extends and class are no longer part of the example code 'above'. Added the arrow function as an additional example

    * use fix from the current docs

    Co-authored-by: Bartosz Kaszubowski <[email protected]>

commit 48e2417
Author: Xuan Huang (黄玄) <[email protected]>
Date:   Fri Dec 4 09:12:36 2020 -0800

    Update hermes.md to include RN compatibility (facebook#2361)

    * Update hermes.md to include RN compatibility

    Hermes works more reliably following the versions explicitly documented in its releases page.

    This is suggested by the community at facebook/hermes#33 (comment)

    * port the addition to the base docs

    Co-authored-by: Bartosz Kaszubowski <[email protected]>

commit 3c72887
Author: Xuan Huang (黄玄) <[email protected]>
Date:   Fri Dec 4 08:18:34 2020 -0800

    Update hermes.md to explain debugging on Hermes (facebook#2360)

    * Update hermes.md to explain debugging on Hermes

    This has been a frequently source of confusion. See facebook/hermes#48 (comment) for an example.

    * fix link format, update base docs

    * add missing tweak to base docs

    Co-authored-by: Bartosz Kaszubowski <[email protected]>

commit c5f95fa
Author: Bartosz Kaszubowski <[email protected]>
Date:   Thu Dec 3 19:19:36 2020 +0100

    fix "Javascript" capitalization typo across all docs (facebook#2365)

commit 572843a
Author: Moti Zilberman <[email protected]>
Date:   Thu Dec 3 17:50:57 2020 +0000

    Javascript->JavaScript in native-modules-intro (facebook#2364)

    Capitalisation fix.

commit 1e82527
Author: lauramedalia <[email protected]>
Date:   Thu Dec 3 10:01:42 2020 -0500

    Updating Native Modules Documentation (facebook#2261)

    * feat: updating Native Modules docs

    * feat: update native modules documentation (missed the docs changes)

    * converting nativemodules to native modules

    * language lint tweaks

    * Update docs/native-modules-ios.md

    * feat: apply code review comments that needed grammer. changes

    * feat: updating intro

    * feat: apply comment changes

    * feat: remove () from method names

    * feat: cleaning up docs/responding to comments

    * feat: adding the new titles to the original docs

    * feat: updating base doc title

    * feat:  cleaning up notes and removing references to other mobile platforms in mobile platform docs

    * feat: updating some we's to you's

    * pulling direct manipulation out

    * fixing some outstanding yous and wes

    * updating these to new titles

    * move ios/android native components section under native components

    * Adding platform agnostic note back (it was removed when removing content related to iOS from this androids section)

    * fixing an out of date link to the getting started guides

    * correcting link

    * adding turbomodules note

    * adding parentheses for method names

    * native module consistency

    * editing run ios/android commands

    * using correct code block for java

    * removing this file, must have stuck around after a merge conflict but its not needed but it should no longer exist in docusouras V2 (i18n will be added in the future)

    * only editing in 0.63 moving forward

    * original_id is not needed

    * cleaning up white space

    * using correct Apostrophe characters

    * moving argument types to a table

    * adding note about where we are adding the method

    * adding a link to info on turbo modules

    Co-authored-by: lauramedalia <[email protected]>
    Co-authored-by: Ramanpreet Nara <[email protected]>

commit bfe4f83
Author: Bartosz Kaszubowski <[email protected]>
Date:   Thu Dec 3 11:25:03 2020 +0100

    refreshed FB OSS logo, footer and menu small UI tweaks (facebook#2362)

commit 3ebae53
Author: sunnylqm <[email protected]>
Date:   Thu Dec 3 16:28:49 2020 +0800

    Trigger update

commit feb0d32
Author: Ben McDonald <[email protected]>
Date:   Thu Dec 3 02:00:26 2020 -0500

    Update intro-react-native-components.md (facebook#2363)

    Small typo.  A grammatical fix.

commit 7d6a964
Author: Harsh Thakkar <[email protected]>
Date:   Wed Dec 2 05:44:52 2020 +0530

    Installation word spelling mistake (facebook#2353)

    * Installation word spelling mistake

    * fix remaining "intallation" typos

    Co-authored-by: Bartosz Kaszubowski <[email protected]>

commit f3ee2ef
Author: Jessica Lin <[email protected]>
Date:   Tue Dec 1 15:39:30 2020 -0800

    Add Call of Duty Companion App, NerdWallet, Foreca, LendMN, and FlipKart into showcase (facebook#2344)

    * Add Call of Duty Companion App and NerdWallet into showcase

    * Move Discord up on showcase

    * Add FlipKart, Foreca, LendMN to showcase

commit dcfcda3
Author: Bartosz Kaszubowski <[email protected]>
Date:   Mon Nov 30 14:00:44 2020 +0100

    add simple React Native logo animation (facebook#2339)

commit 2354d56
Author: Bartosz Kaszubowski <[email protected]>
Date:   Mon Nov 30 13:58:44 2020 +0100

    small tweaks for the docs sidebar (facebook#2359)

commit 87fa863
Author: Bartosz Kaszubowski <[email protected]>
Date:   Mon Nov 30 13:17:45 2020 +0100

    add temporary fix for navbar overflow issue (facebook#2358)

    * add temporary fix for navbar overflow issue

    * small tweak

commit 572f7a7
Author: noah227 <[email protected]>
Date:   Sun Nov 29 19:03:47 2020 +0800

    pressable.md 翻译(不完全)小调整

commit 267770c
Author: noah227 <[email protected]>
Date:   Sun Nov 29 18:49:13 2020 +0800

    pressable.md 翻译细微调整

commit 53c6718
Author: noah227 <[email protected]>
Date:   Sun Nov 29 18:38:51 2020 +0800

    most part translated.

commit 27a3372
Author: luism3861 <[email protected]>
Date:   Fri Nov 27 13:10:22 2020 -0600

    update link name in MaskedViewIOS (facebook#2354)

    Co-authored-by: luism3861 <[email protected]>

commit e73993f
Author: Khalid Magdy Khalil <[email protected]>
Date:   Fri Nov 27 21:06:31 2020 +0200

    Update running-on-device.md (facebook#2357)

    * Update running-on-device.md

    Remove the parts that mention xip.io since it's no longer used.
    facebook/react-native@40a8434#diff-0eeea47fa4bace26fa6c492a03fa0ea3923a2d8d54b7894f7760cb9131ab65eb

    * Update running-on-device.md

commit 2f651e4
Author: HenokT <[email protected]>
Date:   Thu Nov 26 19:56:42 2020 +0300

    Minor grammar correction to tutorial.md (facebook#2351)

    * Update tutorial.md

    * Update tutorial.md for version-0.62

* Update

* Update prettier

* Update security

* WIP

* Update

* Add sponsor and remove old doc

* Update

* Update

* Update

* Update

* Fix environment setting

* Update integration

* Update integration

* Update integration

* Update tabs

* Archive doc

* Update index

* Update introduction

* Fix docs

* Update docusaurus

* Update github action
@tapz
Copy link

tapz commented Feb 4, 2021

I just switched to a new development phone Samsung Galaxy A51 5G. My app runs EXTREMELY slowly under Hermes when using a debug version. It's almost impossible to use the app as the ui works so slowly. I have no idea what the debug mode causes Hermes to do under the hood as I'm not using a debugger and all I need in the debug mode is a proper stack trace. Maybe I just need to start developing in release mode as the debug mode in Hermes is totally useless.

facebook-github-bot pushed a commit that referenced this issue Feb 24, 2021
Summary:
Pushing tags against existing commits doesn't seem to trigger the action, so let's list releases here instead.

Docs for this in D26607139.

Pull Request resolved: facebookincubator/fbjni#48

Test Plan:
Ran it on my fork. It failed but because there were unclosed previous updates, which is in fact expected (and quite useful, too, because it means we don't have a stray release).

https://github.com/passy/fbjni/runs/1961026784?check_suite_focus=true

Reviewed By: nikoant

Differential Revision: D26583351

Pulled By: passy

fbshipit-source-id: 1eee0b8c5b294a778da95c7017a9fbe4f5232354
@Huxpro Huxpro added the question Further information is requested label Aug 31, 2021
@Huxpro
Copy link
Contributor

Huxpro commented Aug 31, 2021

Close due to staleness. The difference between "Debugging JS on Hermes using Google Chrome's DevTools" vs. "Remote JS Debugging" had been documented on https://reactnative.dev/docs/hermes#debugging-js-on-hermes-using-google-chromes-devtools

Please open a new issue if you have further difficulties regarding debugging with Hermes. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need more info Awating additional info before proceeding question Further information is requested
Projects
None yet
Development

No branches or pull requests