Extends and class are no longer part of the example code 'above'. Add… #2366
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed the arrow function as an additional example
|
Hi @magnusbrattlof! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
|
✔️ Deploy preview for react-native ready! 🔨 Explore the source changes: 412e319 🔍 Inspect the deploy logs: https://app.netlify.com/sites/react-native/deploys/5fcb8a0ccea712000857539f 😎 Browse the preview: https://deploy-preview-2366--react-native.netlify.app |
Simek
approved these changes
Dec 5, 2020
There was a problem hiding this comment.
Hi @magnusbrattlof, thank you for pushing an update for the docs! 👍
The issue you are referring to has already been fixed in base docs (/docs/) in #2259 PR, but versioned docs have not been updated. To avoid unnecessary differences between the docs versions I have copied the fix from base page.
sunnylqm
added a commit
to reactnativecn/react-native-website
that referenced
this pull request
Dec 7, 2020
commit 82142cc Merge: 38be89c aa97a8f Author: sunnylqm <[email protected]> Date: Mon Dec 7 17:10:40 2020 +0800 Merge branch 'master' of https://github.com/facebook/react-native-website into facebook-master # Conflicts: # website/core/Footer.js commit 38be89c Merge: 0d9a929 bcb8a3d Author: Sunny Luo <[email protected]> Date: Mon Dec 7 16:46:37 2020 +0800 Merge pull request #315 from noah227/production 做了一些调整 commit bcb8a3d Author: Sunny Luo <[email protected]> Date: Mon Dec 7 15:47:32 2020 +0800 Update pressable.md commit 0d9a929 Merge: e9c11c0 d959587 Author: Sunny Luo <[email protected]> Date: Mon Dec 7 15:14:38 2020 +0800 Merge pull request #316 from hqwlkj/patch-4 Update typescript.md commit d959587 Author: Yanghc <[email protected]> Date: Mon Dec 7 15:02:20 2020 +0800 Update typescript.md commit 21eeb45 Author: noah227 <[email protected]> Date: Mon Dec 7 12:10:33 2020 +0800 commit e9c11c0 Merge: 3ebae53 dbac391 Author: Sunny Luo <[email protected]> Date: Mon Dec 7 11:10:45 2020 +0800 Merge pull request #309 from noah227/production cndocs pressable translation(partially) commit dbac391 Author: Sunny Luo <[email protected]> Date: Mon Dec 7 11:06:28 2020 +0800 Update pressable.md commit aa97a8f Author: Ray Holland <[email protected]> Date: Sat Dec 5 17:06:02 2020 -0600 Update drawerlayoutandroid.md (facebook#2342) * Update drawerlayoutandroid.md More detailed example of how to use openDrawer and closeDrawer * revert changes, update snack example, update base docs Co-authored-by: Bartosz Kaszubowski <[email protected]> commit 92f92be Author: Ilya Zarembsky <[email protected]> Date: Sat Dec 5 17:22:46 2020 -0500 Recommend Node be installed via nvm-windows (facebook#2312) * Recommend Node be installed via nvm-windows By installing Node via nvm-windows instead of directly, users will be able to easily switch between the multiple different versions of Node that their various projects may require. * Pacify language linter * convert nvm addition to separate paragraph, update base docs * revert change in versioned docs Co-authored-by: Ilya Zarembsky <[email protected]> Co-authored-by: Bartosz Kaszubowski <[email protected]> commit e50d8a4 Author: Bartosz Kaszubowski <[email protected]> Date: Sat Dec 5 22:54:33 2020 +0100 fix few Lighthouse warnings, remove old Footer file (facebook#2371) commit ecd6041 Author: Bartosz Kaszubowski <[email protected]> Date: Sat Dec 5 20:44:50 2020 +0100 update Share, Shadow and View Props pages to match latest patterns (facebook#2370) commit 03eb786 Author: Luis Miguel Alvarado <[email protected]> Date: Sat Dec 5 14:13:36 2020 -0400 [docs]: Add 0.64 required updates to the documentation - Part 1/x (facebook#2368) * Add support for shadowColor on Android >= 28 * Add support to image progress event on Android * ScrollView now supports contentOffset in Android * Add showSoftInputOnFocus to TextInput on iOS * Removed DEPRECATED_sendUpdatedChildFrames prop from ScrollView * Added unstable_pressDelay prop to Pressable * Apply suggested changes commit 0ad8af3 Author: Bartosz Kaszubowski <[email protected]> Date: Sat Dec 5 14:57:59 2020 +0100 add loading param to remark-snackplayer plugin (facebook#2367) commit 3e30040 Author: Magnus Brattlöf <[email protected]> Date: Sat Dec 5 14:57:42 2020 +0100 Extends and class are no longer part of the example code 'above'. Add… (facebook#2366) * Extends and class are no longer part of the example code 'above'. Added the arrow function as an additional example * use fix from the current docs Co-authored-by: Bartosz Kaszubowski <[email protected]> commit 48e2417 Author: Xuan Huang (黄玄) <[email protected]> Date: Fri Dec 4 09:12:36 2020 -0800 Update hermes.md to include RN compatibility (facebook#2361) * Update hermes.md to include RN compatibility Hermes works more reliably following the versions explicitly documented in its releases page. This is suggested by the community at facebook/hermes#33 (comment) * port the addition to the base docs Co-authored-by: Bartosz Kaszubowski <[email protected]> commit 3c72887 Author: Xuan Huang (黄玄) <[email protected]> Date: Fri Dec 4 08:18:34 2020 -0800 Update hermes.md to explain debugging on Hermes (facebook#2360) * Update hermes.md to explain debugging on Hermes This has been a frequently source of confusion. See facebook/hermes#48 (comment) for an example. * fix link format, update base docs * add missing tweak to base docs Co-authored-by: Bartosz Kaszubowski <[email protected]> commit c5f95fa Author: Bartosz Kaszubowski <[email protected]> Date: Thu Dec 3 19:19:36 2020 +0100 fix "Javascript" capitalization typo across all docs (facebook#2365) commit 572843a Author: Moti Zilberman <[email protected]> Date: Thu Dec 3 17:50:57 2020 +0000 Javascript->JavaScript in native-modules-intro (facebook#2364) Capitalisation fix. commit 1e82527 Author: lauramedalia <[email protected]> Date: Thu Dec 3 10:01:42 2020 -0500 Updating Native Modules Documentation (facebook#2261) * feat: updating Native Modules docs * feat: update native modules documentation (missed the docs changes) * converting nativemodules to native modules * language lint tweaks * Update docs/native-modules-ios.md * feat: apply code review comments that needed grammer. changes * feat: updating intro * feat: apply comment changes * feat: remove () from method names * feat: cleaning up docs/responding to comments * feat: adding the new titles to the original docs * feat: updating base doc title * feat: cleaning up notes and removing references to other mobile platforms in mobile platform docs * feat: updating some we's to you's * pulling direct manipulation out * fixing some outstanding yous and wes * updating these to new titles * move ios/android native components section under native components * Adding platform agnostic note back (it was removed when removing content related to iOS from this androids section) * fixing an out of date link to the getting started guides * correcting link * adding turbomodules note * adding parentheses for method names * native module consistency * editing run ios/android commands * using correct code block for java * removing this file, must have stuck around after a merge conflict but its not needed but it should no longer exist in docusouras V2 (i18n will be added in the future) * only editing in 0.63 moving forward * original_id is not needed * cleaning up white space * using correct Apostrophe characters * moving argument types to a table * adding note about where we are adding the method * adding a link to info on turbo modules Co-authored-by: lauramedalia <[email protected]> Co-authored-by: Ramanpreet Nara <[email protected]> commit bfe4f83 Author: Bartosz Kaszubowski <[email protected]> Date: Thu Dec 3 11:25:03 2020 +0100 refreshed FB OSS logo, footer and menu small UI tweaks (facebook#2362) commit 3ebae53 Author: sunnylqm <[email protected]> Date: Thu Dec 3 16:28:49 2020 +0800 Trigger update commit feb0d32 Author: Ben McDonald <[email protected]> Date: Thu Dec 3 02:00:26 2020 -0500 Update intro-react-native-components.md (facebook#2363) Small typo. A grammatical fix. commit 7d6a964 Author: Harsh Thakkar <[email protected]> Date: Wed Dec 2 05:44:52 2020 +0530 Installation word spelling mistake (facebook#2353) * Installation word spelling mistake * fix remaining "intallation" typos Co-authored-by: Bartosz Kaszubowski <[email protected]> commit f3ee2ef Author: Jessica Lin <[email protected]> Date: Tue Dec 1 15:39:30 2020 -0800 Add Call of Duty Companion App, NerdWallet, Foreca, LendMN, and FlipKart into showcase (facebook#2344) * Add Call of Duty Companion App and NerdWallet into showcase * Move Discord up on showcase * Add FlipKart, Foreca, LendMN to showcase commit dcfcda3 Author: Bartosz Kaszubowski <[email protected]> Date: Mon Nov 30 14:00:44 2020 +0100 add simple React Native logo animation (facebook#2339) commit 2354d56 Author: Bartosz Kaszubowski <[email protected]> Date: Mon Nov 30 13:58:44 2020 +0100 small tweaks for the docs sidebar (facebook#2359) commit 87fa863 Author: Bartosz Kaszubowski <[email protected]> Date: Mon Nov 30 13:17:45 2020 +0100 add temporary fix for navbar overflow issue (facebook#2358) * add temporary fix for navbar overflow issue * small tweak commit 572f7a7 Author: noah227 <[email protected]> Date: Sun Nov 29 19:03:47 2020 +0800 pressable.md 翻译（不完全）小调整 commit 267770c Author: noah227 <[email protected]> Date: Sun Nov 29 18:49:13 2020 +0800 pressable.md 翻译细微调整 commit 53c6718 Author: noah227 <[email protected]> Date: Sun Nov 29 18:38:51 2020 +0800 most part translated. commit 27a3372 Author: luism3861 <[email protected]> Date: Fri Nov 27 13:10:22 2020 -0600 update link name in MaskedViewIOS (facebook#2354) Co-authored-by: luism3861 <[email protected]> commit e73993f Author: Khalid Magdy Khalil <[email protected]> Date: Fri Nov 27 21:06:31 2020 +0200 Update running-on-device.md (facebook#2357) * Update running-on-device.md Remove the parts that mention xip.io since it's no longer used. facebook/react-native@40a8434#diff-0eeea47fa4bace26fa6c492a03fa0ea3923a2d8d54b7894f7760cb9131ab65eb * Update running-on-device.md commit 2f651e4 Author: HenokT <[email protected]> Date: Thu Nov 26 19:56:42 2020 +0300 Minor grammar correction to tutorial.md (facebook#2351) * Update tutorial.md * Update tutorial.md for version-0.62
sunnylqm
added a commit
to reactnativecn/react-native-website
that referenced
this pull request
Dec 23, 2020
* Init * Squashed commit of the following: commit 82142cc Merge: 38be89c aa97a8f Author: sunnylqm <[email protected]> Date: Mon Dec 7 17:10:40 2020 +0800 Merge branch 'master' of https://github.com/facebook/react-native-website into facebook-master # Conflicts: # website/core/Footer.js commit 38be89c Merge: 0d9a929 bcb8a3d Author: Sunny Luo <[email protected]> Date: Mon Dec 7 16:46:37 2020 +0800 Merge pull request #315 from noah227/production 做了一些调整 commit bcb8a3d Author: Sunny Luo <[email protected]> Date: Mon Dec 7 15:47:32 2020 +0800 Update pressable.md commit 0d9a929 Merge: e9c11c0 d959587 Author: Sunny Luo <[email protected]> Date: Mon Dec 7 15:14:38 2020 +0800 Merge pull request #316 from hqwlkj/patch-4 Update typescript.md commit d959587 Author: Yanghc <[email protected]> Date: Mon Dec 7 15:02:20 2020 +0800 Update typescript.md commit 21eeb45 Author: noah227 <[email protected]> Date: Mon Dec 7 12:10:33 2020 +0800 commit e9c11c0 Merge: 3ebae53 dbac391 Author: Sunny Luo <[email protected]> Date: Mon Dec 7 11:10:45 2020 +0800 Merge pull request #309 from noah227/production cndocs pressable translation(partially) commit dbac391 Author: Sunny Luo <[email protected]> Date: Mon Dec 7 11:06:28 2020 +0800 Update pressable.md commit aa97a8f Author: Ray Holland <[email protected]> Date: Sat Dec 5 17:06:02 2020 -0600 Update drawerlayoutandroid.md (facebook#2342) * Update drawerlayoutandroid.md More detailed example of how to use openDrawer and closeDrawer * revert changes, update snack example, update base docs Co-authored-by: Bartosz Kaszubowski <[email protected]> commit 92f92be Author: Ilya Zarembsky <[email protected]> Date: Sat Dec 5 17:22:46 2020 -0500 Recommend Node be installed via nvm-windows (facebook#2312) * Recommend Node be installed via nvm-windows By installing Node via nvm-windows instead of directly, users will be able to easily switch between the multiple different versions of Node that their various projects may require. * Pacify language linter * convert nvm addition to separate paragraph, update base docs * revert change in versioned docs Co-authored-by: Ilya Zarembsky <[email protected]> Co-authored-by: Bartosz Kaszubowski <[email protected]> commit e50d8a4 Author: Bartosz Kaszubowski <[email protected]> Date: Sat Dec 5 22:54:33 2020 +0100 fix few Lighthouse warnings, remove old Footer file (facebook#2371) commit ecd6041 Author: Bartosz Kaszubowski <[email protected]> Date: Sat Dec 5 20:44:50 2020 +0100 update Share, Shadow and View Props pages to match latest patterns (facebook#2370) commit 03eb786 Author: Luis Miguel Alvarado <[email protected]> Date: Sat Dec 5 14:13:36 2020 -0400 [docs]: Add 0.64 required updates to the documentation - Part 1/x (facebook#2368) * Add support for shadowColor on Android >= 28 * Add support to image progress event on Android * ScrollView now supports contentOffset in Android * Add showSoftInputOnFocus to TextInput on iOS * Removed DEPRECATED_sendUpdatedChildFrames prop from ScrollView * Added unstable_pressDelay prop to Pressable * Apply suggested changes commit 0ad8af3 Author: Bartosz Kaszubowski <[email protected]> Date: Sat Dec 5 14:57:59 2020 +0100 add loading param to remark-snackplayer plugin (facebook#2367) commit 3e30040 Author: Magnus Brattlöf <[email protected]> Date: Sat Dec 5 14:57:42 2020 +0100 Extends and class are no longer part of the example code 'above'. Add… (facebook#2366) * Extends and class are no longer part of the example code 'above'. Added the arrow function as an additional example * use fix from the current docs Co-authored-by: Bartosz Kaszubowski <[email protected]> commit 48e2417 Author: Xuan Huang (黄玄) <[email protected]> Date: Fri Dec 4 09:12:36 2020 -0800 Update hermes.md to include RN compatibility (facebook#2361) * Update hermes.md to include RN compatibility Hermes works more reliably following the versions explicitly documented in its releases page. This is suggested by the community at facebook/hermes#33 (comment) * port the addition to the base docs Co-authored-by: Bartosz Kaszubowski <[email protected]> commit 3c72887 Author: Xuan Huang (黄玄) <[email protected]> Date: Fri Dec 4 08:18:34 2020 -0800 Update hermes.md to explain debugging on Hermes (facebook#2360) * Update hermes.md to explain debugging on Hermes This has been a frequently source of confusion. See facebook/hermes#48 (comment) for an example. * fix link format, update base docs * add missing tweak to base docs Co-authored-by: Bartosz Kaszubowski <[email protected]> commit c5f95fa Author: Bartosz Kaszubowski <[email protected]> Date: Thu Dec 3 19:19:36 2020 +0100 fix "Javascript" capitalization typo across all docs (facebook#2365) commit 572843a Author: Moti Zilberman <[email protected]> Date: Thu Dec 3 17:50:57 2020 +0000 Javascript->JavaScript in native-modules-intro (facebook#2364) Capitalisation fix. commit 1e82527 Author: lauramedalia <[email protected]> Date: Thu Dec 3 10:01:42 2020 -0500 Updating Native Modules Documentation (facebook#2261) * feat: updating Native Modules docs * feat: update native modules documentation (missed the docs changes) * converting nativemodules to native modules * language lint tweaks * Update docs/native-modules-ios.md * feat: apply code review comments that needed grammer. changes * feat: updating intro * feat: apply comment changes * feat: remove () from method names * feat: cleaning up docs/responding to comments * feat: adding the new titles to the original docs * feat: updating base doc title * feat: cleaning up notes and removing references to other mobile platforms in mobile platform docs * feat: updating some we's to you's * pulling direct manipulation out * fixing some outstanding yous and wes * updating these to new titles * move ios/android native components section under native components * Adding platform agnostic note back (it was removed when removing content related to iOS from this androids section) * fixing an out of date link to the getting started guides * correcting link * adding turbomodules note * adding parentheses for method names * native module consistency * editing run ios/android commands * using correct code block for java * removing this file, must have stuck around after a merge conflict but its not needed but it should no longer exist in docusouras V2 (i18n will be added in the future) * only editing in 0.63 moving forward * original_id is not needed * cleaning up white space * using correct Apostrophe characters * moving argument types to a table * adding note about where we are adding the method * adding a link to info on turbo modules Co-authored-by: lauramedalia <[email protected]> Co-authored-by: Ramanpreet Nara <[email protected]> commit bfe4f83 Author: Bartosz Kaszubowski <[email protected]> Date: Thu Dec 3 11:25:03 2020 +0100 refreshed FB OSS logo, footer and menu small UI tweaks (facebook#2362) commit 3ebae53 Author: sunnylqm <[email protected]> Date: Thu Dec 3 16:28:49 2020 +0800 Trigger update commit feb0d32 Author: Ben McDonald <[email protected]> Date: Thu Dec 3 02:00:26 2020 -0500 Update intro-react-native-components.md (facebook#2363) Small typo. A grammatical fix. commit 7d6a964 Author: Harsh Thakkar <[email protected]> Date: Wed Dec 2 05:44:52 2020 +0530 Installation word spelling mistake (facebook#2353) * Installation word spelling mistake * fix remaining "intallation" typos Co-authored-by: Bartosz Kaszubowski <[email protected]> commit f3ee2ef Author: Jessica Lin <[email protected]> Date: Tue Dec 1 15:39:30 2020 -0800 Add Call of Duty Companion App, NerdWallet, Foreca, LendMN, and FlipKart into showcase (facebook#2344) * Add Call of Duty Companion App and NerdWallet into showcase * Move Discord up on showcase * Add FlipKart, Foreca, LendMN to showcase commit dcfcda3 Author: Bartosz Kaszubowski <[email protected]> Date: Mon Nov 30 14:00:44 2020 +0100 add simple React Native logo animation (facebook#2339) commit 2354d56 Author: Bartosz Kaszubowski <[email protected]> Date: Mon Nov 30 13:58:44 2020 +0100 small tweaks for the docs sidebar (facebook#2359) commit 87fa863 Author: Bartosz Kaszubowski <[email protected]> Date: Mon Nov 30 13:17:45 2020 +0100 add temporary fix for navbar overflow issue (facebook#2358) * add temporary fix for navbar overflow issue * small tweak commit 572f7a7 Author: noah227 <[email protected]> Date: Sun Nov 29 19:03:47 2020 +0800 pressable.md 翻译（不完全）小调整 commit 267770c Author: noah227 <[email protected]> Date: Sun Nov 29 18:49:13 2020 +0800 pressable.md 翻译细微调整 commit 53c6718 Author: noah227 <[email protected]> Date: Sun Nov 29 18:38:51 2020 +0800 most part translated. commit 27a3372 Author: luism3861 <[email protected]> Date: Fri Nov 27 13:10:22 2020 -0600 update link name in MaskedViewIOS (facebook#2354) Co-authored-by: luism3861 <[email protected]> commit e73993f Author: Khalid Magdy Khalil <[email protected]> Date: Fri Nov 27 21:06:31 2020 +0200 Update running-on-device.md (facebook#2357) * Update running-on-device.md Remove the parts that mention xip.io since it's no longer used. facebook/react-native@40a8434#diff-0eeea47fa4bace26fa6c492a03fa0ea3923a2d8d54b7894f7760cb9131ab65eb * Update running-on-device.md commit 2f651e4 Author: HenokT <[email protected]> Date: Thu Nov 26 19:56:42 2020 +0300 Minor grammar correction to tutorial.md (facebook#2351) * Update tutorial.md * Update tutorial.md for version-0.62 * Update * Update prettier * Update security * WIP * Update * Add sponsor and remove old doc * Update * Update * Update * Update * Fix environment setting * Update integration * Update integration * Update integration * Update tabs * Archive doc * Update index * Update introduction * Fix docs * Update docusaurus * Update github action
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extends and class are no longer part of the example code 'above' Added the arrow function as an additional example.